responded to reviews

Author: Scott Clark

moe/views/constant.py

@@ -35,8 +35,34 @@
 from collections import namedtuple
 
 
-MoeRestLogLine = namedtuple('MoeLogLine', ['endpoint', 'type', 'content'])
-MoeRoute = namedtuple('MoeRoute', ['route_name', 'endpoint'])
+_BaseMoeRestLogLine = namedtuple('MoeLogLine', ['endpoint', 'type', 'content'])
+
+
+class MoeRestLogLine(_BaseMoeRestLogLine):
+
+    """The information logged for all MOE REST requests/responses.
+
+    :ivar endpoint: The endpoint that was called
+    :ivar type: Whether this is a ``'request'`` or ``'response'``
+    :ivar content: The json of the request/response
+
+    """
+
+    __slots__ = ()
+
+_BaseMoeRoute = namedtuple('MoeRoute', ['route_name', 'endpoint'])
+
+
+class MoeRoute(_BaseMoeRoute):
+
+    """Information for mapping a MOE ``route_name`` to its corresponding endpoint.
+
+    :ivar route_name: The name of the route (ie ``'gp_ei'``)
+    :ivar endpoint: The endpoint for the route (ie ``'/gp/ei'``)
+
+    """
+
+    __slots__ = ()
 
 GP_EI_ROUTE_NAME = 'gp_ei'
 GP_EI_ENDPOINT = '/gp/ei'

moe/views/optimizable_gp_pretty_view.py

@@ -18,12 +18,8 @@ def get_params_from_request(self):
         :returns: A deserialized self.request_schema object
 
         """
-        self._create_moe_log_line(
-                type='request',
-                content=self.request.json_body,
-                )
-        # Deserialize the basic request schema
-        params = self.request_schema.deserialize(self.request.json_body)
+        # First we get the standard params (not including optimization info)
+        params = super(OptimizableGpPrettyView, self).get_params_from_request()
         optimization_type = params['optimization_info']['optimization_type']
         # Find the schma class that corresponds to the ``optimization_type`` of the request
         schema_class = OPTIMIZATION_TYPES_TO_SCHEMA_CLASSES[optimization_type]()

production.ini

@@ -56,7 +56,7 @@ level = WARN
 handlers = console, filelog
 
 [logger_moe]
-level = DEBUG
+level = INFO
 handlers =
 qualname = moe