Skip to content

Commit db77339

Browse files
RussKieRussKie
authored
Revert "added XML docs tto the AddServiceDefaults and other extensions method…" (dotnet#9237)
This reverts commit 8dc8eee.
1 parent e0fb7a0 commit db77339

File tree

10 files changed

+0
-300
lines changed

10 files changed

+0
-300
lines changed

‎playground/Playground.ServiceDefaults/Extensions.cs

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,6 @@ namespace Microsoft.Extensions.Hosting;
1414
// To learn more about using this project, see https://aka.ms/dotnet/aspire/service-defaults
1515
public static class Extensions
1616
{
17-
/// <summary>
18-
/// Adds default services to the host application builder, including OpenTelemetry configuration,
19-
/// default health checks, service discovery, and HTTP client defaults.
20-
/// </summary>
21-
/// <typeparam name="TBuilder">The type of the host application builder.</typeparam>
22-
/// <param name="builder">The host application builder to configure.</param>
23-
/// <returns>The configured host application builder so that additional calls can be chained.</returns>
2417
public static TBuilder AddServiceDefaults<TBuilder>(this TBuilder builder) where TBuilder : IHostApplicationBuilder
2518
{
2619
builder.ConfigureOpenTelemetry();
@@ -41,12 +34,6 @@ public static TBuilder AddServiceDefaults<TBuilder>(this TBuilder builder) where
4134
return builder;
4235
}
4336

44-
/// <summary>
45-
/// Configures OpenTelemetry for the host application builder.
46-
/// </summary>
47-
/// <typeparam name="TBuilder">The type of the host application builder.</typeparam>
48-
/// <param name="builder">The host application builder to configure.</param>
49-
/// <returns>The configured host application builder so that additional calls can be chained.</returns>
5037
public static TBuilder ConfigureOpenTelemetry<TBuilder>(this TBuilder builder) where TBuilder : IHostApplicationBuilder
5138
{
5239
builder.Logging.AddOpenTelemetry(logging =>
@@ -76,12 +63,6 @@ public static TBuilder ConfigureOpenTelemetry<TBuilder>(this TBuilder builder) w
7663
return builder;
7764
}
7865

79-
/// <summary>
80-
/// Adds OpenTelemetry exporters to the host application builder.
81-
/// </summary>
82-
/// <typeparam name="TBuilder">The type of the host application builder.</typeparam>
83-
/// <param name="builder">The host application builder to configure.</param>
84-
/// <returns>The configured host application builder so that additional calls can be chained.</returns>
8566
private static TBuilder AddOpenTelemetryExporters<TBuilder>(this TBuilder builder) where TBuilder : IHostApplicationBuilder
8667
{
8768
var useOtlpExporter = !string.IsNullOrWhiteSpace(builder.Configuration["OTEL_EXPORTER_OTLP_ENDPOINT"]);
@@ -101,12 +82,6 @@ private static TBuilder AddOpenTelemetryExporters<TBuilder>(this TBuilder builde
10182
return builder;
10283
}
10384

104-
/// <summary>
105-
/// Adds default health checks to the application.
106-
/// </summary>
107-
/// <typeparam name="TBuilder">The type of the host application builder.</typeparam>
108-
/// <param name="builder">The host application builder to configure.</param>
109-
/// <returns>The configured host application builder so that additional calls can be chained.</returns>
11085
public static TBuilder AddDefaultHealthChecks<TBuilder>(this TBuilder builder) where TBuilder : IHostApplicationBuilder
11186
{
11287
builder.Services.AddHealthChecks()
@@ -116,11 +91,6 @@ public static TBuilder AddDefaultHealthChecks<TBuilder>(this TBuilder builder) w
11691
return builder;
11792
}
11893

119-
/// <summary>
120-
/// Maps the default endpoints for health checks in the application.
121-
/// </summary>
122-
/// <param name="app">The <see cref="WebApplication"/> to configure.</param>
123-
/// <returns>The configured <see cref="WebApplication"/>.</returns>
12494
public static WebApplication MapDefaultEndpoints(this WebApplication app)
12595
{
12696
// Adding health checks endpoints to applications in non-development environments has security implications.

‎playground/TestShop/TestShop.ServiceDefaults/Extensions.cs

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,6 @@ public static class Extensions
1717
private const string HealthEndpointPath = "/health";
1818
private const string AlivenessEndpointPath = "/alive";
1919

20-
/// <summary>
21-
/// Adds default services to the host application builder, including OpenTelemetry configuration,
22-
/// default health checks, service discovery, and HTTP client defaults.
23-
/// </summary>
24-
/// <typeparam name="TBuilder">The type of the host application builder.</typeparam>
25-
/// <param name="builder">The host application builder to configure.</param>
26-
/// <returns>The configured host application builder so that additional calls can be chained.</returns>
2720
public static TBuilder AddServiceDefaults<TBuilder>(this TBuilder builder) where TBuilder : IHostApplicationBuilder
2821
{
2922
builder.ConfigureOpenTelemetry();
@@ -44,12 +37,6 @@ public static TBuilder AddServiceDefaults<TBuilder>(this TBuilder builder) where
4437
return builder;
4538
}
4639

47-
/// <summary>
48-
/// Configures OpenTelemetry for the host application builder.
49-
/// </summary>
50-
/// <typeparam name="TBuilder">The type of the host application builder.</typeparam>
51-
/// <param name="builder">The host application builder to configure.</param>
52-
/// <returns>The configured host application builder so that additional calls can be chained.</returns>
5340
public static TBuilder ConfigureOpenTelemetry<TBuilder>(this TBuilder builder) where TBuilder : IHostApplicationBuilder
5441
{
5542
builder.Logging.AddOpenTelemetry(logging =>
@@ -83,12 +70,6 @@ public static TBuilder ConfigureOpenTelemetry<TBuilder>(this TBuilder builder) w
8370
return builder;
8471
}
8572

86-
/// <summary>
87-
/// Adds OpenTelemetry exporters to the host application builder.
88-
/// </summary>
89-
/// <typeparam name="TBuilder">The type of the host application builder.</typeparam>
90-
/// <param name="builder">The host application builder to configure.</param>
91-
/// <returns>The configured host application builder so that additional calls can be chained.</returns>
9273
private static TBuilder AddOpenTelemetryExporters<TBuilder>(this TBuilder builder) where TBuilder : IHostApplicationBuilder
9374
{
9475
var useOtlpExporter = !string.IsNullOrWhiteSpace(builder.Configuration["OTEL_EXPORTER_OTLP_ENDPOINT"]);
@@ -108,12 +89,6 @@ private static TBuilder AddOpenTelemetryExporters<TBuilder>(this TBuilder builde
10889
return builder;
10990
}
11091

111-
/// <summary>
112-
/// Adds default health checks to the application.
113-
/// </summary>
114-
/// <typeparam name="TBuilder">The type of the host application builder.</typeparam>
115-
/// <param name="builder">The host application builder to configure.</param>
116-
/// <returns>The configured host application builder so that additional calls can be chained.</returns>
11792
public static TBuilder AddDefaultHealthChecks<TBuilder>(this TBuilder builder) where TBuilder : IHostApplicationBuilder
11893
{
11994
builder.Services.AddHealthChecks()
@@ -123,11 +98,6 @@ public static TBuilder AddDefaultHealthChecks<TBuilder>(this TBuilder builder) w
12398
return builder;
12499
}
125100

126-
/// <summary>
127-
/// Maps the default endpoints for health checks in the application.
128-
/// </summary>
129-
/// <param name="app">The <see cref="WebApplication"/> to configure.</param>
130-
/// <returns>The configured <see cref="WebApplication"/>.</returns>
131101
public static WebApplication MapDefaultEndpoints(this WebApplication app)
132102
{
133103
// Adding health checks endpoints to applications in non-development environments has security implications.

‎playground/seq/Seq.ServiceDefaults/Extensions.cs

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,6 @@ namespace Microsoft.Extensions.Hosting;
1414
// To learn more about using this project, see https://aka.ms/dotnet/aspire/service-defaults
1515
public static class Extensions
1616
{
17-
/// <summary>
18-
/// Adds default services to the host application builder, including OpenTelemetry configuration,
19-
/// default health checks, service discovery, and HTTP client defaults.
20-
/// </summary>
21-
/// <typeparam name="TBuilder">The type of the host application builder.</typeparam>
22-
/// <param name="builder">The host application builder to configure.</param>
23-
/// <returns>The configured host application builder so that additional calls can be chained.</returns>
2417
public static TBuilder AddServiceDefaults<TBuilder>(this TBuilder builder) where TBuilder : IHostApplicationBuilder
2518
{
2619
builder.ConfigureOpenTelemetry();
@@ -41,12 +34,6 @@ public static TBuilder AddServiceDefaults<TBuilder>(this TBuilder builder) where
4134
return builder;
4235
}
4336

44-
/// <summary>
45-
/// Configures OpenTelemetry for the host application builder.
46-
/// </summary>
47-
/// <typeparam name="TBuilder">The type of the host application builder.</typeparam>
48-
/// <param name="builder">The host application builder to configure.</param>
49-
/// <returns>The configured host application builder so that additional calls can be chained.</returns>
5037
public static TBuilder ConfigureOpenTelemetry<TBuilder>(this TBuilder builder) where TBuilder : IHostApplicationBuilder
5138
{
5239
builder.Logging.AddOpenTelemetry(logging =>
@@ -77,12 +64,6 @@ public static TBuilder ConfigureOpenTelemetry<TBuilder>(this TBuilder builder) w
7764
return builder;
7865
}
7966

80-
/// <summary>
81-
/// Adds OpenTelemetry exporters to the host application builder.
82-
/// </summary>
83-
/// <typeparam name="TBuilder">The type of the host application builder.</typeparam>
84-
/// <param name="builder">The host application builder to configure.</param>
85-
/// <returns>The configured host application builder so that additional calls can be chained.</returns>
8667
private static TBuilder AddOpenTelemetryExporters<TBuilder>(this TBuilder builder) where TBuilder : IHostApplicationBuilder
8768
{
8869
var useOtlpExporter = !string.IsNullOrWhiteSpace(builder.Configuration["OTEL_EXPORTER_OTLP_ENDPOINT"]);
@@ -102,12 +83,6 @@ private static TBuilder AddOpenTelemetryExporters<TBuilder>(this TBuilder builde
10283
return builder;
10384
}
10485

105-
/// <summary>
106-
/// Adds default health checks to the application.
107-
/// </summary>
108-
/// <typeparam name="TBuilder">The type of the host application builder.</typeparam>
109-
/// <param name="builder">The host application builder to configure.</param>
110-
/// <returns>The configured host application builder so that additional calls can be chained.</returns>
11186
public static TBuilder AddDefaultHealthChecks<TBuilder>(this TBuilder builder) where TBuilder : IHostApplicationBuilder
11287
{
11388
builder.Services.AddHealthChecks()
@@ -117,11 +92,6 @@ public static TBuilder AddDefaultHealthChecks<TBuilder>(this TBuilder builder) w
11792
return builder;
11893
}
11994

120-
/// <summary>
121-
/// Maps the default endpoints for health checks in the application.
122-
/// </summary>
123-
/// <param name="app">The <see cref="WebApplication"/> to configure.</param>
124-
/// <returns>The configured <see cref="WebApplication"/>.</returns>
12595
public static WebApplication MapDefaultEndpoints(this WebApplication app)
12696
{
12797
// Adding health checks endpoints to applications in non-development environments has security implications.

‎src/Aspire.ProjectTemplates/templates/aspire-empty/9.2/AspireApplication.1.ServiceDefaults/Extensions.cs

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,6 @@ public static class Extensions
1818
private const string HealthEndpointPath = "/health";
1919
private const string AlivenessEndpointPath = "/alive";
2020

21-
/// <summary>
22-
/// Adds default services to the host application builder, including OpenTelemetry configuration,
23-
/// default health checks, service discovery, and HTTP client defaults.
24-
/// </summary>
25-
/// <typeparam name="TBuilder">The type of the host application builder.</typeparam>
26-
/// <param name="builder">The host application builder to configure.</param>
27-
/// <returns>The configured host application builder so that additional calls can be chained.</returns>
2821
public static TBuilder AddServiceDefaults<TBuilder>(this TBuilder builder) where TBuilder : IHostApplicationBuilder
2922
{
3023
builder.ConfigureOpenTelemetry();
@@ -51,12 +44,6 @@ public static TBuilder AddServiceDefaults<TBuilder>(this TBuilder builder) where
5144
return builder;
5245
}
5346

54-
/// <summary>
55-
/// Configures OpenTelemetry for the host application builder.
56-
/// </summary>
57-
/// <typeparam name="TBuilder">The type of the host application builder.</typeparam>
58-
/// <param name="builder">The host application builder to configure.</param>
59-
/// <returns>The configured host application builder so that additional calls can be chained.</returns>
6047
public static TBuilder ConfigureOpenTelemetry<TBuilder>(this TBuilder builder) where TBuilder : IHostApplicationBuilder
6148
{
6249
builder.Logging.AddOpenTelemetry(logging =>
@@ -91,12 +78,6 @@ public static TBuilder ConfigureOpenTelemetry<TBuilder>(this TBuilder builder) w
9178
return builder;
9279
}
9380

94-
/// <summary>
95-
/// Adds OpenTelemetry exporters to the host application builder.
96-
/// </summary>
97-
/// <typeparam name="TBuilder">The type of the host application builder.</typeparam>
98-
/// <param name="builder">The host application builder to configure.</param>
99-
/// <returns>The configured host application builder so that additional calls can be chained.</returns>
10081
private static TBuilder AddOpenTelemetryExporters<TBuilder>(this TBuilder builder) where TBuilder : IHostApplicationBuilder
10182
{
10283
var useOtlpExporter = !string.IsNullOrWhiteSpace(builder.Configuration["OTEL_EXPORTER_OTLP_ENDPOINT"]);
@@ -116,12 +97,6 @@ private static TBuilder AddOpenTelemetryExporters<TBuilder>(this TBuilder builde
11697
return builder;
11798
}
11899

119-
/// <summary>
120-
/// Adds default health checks to the application.
121-
/// </summary>
122-
/// <typeparam name="TBuilder">The type of the host application builder.</typeparam>
123-
/// <param name="builder">The host application builder to configure.</param>
124-
/// <returns>The configured host application builder so that additional calls can be chained.</returns>
125100
public static TBuilder AddDefaultHealthChecks<TBuilder>(this TBuilder builder) where TBuilder : IHostApplicationBuilder
126101
{
127102
builder.Services.AddHealthChecks()
@@ -131,11 +106,6 @@ public static TBuilder AddDefaultHealthChecks<TBuilder>(this TBuilder builder) w
131106
return builder;
132107
}
133108

134-
/// <summary>
135-
/// Maps the default endpoints for health checks in the application.
136-
/// </summary>
137-
/// <param name="app">The <see cref="WebApplication"/> to configure.</param>
138-
/// <returns>The configured <see cref="WebApplication"/>.</returns>
139109
public static WebApplication MapDefaultEndpoints(this WebApplication app)
140110
{
141111
// Adding health checks endpoints to applications in non-development environments has security implications.

‎src/Aspire.ProjectTemplates/templates/aspire-empty/9.3/AspireApplication.1.ServiceDefaults/Extensions.cs

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,6 @@ public static class Extensions
1818
private const string HealthEndpointPath = "/health";
1919
private const string AlivenessEndpointPath = "/alive";
2020

21-
/// <summary>
22-
/// Adds default services to the host application builder, including OpenTelemetry configuration,
23-
/// default health checks, service discovery, and HTTP client defaults.
24-
/// </summary>
25-
/// <typeparam name="TBuilder">The type of the host application builder.</typeparam>
26-
/// <param name="builder">The host application builder to configure.</param>
27-
/// <returns>The configured host application builder so that additional calls can be chained.</returns>
2821
public static TBuilder AddServiceDefaults<TBuilder>(this TBuilder builder) where TBuilder : IHostApplicationBuilder
2922
{
3023
builder.ConfigureOpenTelemetry();
@@ -51,12 +44,6 @@ public static TBuilder AddServiceDefaults<TBuilder>(this TBuilder builder) where
5144
return builder;
5245
}
5346

54-
/// <summary>
55-
/// Configures OpenTelemetry for the host application builder.
56-
/// </summary>
57-
/// <typeparam name="TBuilder">The type of the host application builder.</typeparam>
58-
/// <param name="builder">The host application builder to configure.</param>
59-
/// <returns>The configured host application builder so that additional calls can be chained.</returns>
6047
public static TBuilder ConfigureOpenTelemetry<TBuilder>(this TBuilder builder) where TBuilder : IHostApplicationBuilder
6148
{
6249
builder.Logging.AddOpenTelemetry(logging =>
@@ -91,12 +78,6 @@ public static TBuilder ConfigureOpenTelemetry<TBuilder>(this TBuilder builder) w
9178
return builder;
9279
}
9380

94-
/// <summary>
95-
/// Adds OpenTelemetry exporters to the host application builder.
96-
/// </summary>
97-
/// <typeparam name="TBuilder">The type of the host application builder.</typeparam>
98-
/// <param name="builder">The host application builder to configure.</param>
99-
/// <returns>The configured host application builder so that additional calls can be chained.</returns>
10081
private static TBuilder AddOpenTelemetryExporters<TBuilder>(this TBuilder builder) where TBuilder : IHostApplicationBuilder
10182
{
10283
var useOtlpExporter = !string.IsNullOrWhiteSpace(builder.Configuration["OTEL_EXPORTER_OTLP_ENDPOINT"]);
@@ -116,12 +97,6 @@ private static TBuilder AddOpenTelemetryExporters<TBuilder>(this TBuilder builde
11697
return builder;
11798
}
11899

119-
/// <summary>
120-
/// Adds default health checks to the application.
121-
/// </summary>
122-
/// <typeparam name="TBuilder">The type of the host application builder.</typeparam>
123-
/// <param name="builder">The host application builder to configure.</param>
124-
/// <returns>The configured host application builder so that additional calls can be chained.</returns>
125100
public static TBuilder AddDefaultHealthChecks<TBuilder>(this TBuilder builder) where TBuilder : IHostApplicationBuilder
126101
{
127102
builder.Services.AddHealthChecks()
@@ -131,11 +106,6 @@ public static TBuilder AddDefaultHealthChecks<TBuilder>(this TBuilder builder) w
131106
return builder;
132107
}
133108

134-
/// <summary>
135-
/// Maps the default endpoints for health checks in the application.
136-
/// </summary>
137-
/// <param name="app">The <see cref="WebApplication"/> to configure.</param>
138-
/// <returns>The configured <see cref="WebApplication"/>.</returns>
139109
public static WebApplication MapDefaultEndpoints(this WebApplication app)
140110
{
141111
// Adding health checks endpoints to applications in non-development environments has security implications.

0 commit comments

Comments
 (0)