fix: Proper return type for v2 unbound action (#970)

Author: nlunets

.changeset/lazy-oranges-approve.md

@@ -0,0 +1,5 @@
+---
+'@sap-ux/fe-mockserver-core': patch
+---
+
+Proper return type for v2 unbound action

packages/fe-mockserver-core/src/data/dataAccess.ts

@@ -251,6 +251,7 @@ export class DataAccess implements DataAccessInterface {
             if (actionDefinition) {
                 if (actionDefinition.sourceType !== '') {
                     const targetEntitySet = this.metadata.getEntitySetByType(actionDefinition.sourceType);
+                    const returnEntitySet = this.metadata.getEntitySetByType(actionDefinition.returnType);
                     if (targetEntitySet) {
                         if (actionData) {
                             actionData._type = actionDefinition.name;
@@ -272,10 +273,10 @@ export class DataAccess implements DataAccessInterface {
                             // Enrich data with __metadata for v2
                             if (Array.isArray(outData)) {
                                 outData = outData.map((element) => {
-                                    return enrichElement(targetEntitySet, element);
+                                    return enrichElement(returnEntitySet ?? targetEntitySet, element);
                                 });
                             } else if (outData != null) {
-                                outData = enrichElement(targetEntitySet, outData);
+                                outData = enrichElement(returnEntitySet ?? targetEntitySet, outData);
                             }
                         }
                         return outData;

packages/fe-mockserver-core/test/unit/v2/__snapshots__/functionImport.test.ts.snap

@@ -9,6 +9,25 @@ exports[`Function Import are parsed properly 1`] = `
 ]
 `;
 
+exports[`Function Import are parsed properly 2`] = `
+[
+  {
+    "CommentMandatory": false,
+    "DecisionKey": "Approve",
+    "DecisionText": "Approve",
+    "InstanceID": "'000007298690'",
+    "Nature": "POSITIVE",
+  },
+  {
+    "CommentMandatory": true,
+    "DecisionKey": "Reject",
+    "DecisionText": "Reject",
+    "InstanceID": "'000007298690'",
+    "Nature": "NEGATIVE",
+  },
+]
+`;
+
 exports[`Function Import will fail by default 1`] = `
 [
   {

packages/fe-mockserver-core/test/unit/v2/functionImport.test.ts

@@ -55,6 +55,7 @@ describe('Function Import', () => {
         expect(request.queryPath).toMatchSnapshot();
         const actionData = await dataAccess.performAction(request);
         expect(actionData).toBeTruthy();
+        expect(actionData).toMatchSnapshot();
     });
 
     test('will fail by default', async () => {

packages/fe-mockserver-core/test/unit/v2/services/FunctionImport/EntityContainer.js

@@ -4,19 +4,13 @@ module.exports = {
             var instanceID = odataRequest.allParams.get('InstanceID').replace(/''/g, '');
             return [
                 {
-                    __metadata: {
-                        type: 'TASKPROCESSING.DecisionOption'
-                    },
                     InstanceID: instanceID,
                     DecisionKey: 'Approve',
                     DecisionText: 'Approve',
                     CommentMandatory: false,
                     Nature: 'POSITIVE'
                 },
                 {
-                    __metadata: {
-                        type: 'TASKPROCESSING.DecisionOption'
-                    },
                     InstanceID: instanceID,
                     DecisionKey: 'Reject',
                     DecisionText: 'Reject',