fix(ui5-toolbar-button): add css for ui5-toolbar-button for left alignment (#11913) #11914
+12
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Hello @SAP/ui5-webcomponents-topic-p, Please review that PR Regards, |
kgogov
requested changes
Jul 18, 2025
There was a problem hiding this comment.
Hi @Jianrong-Yu,
First, I’d like to thank you for the effort you put into fixing the toolbar button misalignment.
I’ve reviewed your change — it looks good and works well.
I left one comment that you might consider addressing before we merge.
Best regards,
Konstantin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixed
ui5-toolbar-buttonon left alignment by:ToolbarButtonPopover.css(the file was unused since the refactory 3992b1d)Before:
After:
Fixes #11913