Skip to content

fix(ui5-tokenizer): scroll to end when adding tokens from suggestions #12242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(ui5-tokenizer): scroll to end when adding tokens from suggestions #12242

wants to merge 4 commits into from

Conversation

Vonahz
Copy link
Contributor

@Vonahz Vonahz commented Sep 2, 2025 •
edited
Loading

Fixes: #12104

Fix the visual issue when add/remove items through suggestions to tokenizer by scrolling tokenizer to the end.

@Vonahz Vonahz changed the title fix(ui-tokenizer): scroll to end when tokenizer is expanded fix(ui5-tokenizer): scroll to end when tokenizer is expanded Sep 2, 2025
@Vonahz Vonahz requested a review from ndeshev September 3, 2025 08:21
ndeshev
ndeshev reviewed Sep 4, 2025
View reviewed changes
Copy link
Contributor

@ndeshev ndeshev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could adjust the PR title and description, the scroll to end improvement is specifically for the case when the items are being currently selected from the open suggestion popover

@Vonahz Vonahz changed the title fix(ui5-tokenizer): scroll to end when tokenizer is expanded fix(ui5-tokenizer): scroll to end when adding tokens from suggestions Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndeshev ndeshev ndeshev left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ui5-multi-combobox]: Filter display breaks with multiple selections
2 participants
@Vonahz @ndeshev