Pure fixed-point math functions

[heinezen]

Required Skills: C++

Difficulty: Easy

We should add additional math operations to our fixed-point implementation, so that all calculations can be done purely deterministic. The fpm library already has these operations and could be used as an inspiration.

Important here: These operations must not use any floating point arithmetic for the calculation. They must receive fixed-point values as input and must also return a fixed-point value. This means std library calculations should not be used for solving this issue.

Interesting for us:

• sqrt
• min
• max
• abs
• hypot
• atan2

Nice to have:

• sin
• cos
• tan
• pow
• log

Further Reading

• openage fixed-point implementation
• fpm library documentation

[heinezen]

@mingjuu You can :)

I'll assign you right now and if you have any questions, feel free to ask here or in chat.

[AyiStar]

@heinezen Thank! I will touch you if I have any questions.

[adamresemius]

Hello,

Is there anything left to do here that I can contribute to?

[heinezen]

@adamresemius Yes, the unticked boxes in the issue description is what's not implemented at the moment.

[Zain-Balkhi]

I think I know how to implement the other functions in fpm. I have pow already on mine.

[firednerve]

Hey, I'm a beginner and could try my hand at implementing sqrt (and possibly the others after) if it isn't being worked on right now

[heinezen]

@firednerve You are welcome to go for it :)

[firednerve]

Thanks! I’ll ask if I have any questions.

[anatriaslabella]

Hi! Is this issue still open to complete the "nice to have" operations? I do not see the implementations added and would like to try it out as someone who is new to open source!

[PRDeving]

Hi there, sin, cos and tan is already implemented in this PR, same for sqrt and atan2, already implemented

[PRDeving]

already created the missing functions and added missing test cases.
#1765