Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Migrated issue | sirius_signal_lights_driver] Restructure Repository and Package #2

Open
Wihmajster opened this issue May 23, 2024 · 0 comments
Assignees

Comments

@Wihmajster
Copy link
Member

Wihmajster commented May 23, 2024

This is a migrated issue and refers only to sirius_signal_lights_driver package

The current repository appears to only contain package dedicated solely to the Sirius II rover. Consider forking or branching the sirius_robot repository, creating relevant package, and working within this repositories. This approach will simplify future reviews and streamline merging package into the main branch.

Alternatively, if you prefer to work within an independent repository, ensure that the repository structure matches the package structure precisely. This involves removing content irrelevant to the package, such as the "ros_tutorials" folder, and moving everything from "canbus_modules/lamps_control" to the top-level folder.

The purpose of the "canbus_modules" folder is unclear. If it is intended to be a metapackage, the "lamps_control" package should still be located outside of it. For more information on metapackages in ROS 2, refer to this guide: ROS 2 Using Variants. If you are new to this concept, you might also find these resources on ROS 1 metapackages helpful: ROS Metapackages and Catkin Metapackages.

In general, I strongly recommend following the "Filesystem Layout" guide: ROS 2 Filesystem Layout.

@Wihmajster Wihmajster transferred this issue from KlaNiedz/sirius_signal_lights_driver Jun 25, 2024
@Wihmajster Wihmajster changed the title Restructure Repository and Package [Migrated issue | sirius_signal_lights_driver] Restructure Repository and Package Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants