-
Notifications
You must be signed in to change notification settings - Fork 1
Expand file tree
/
Copy pathlogging_test.go
More file actions
317 lines (256 loc) · 8.67 KB
/
logging_test.go
File metadata and controls
317 lines (256 loc) · 8.67 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
package cel2sql_test
import (
"bytes"
"context"
"log/slog"
"strings"
"testing"
"github.com/google/cel-go/cel"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"github.com/spandigital/cel2sql/v3"
"github.com/spandigital/cel2sql/v3/pg"
)
// TestLoggingWithDiscard verifies that default behavior uses discard handler (zero overhead)
func TestLoggingWithoutExplicitLogger(t *testing.T) {
env, err := cel.NewEnv(
cel.Variable("x", cel.IntType),
)
require.NoError(t, err)
ast, issues := env.Compile("x > 10")
require.NoError(t, issues.Err())
// Convert without logger - should work with zero overhead
sql, err := cel2sql.Convert(ast)
require.NoError(t, err)
assert.Equal(t, "x > 10", sql)
}
// TestLoggingWithJSONHandler verifies JSON logging works correctly
func TestLoggingWithJSONHandler(t *testing.T) {
var buf bytes.Buffer
logger := slog.New(slog.NewJSONHandler(&buf, &slog.HandlerOptions{
Level: slog.LevelDebug,
}))
schema := pg.NewSchema([]pg.FieldSchema{
{Name: "id", Type: "integer"},
{Name: "metadata", Type: "jsonb", IsJSON: true, IsJSONB: true},
})
provider := pg.NewTypeProvider(map[string]pg.Schema{"users": schema})
env, err := cel.NewEnv(
cel.CustomTypeProvider(provider),
cel.Variable("users", cel.ObjectType("users")),
)
require.NoError(t, err)
ast, issues := env.Compile(`users.metadata.active == true`)
require.NoError(t, issues.Err())
sql, err := cel2sql.Convert(ast,
cel2sql.WithSchemas(provider.GetSchemas()),
cel2sql.WithLogger(logger),
)
require.NoError(t, err)
assert.Contains(t, sql, "->>")
// Verify logs were written
logOutput := buf.String()
assert.Contains(t, logOutput, "starting CEL to SQL conversion")
assert.Contains(t, logOutput, "conversion completed")
assert.Contains(t, logOutput, "duration")
}
// TestLoggingJSONPathDetection verifies JSON path detection logging
func TestLoggingJSONPathDetection(t *testing.T) {
var buf bytes.Buffer
logger := slog.New(slog.NewJSONHandler(&buf, &slog.HandlerOptions{
Level: slog.LevelDebug,
}))
schema := pg.NewSchema([]pg.FieldSchema{
{Name: "id", Type: "integer"},
{Name: "data", Type: "jsonb", IsJSON: true, IsJSONB: true},
})
provider := pg.NewTypeProvider(map[string]pg.Schema{"records": schema})
env, err := cel.NewEnv(
cel.CustomTypeProvider(provider),
cel.Variable("records", cel.ObjectType("records")),
)
require.NoError(t, err)
ast, issues := env.Compile(`records.data.status == "active"`)
require.NoError(t, issues.Err())
_, err = cel2sql.Convert(ast,
cel2sql.WithSchemas(provider.GetSchemas()),
cel2sql.WithLogger(logger),
)
require.NoError(t, err)
logOutput := buf.String()
// Should log JSON path detection
assert.Contains(t, logOutput, "JSON path")
assert.Contains(t, logOutput, "field type lookup")
}
// TestLoggingComprehensions verifies comprehension logging
func TestLoggingComprehensions(t *testing.T) {
var buf bytes.Buffer
logger := slog.New(slog.NewJSONHandler(&buf, &slog.HandlerOptions{
Level: slog.LevelDebug,
}))
schema := pg.NewSchema([]pg.FieldSchema{
{Name: "id", Type: "integer"},
{Name: "tags", Type: "text", Repeated: true, ElementType: "text"},
})
provider := pg.NewTypeProvider(map[string]pg.Schema{"items": schema})
env, err := cel.NewEnv(
cel.CustomTypeProvider(provider),
cel.Variable("items", cel.ObjectType("items")),
)
require.NoError(t, err)
ast, issues := env.Compile(`items.tags.exists(t, t == "important")`)
require.NoError(t, issues.Err())
_, err = cel2sql.Convert(ast,
cel2sql.WithSchemas(provider.GetSchemas()),
cel2sql.WithLogger(logger),
)
require.NoError(t, err)
logOutput := buf.String()
// Should log comprehension identification
assert.Contains(t, logOutput, "comprehension identified")
assert.Contains(t, logOutput, "exists")
}
// TestLoggingOperatorConversion verifies operator conversion logging
func TestLoggingOperatorConversion(t *testing.T) {
var buf bytes.Buffer
logger := slog.New(slog.NewJSONHandler(&buf, &slog.HandlerOptions{
Level: slog.LevelDebug,
}))
env, err := cel.NewEnv(
cel.Variable("x", cel.IntType),
cel.Variable("y", cel.IntType),
)
require.NoError(t, err)
ast, issues := env.Compile("x > 10 && y < 20")
require.NoError(t, issues.Err())
_, err = cel2sql.Convert(ast, cel2sql.WithLogger(logger))
require.NoError(t, err)
logOutput := buf.String()
// Should log operator conversions
assert.Contains(t, logOutput, "binary operator conversion")
}
// TestLoggingRegexConversion verifies regex pattern conversion logging
func TestLoggingRegexConversion(t *testing.T) {
var buf bytes.Buffer
logger := slog.New(slog.NewJSONHandler(&buf, &slog.HandlerOptions{
Level: slog.LevelDebug,
}))
env, err := cel.NewEnv(
cel.Variable("name", cel.StringType),
)
require.NoError(t, err)
ast, issues := env.Compile(`name.matches("(?i)test.*")`)
require.NoError(t, issues.Err())
_, err = cel2sql.Convert(ast, cel2sql.WithLogger(logger))
require.NoError(t, err)
logOutput := buf.String()
// Should log regex pattern conversion
assert.Contains(t, logOutput, "regex pattern conversion")
assert.Contains(t, logOutput, "case_insensitive")
}
// TestLoggingSchemaLookup verifies schema lookup logging
func TestLoggingSchemaLookup(t *testing.T) {
var buf bytes.Buffer
logger := slog.New(slog.NewJSONHandler(&buf, &slog.HandlerOptions{
Level: slog.LevelDebug,
}))
schema := pg.NewSchema([]pg.FieldSchema{
{Name: "id", Type: "integer"},
{Name: "data", Type: "jsonb", IsJSON: true, IsJSONB: true},
})
provider := pg.NewTypeProvider(map[string]pg.Schema{"users": schema})
env, err := cel.NewEnv(
cel.CustomTypeProvider(provider),
cel.Variable("users", cel.ObjectType("users")),
)
require.NoError(t, err)
ast, issues := env.Compile(`users.data.field == "test"`)
require.NoError(t, issues.Err())
_, err = cel2sql.Convert(ast,
cel2sql.WithSchemas(provider.GetSchemas()),
cel2sql.WithLogger(logger),
)
require.NoError(t, err)
logOutput := buf.String()
// Should log field type lookups for JSON fields
assert.Contains(t, logOutput, "field type lookup")
}
// TestLoggingErrorContext verifies error logging includes context
func TestLoggingErrorContext(t *testing.T) {
var buf bytes.Buffer
logger := slog.New(slog.NewJSONHandler(&buf, &slog.HandlerOptions{
Level: slog.LevelDebug,
}))
env, err := cel.NewEnv(
cel.Variable("x", cel.IntType),
)
require.NoError(t, err)
// Create an invalid AST by using unsupported expression
// (This would require more complex setup, so we'll test the happy path for now)
ast, issues := env.Compile("x > 10")
require.NoError(t, issues.Err())
_, err = cel2sql.Convert(ast, cel2sql.WithLogger(logger))
require.NoError(t, err)
// Verify basic logging works (error logging would need an actual error condition)
logOutput := buf.String()
assert.NotEmpty(t, logOutput)
}
// TestLoggingPerformanceMetrics verifies duration logging
func TestLoggingPerformanceMetrics(t *testing.T) {
var buf bytes.Buffer
logger := slog.New(slog.NewJSONHandler(&buf, &slog.HandlerOptions{
Level: slog.LevelDebug,
}))
env, err := cel.NewEnv(
cel.Variable("x", cel.IntType),
)
require.NoError(t, err)
ast, issues := env.Compile("x > 10")
require.NoError(t, issues.Err())
_, err = cel2sql.Convert(ast, cel2sql.WithLogger(logger))
require.NoError(t, err)
logOutput := buf.String()
// Should include duration metric
assert.Contains(t, logOutput, "duration")
assert.Contains(t, logOutput, "conversion completed")
}
// TestLoggingWithContext verifies logging works with context
func TestLoggingWithContext(t *testing.T) {
var buf bytes.Buffer
logger := slog.New(slog.NewJSONHandler(&buf, &slog.HandlerOptions{
Level: slog.LevelDebug,
}))
ctx := context.Background()
env, err := cel.NewEnv(
cel.Variable("x", cel.IntType),
)
require.NoError(t, err)
ast, issues := env.Compile("x > 10")
require.NoError(t, issues.Err())
_, err = cel2sql.Convert(ast,
cel2sql.WithContext(ctx),
cel2sql.WithLogger(logger),
)
require.NoError(t, err)
logOutput := buf.String()
assert.Contains(t, logOutput, "starting CEL to SQL conversion")
assert.Contains(t, logOutput, "conversion completed")
}
// TestLoggingTextHandler verifies text handler works
func TestLoggingTextHandler(t *testing.T) {
var buf bytes.Buffer
logger := slog.New(slog.NewTextHandler(&buf, &slog.HandlerOptions{
Level: slog.LevelDebug,
}))
env, err := cel.NewEnv(
cel.Variable("x", cel.IntType),
)
require.NoError(t, err)
ast, issues := env.Compile("x > 10")
require.NoError(t, issues.Err())
_, err = cel2sql.Convert(ast, cel2sql.WithLogger(logger))
require.NoError(t, err)
logOutput := buf.String()
// Text handler produces different format but should have key content
assert.True(t, strings.Contains(logOutput, "starting") || strings.Contains(logOutput, "conversion"))
}