[Fix] ZipArchiveEntry Disposed error for large ReqifZ files using ReqIFSerializer.SerializeAsync

Author: lxatstariongroup

ReqIFSharp.Tests/ReqIFSerializerTestFixture.cs

@@ -38,7 +38,7 @@ internal class ReqIFSerializerTestFixture
         private ReqIF reqIF;
 
         private string resultFileUri;
-        private string resultFileUriÀrchive;
+        private string resultFileUriArchive;
         private string asyncResultFileUri;
         private string asyncResultFileUriArchive;
 
@@ -62,7 +62,7 @@ internal class ReqIFSerializerTestFixture
         public void SetUp()
         {
             this.resultFileUri = Path.Combine(TestContext.CurrentContext.TestDirectory, "result.reqif");
-            this.resultFileUriÀrchive = Path.Combine(TestContext.CurrentContext.TestDirectory, "result.reqifz");
+            this.resultFileUriArchive = Path.Combine(TestContext.CurrentContext.TestDirectory, "result.reqifz");
             this.asyncResultFileUri = Path.Combine(TestContext.CurrentContext.TestDirectory, "async-result.reqif");
             this.asyncResultFileUriArchive = Path.Combine(TestContext.CurrentContext.TestDirectory, "async-result.reqifz");
 
@@ -120,7 +120,7 @@ public void TearDown()
         private void CleanUpFiles()
         {
             File.Delete(this.resultFileUri);
-            File.Delete(this.resultFileUriÀrchive);
+            File.Delete(this.resultFileUriArchive);
             File.Delete(this.asyncResultFileUri);
             File.Delete(this.asyncResultFileUriArchive);
         }
@@ -759,7 +759,7 @@ public void Verify_That_ArgumentException_Is_Raised_OnSerialize_to_file()
                 Throws.Exception.TypeOf<ArgumentException>()
                     .With.Message.Contains("One and only one ReqIF object can be serialized to a reqif file. If multiple ReqIF objects need to be serialized, please make use of the reqifz format."));
 
-            filePath = this.resultFileUriÀrchive;
+            filePath = this.resultFileUriArchive;
 
             Assert.That(() => serializer.Serialize(reqifs, filePath),
                 Throws.Exception.TypeOf<ArgumentException>()
@@ -924,9 +924,9 @@ public void Verify_that_multiple_ReqIF_objects_can_be_serialized_to_archive_file
 
             var serializer = new ReqIFSerializer();
 
-            serializer.Serialize(reqifs, this.resultFileUriÀrchive);
+            serializer.Serialize(reqifs, this.resultFileUriArchive);
 
-            Assert.IsTrue(File.Exists(this.resultFileUriÀrchive));
+            Assert.IsTrue(File.Exists(this.resultFileUriArchive));
         }
 
         [Test]
@@ -941,6 +941,13 @@ public async Task Verify_that_multiple_ReqIF_objects_can_be_serialized_to_archiv
             await serializer.SerializeAsync(reqifs, this.asyncResultFileUriArchive, cancellationTokenSource.Token);
 
             Assert.IsTrue(File.Exists(this.asyncResultFileUriArchive));
+
+            var deserializer = new ReqIFDeserializer();
+
+            var deserializedReqifs = await deserializer.DeserializeAsync(this.asyncResultFileUriArchive, cancellationTokenSource.Token);
+
+            Assert.That(deserializedReqifs.Count(), Is.EqualTo(2));
+
         }
     }
 }

ReqIFSharp/ReqIFSerializer.cs

@@ -159,7 +159,6 @@ public async Task SerializeAsync(IEnumerable<ReqIF> reqIfs, Stream stream, Suppo
                     using (var archive = new ZipArchive(stream, ZipArchiveMode.Create, true))
                     {
                         var i = 0;
-                        var tasks = new List<Task>();
 
                         foreach (var reqIf in reqIfs)
                         {
@@ -169,11 +168,10 @@ public async Task SerializeAsync(IEnumerable<ReqIF> reqIfs, Stream stream, Suppo
 
                             using (var reqifEntryStream = reqifEntry.Open())
                             {
-                                tasks.Add( this.WriteXmlToStreamAsync(reqIf, reqifEntryStream, token));
+                                await this.WriteXmlToStreamAsync(reqIf, reqifEntryStream, token);
                             }
                         }
 
-                        await Task.WhenAll(tasks);
                         break;
                     }
                 default: