Skip to content

Commit 567438d

Browse files
committed
Revert "perf: replace react-icons with lucide-react"
This reverts commit d681e44.
1 parent a6ad55c commit 567438d

6 files changed

Lines changed: 26 additions & 12 deletions

File tree

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
"react": "^19.2.4",
3434
"react-dom": "^19.2.4",
3535
"react-github-calendar": "^5.0.5",
36+
"react-icons": "^5.5.0",
3637
"react-intersection-observer": "^10.0.2",
3738
"tailwindcss": "^4.1.18",
3839
"three": "^0.183.0"

pnpm-lock.yaml

Lines changed: 12 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/pages/github/CodingProfiles.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import { motion } from "motion/react";
2-
import { ArrowUpRight, Trophy, Code, Star, Github } from "lucide-react";
2+
import { ArrowUpRight, Trophy, Code, Star } from "lucide-react";
3+
import { FaGithub } from "react-icons/fa6";
34
import { getCodingPlatformStats } from "@data/dataLoader";
45
import type { CodingPlatformStat } from "@/types";
56
import { staggerContainer, fadeInUp } from "@utils/animations";
@@ -106,7 +107,7 @@ const CodingProfiles = ({ githubUsername }: CodingProfilesProps) => {
106107
whileHover={{ y: -4, borderColor: "rgba(165,165,192,0.3)" }}
107108
style={cardStyle}
108109
>
109-
<Github size={20} style={{ color: TEXT_PRIMARY }} />
110+
<FaGithub size={20} style={{ color: TEXT_PRIMARY }} />
110111
<span
111112
style={{
112113
fontSize: 12,

src/pages/portfolio/ProjectCard.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import { motion } from "motion/react";
2-
import { ExternalLink, Github } from "lucide-react";
2+
import { ExternalLink } from "lucide-react";
3+
import { FaGithub } from "react-icons/fa";
34
import { scaleRotateIn } from "@utils/animations";
45
import { MONO_FONT } from "@/constants/theme";
56
import {
@@ -171,7 +172,7 @@ const ProjectCard = ({ data, index = 0, onOpen }: ProjectCardProps) => {
171172
href={data.github}
172173
label="Source"
173174
ariaLabel={`View ${data.title} on GitHub`}
174-
icon={Github}
175+
icon={FaGithub}
175176
accentColor={colors.accent}
176177
/>
177178
)}

src/utils/iconMap.ts

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,12 @@
1-
import { Linkedin, Github, Instagram, Twitter } from "lucide-react";
1+
import { FaLinkedin, FaGithub, FaInstagram } from "react-icons/fa6";
2+
import { SiX } from "react-icons/si";
23
import type { IconMap } from "@/types";
34

4-
// Keys are the icon identifiers stored in personal.json/contact.json so that
5-
// the JSON data doesn't need to change when we swap icon libraries.
65
const ICON_MAP: IconMap = {
7-
BsLinkedin: Linkedin,
8-
FaGithub: Github,
9-
FiInstagram: Instagram,
10-
SiX: Twitter,
6+
BsLinkedin: FaLinkedin,
7+
FaGithub: FaGithub,
8+
FiInstagram: FaInstagram,
9+
SiX: SiX,
1110
};
1211

1312
export default ICON_MAP;

vite.config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ export default defineConfig(() => ({
3333
output: {
3434
manualChunks: {
3535
vendor: ["react", "react-dom"],
36-
icons: ["lucide-react"],
36+
icons: ["react-icons", "lucide-react"],
3737
animations: ["motion"],
3838
threejs: ["three", "@react-three/fiber", "@react-three/drei"],
3939
particles: ["@tsparticles/react", "@tsparticles/slim"],

0 commit comments

Comments
 (0)