fix: allowed composite identifiers with differents types

Author: Sarahshr

features/main/composite.feature

@@ -132,3 +132,8 @@ Feature: Retrieve data with Composite identifiers
     Then the response status code should be 200
     And the response should be in JSON
     And the header "Content-Type" should be equal to "application/ld+json; charset=utf-8"
+
+  Scenario: Get identifiers with different type
+    Given there are Composite identifier objects
+    When I send a "GET" request to "/composite_key_with_different_types/id=82133;verificationKey=7d75af772e637e45c36d041696e1128d"
+    Then the response status code should be 200

src/Api/UriVariablesConverter.php

@@ -44,7 +44,9 @@ public function convert(array $uriVariables, string $class, array $context = [])
 
         foreach ($uriVariables as $parameterName => $value) {
             $uriVariableDefinition = $uriVariablesDefinitions[$parameterName] ?? $uriVariablesDefinitions['id'] ?? new Link();
-            if ([] === $types = $this->getIdentifierTypes($uriVariableDefinition->getFromClass() ?? $class, $uriVariableDefinition->getIdentifiers() ?? [$parameterName])) {
+
+            $identifierTypes = $this->getIdentifierTypes($uriVariableDefinition->getFromClass() ?? $class, $uriVariableDefinition->getIdentifiers() ?? [$parameterName]);
+            if (!($types = $identifierTypes[$parameterName] ?? false)) {
                 continue;
             }
 
@@ -61,7 +63,6 @@ public function convert(array $uriVariables, string $class, array $context = [])
                 }
             }
         }
-
         return $uriVariables;
     }
 
@@ -71,7 +72,7 @@ private function getIdentifierTypes(string $resourceClass, array $properties): a
         foreach ($properties as $property) {
             $propertyMetadata = $this->propertyMetadataFactory->create($resourceClass, $property);
             foreach ($propertyMetadata->getBuiltinTypes() as $type) {
-                $types[] = Type::BUILTIN_TYPE_OBJECT === ($builtinType = $type->getBuiltinType()) ? $type->getClassName() : $builtinType;
+                $types[$property][] = Type::BUILTIN_TYPE_OBJECT === ($builtinType = $type->getBuiltinType()) ? $type->getClassName() : $builtinType;
             }
         }
 

tests/Fixtures/TestBundle/ApiResource/Issue5396/CompositeKeyWithDifferentType.php

@@ -0,0 +1,23 @@
+<?php
+
+declare(strict_types=1);
+
+namespace ApiPlatform\Tests\Fixtures\TestBundle\ApiResource\Issue5396;
+
+use ApiPlatform\Metadata\ApiProperty;
+use ApiPlatform\Metadata\ApiResource;
+use ApiPlatform\Metadata\Operation;
+
+#[ApiResource(provider: [self::class, 'provide'])]
+class CompositeKeyWithDifferentType {
+
+    #[ApiProperty(identifier: true)]
+    private ?int $id;
+
+    #[ApiProperty(identifier: true)]
+    private ?string $verificationKey;
+
+    public static function provide(Operation $operation, array $uriVariables = [], array $context = []) {
+        return $context;
+    }
+}