Need unit tests for combined models P(Q)S(Q) etc (Trac #1063)

[rprospero]

The combined model code currently doesn't appear to have any unit tests. We should add some tests in to prevent future regressions.

Migrated from http://trac.sasview.org/ticket/1063

{
    "status": "new",
    "changetime": "2018-09-12T10:35:54",
    "_ts": "2018-09-12 10:35:54.428632+00:00",
    "description": "The combined model code currently doesn't appear to have any unit tests.  We should add some tests in to prevent future regressions.",
    "reporter": "awashington",
    "cc": "",
    "resolution": "",
    "workpackage": "Beta Approximation Project",
    "time": "2018-01-23T15:28:30",
    "component": "sasmodels",
    "summary": "Need unit tests for combined models P(Q)S(Q) etc",
    "priority": "critical",
    "keywords": "tests",
    "milestone": "SasView Next Release +1",
    "owner": "awashington",
    "type": "enhancement"
}

[butlerpd]

Trac update at 2018/06/30 18:33:56:

• butler commented:

assuming this is part of the combine models that needs to be worked on for the Beta so moving to that work package. Can be moved back (currently !SasView Bug Fixing) if it is not appropriate here

• butler changed workpackage from "SasView Bug Fixing" to "Beta Approximation Project"

[RichardHeenan]

Trac update at 2018/07/01 21:03:29:

• richardh changed _comment0 from:

Perhaps we could "save analysis" and save I(Q) for a P(Q)S(Q). Then for the test, load analysis, compute and compare a load of the previously saved I(Q).

Any other ideas?

to:

1530628514993821

• richardh commented:

Perhaps we could "save analysis" and save I(Q) for a P(Q)S(Q). Then for the test, load analysis, compute and compare a load of the previously saved I(Q).

Any other ideas?

Paul K says this ought to be done in sasmodels, this would require new code to run integration tests in the source tree, so they would run on sasmodels being installed. See also #137

[RichardHeenan]

Trac update at 2018/07/03 16:08:12:

• richardh changed milestone from "SasView 4.3.0" to "SasView Next Release +1"
• richardh changed priority from "minor" to "critical"
• richardh changed summary from "Need unit tests for combined models" to "Need unit tests for combined models P(Q)S(Q) etc"
• richardh changed type from "defect" to "enhancement"

[RichardHeenan]

Trac update at 2018/09/12 10:35:54: richardh commented:

Though this ticket is really about testing P(Q)S(Q) from sasview, as an example of what can go wrong there were initially issues during the Sept 2018 code camp with the calling of multiplicity models from the new qt5 gui.
(a) the number of shells was not being passed properly, (b) there were issues with the initially loaded default parameters continuing to be being sent to sasmodels from the gui instead of the parameters input by the user. Both of these issues were of course resolved, however note that in both cases the models themselves loaded and passed their "unit tests" correctly! Thus I think that we really should have some functionality testing of the whole sasview gui when dealing with more complex models or P(Q)S(Q).