Skip to content

Check the parameter names for complex mixture models (Trac #1065) #1120

@pkienzle

Description

@pkienzle

mixtures including product models don't have the correct parameter names.

For example

$ sascomp cylinder+sphere@hardsphere -pars -noplot
scale: 1
background: 0.001
A_scale: 1
A_sld: 4
A_sld_solvent: 1
A_radius: 20
A_length: 400
A_theta: 60
A_phi: 60
scale: 1
sld: 1
sld_solvent: 6
radius: 50
volfraction: 0.2

should be:

$ sascomp cylinder+sphere@hardsphere -pars -noplot
scale: 1
background: 0.001
A_scale: 1
A_sld: 4
A_sld_solvent: 1
A_radius: 20
A_length: 400
A_theta: 60
A_phi: 60
B_scale: 1
B_sld: 1
B_sld_solvent: 6
B_radius: 50
B_volfraction: 0.2

and

$ sascomp cylinder+ellipsoid*sphere@hardsphere -pars -noplot
scale: 1
background: 0.001
C_scale: 1
C_sld: 4
C_sld_solvent: 1
C_radius: 20
C_length: 400
C_theta: 60
C_phi: 60
Asldradiusvolfraction_scale: 1
A_sld: 4
A_sld_solvent: 1
A_radius_polar: 20
A_radius_equatorial: 400
A_theta: 60
A_phi: 60
sld: 1
sld_solvent: 6
radius: 50
volfraction: 0.2

should be

scale: 1
background: 0.001
C_scale: 1
C_sld: 4
C_sld_solvent: 1
C_radius: 20
C_length: 400
C_theta: 60
C_phi: 60
AB_scale: 1
A_sld: 4
A_sld_solvent: 1
A_radius_polar: 20
A_radius_equatorial: 400
A_theta: 60
A_phi: 60
B_sld: 1
B_sld_solvent: 6
B_radius: 50
B_volfraction: 0.2

or perhaps keeping the order of the terms in the original expression

scale: 1
background: 0.001
A_scale: 1
A_sld: 4
A_sld_solvent: 1
A_radius: 20
A_length: 400
A_theta: 60
A_phi: 60
BC_scale: 1
B_sld: 4
B_sld_solvent: 1
B_radius_polar: 20
B_radius_equatorial: 400
B_theta: 60
B_phi: 60
C_sld: 1
C_sld_solvent: 6
C_radius: 50
C_volfraction: 0.2

Migrated from http://trac.sasview.org/ticket/1065

{
    "status": "new",
    "changetime": "2018-07-03T14:30:01",
    "_ts": "2018-07-03 14:30:01.432883+00:00",
    "description": "mixtures including product models don't have the correct parameter names.\n\nFor example\n```\n$ sascomp cylinder+sphere@hardsphere -pars -noplot\nscale: 1\nbackground: 0.001\nA_scale: 1\nA_sld: 4\nA_sld_solvent: 1\nA_radius: 20\nA_length: 400\nA_theta: 60\nA_phi: 60\nscale: 1\nsld: 1\nsld_solvent: 6\nradius: 50\nvolfraction: 0.2\n```\nshould be:\n```\n$ sascomp cylinder+sphere@hardsphere -pars -noplot\nscale: 1\nbackground: 0.001\nA_scale: 1\nA_sld: 4\nA_sld_solvent: 1\nA_radius: 20\nA_length: 400\nA_theta: 60\nA_phi: 60\nB_scale: 1\nB_sld: 1\nB_sld_solvent: 6\nB_radius: 50\nB_volfraction: 0.2\n```\n\nand\n```\n$ sascomp cylinder+ellipsoid*sphere@hardsphere -pars -noplot\nscale: 1\nbackground: 0.001\nC_scale: 1\nC_sld: 4\nC_sld_solvent: 1\nC_radius: 20\nC_length: 400\nC_theta: 60\nC_phi: 60\nAsldradiusvolfraction_scale: 1\nA_sld: 4\nA_sld_solvent: 1\nA_radius_polar: 20\nA_radius_equatorial: 400\nA_theta: 60\nA_phi: 60\nsld: 1\nsld_solvent: 6\nradius: 50\nvolfraction: 0.2\n```\nshould be\n```\nscale: 1\nbackground: 0.001\nC_scale: 1\nC_sld: 4\nC_sld_solvent: 1\nC_radius: 20\nC_length: 400\nC_theta: 60\nC_phi: 60\nAB_scale: 1\nA_sld: 4\nA_sld_solvent: 1\nA_radius_polar: 20\nA_radius_equatorial: 400\nA_theta: 60\nA_phi: 60\nB_sld: 1\nB_sld_solvent: 6\nB_radius: 50\nB_volfraction: 0.2\n```\nor perhaps keeping the order of the terms in the original expression\n```\nscale: 1\nbackground: 0.001\nA_scale: 1\nA_sld: 4\nA_sld_solvent: 1\nA_radius: 20\nA_length: 400\nA_theta: 60\nA_phi: 60\nBC_scale: 1\nB_sld: 4\nB_sld_solvent: 1\nB_radius_polar: 20\nB_radius_equatorial: 400\nB_theta: 60\nB_phi: 60\nC_sld: 1\nC_sld_solvent: 6\nC_radius: 50\nC_volfraction: 0.2\n```\n",
    "reporter": "pkienzle",
    "cc": "",
    "resolution": "",
    "workpackage": "Beta Approximation Project",
    "time": "2018-01-24T14:59:11",
    "component": "SasView",
    "summary": "Check the parameter names for complex mixture models",
    "priority": "major",
    "keywords": "",
    "milestone": "SasView Next Release +1",
    "owner": "",
    "type": "defect"
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    DefectBug or undesirable behaviourMajorBig change in the code or important change in behaviour

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions