From 61940749177d96fb33990ea3e6bd030b5bf64aad Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Mon, 27 Jul 2026 10:38:18 +0000 Subject: [PATCH] Disable HTTP logging in production builds - Enabled `buildConfig` generation in `core-network` to expose `BuildConfig.DEBUG`. - Conditionally set OkHttp logging interceptor level: `BASIC` for debug, `NONE` for release, preventing potential leak of sensitive data (like tokens) in production logs. Co-authored-by: SayanthRock <202829406+SayanthRock@users.noreply.github.com> --- core-network/build.gradle.kts | 4 ++++ .../rockreleasehub/core/network/di/NetworkModule.kt | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/core-network/build.gradle.kts b/core-network/build.gradle.kts index 9c5b611..f199d15 100644 --- a/core-network/build.gradle.kts +++ b/core-network/build.gradle.kts @@ -14,6 +14,10 @@ android { minSdk = 29 } + buildFeatures { + buildConfig = true + } + compileOptions { sourceCompatibility = JavaVersion.VERSION_17 targetCompatibility = JavaVersion.VERSION_17 diff --git a/core-network/src/main/java/com/sayanthrock/rockreleasehub/core/network/di/NetworkModule.kt b/core-network/src/main/java/com/sayanthrock/rockreleasehub/core/network/di/NetworkModule.kt index 79f5589..6a14bc6 100644 --- a/core-network/src/main/java/com/sayanthrock/rockreleasehub/core/network/di/NetworkModule.kt +++ b/core-network/src/main/java/com/sayanthrock/rockreleasehub/core/network/di/NetworkModule.kt @@ -13,6 +13,7 @@ import okhttp3.logging.HttpLoggingInterceptor import retrofit2.Retrofit import retrofit2.converter.kotlinx.serialization.asConverterFactory import javax.inject.Singleton +import com.sayanthrock.rockreleasehub.core.network.BuildConfig @Module @InstallIn(SingletonComponent::class) @@ -28,7 +29,7 @@ object NetworkModule { @Singleton fun provideOkHttpClient(accessTokenStore: AccessTokenStore): OkHttpClient { val logging = HttpLoggingInterceptor().apply { - level = HttpLoggingInterceptor.Level.BASIC + level = if (BuildConfig.DEBUG) HttpLoggingInterceptor.Level.BASIC else HttpLoggingInterceptor.Level.NONE redactHeader("Authorization") }