Commit d39f4a2
authored
fix: fixing run number in dataset list (#1976)
## Description
This PR removes the custom function to extract the run number from the
scientific metadata with hard coded key name. It instead uses the
dedicated high level field run_number recently added in the dataset
schema.
<img width="1530" height="923" alt="SciCat_dataset_run_number_fix_1"
src="https://github.com/user-attachments/assets/b03b1d3c-4a07-40ed-8032-0e91145333ec"
/>
<img width="1530" height="923" alt="SciCat_dataset_run_number_fix_2"
src="https://github.com/user-attachments/assets/172907c4-e4de-40af-bbf2-517b19c129fd"
/>
## Motivation
We need to show run number high level field by default. A soon to be
created PR, will allow to include scientific metadata in the datasets
list, so a different run number from scientific metadata will be
addressed by the new PR.
## Changes:
Please provide a list of the changes implemented by this PR
* datasets table
## Tests included
- [ ] Included for each change/fix?
- [ ] Passing? (Merge will not be approved unless this is checked)
## Documentation
- [ ] swagger documentation updated \[required\]
- [ ] official documentation updated \[nice-to-have\]
### official documentation info
If you have updated the official documentation, please provide PR # and
URL of the pages where the updates are included
## Backend version
- [ ] Does it require a specific version of the backend
- which version of the backend is required:
## Summary by Sourcery
Fix run number display in the dataset list by removing the custom
scientific metadata fallback and using the high-level runNumber field,
add localization of table headers, and standardize translation
namespaces across dataset components.
Bug Fixes:
- Use the high-level runNumber field for the dataset list instead of the
scientificMetadata fallback
Enhancements:
- Inject TranslateService to translate dataset table column headers
using the "dataset" namespace
- Unify translation context to "dataset" in both dataset-detail
components
Chores:
- Add console.log statements in DynamicMatTableComponent for debugging2 files changed
+2
-14
lines changedLines changed: 2 additions & 13 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
271 | 271 | | |
272 | 272 | | |
273 | 273 | | |
274 | | - | |
275 | | - | |
276 | | - | |
277 | | - | |
| 274 | + | |
278 | 275 | | |
279 | 276 | | |
280 | 277 | | |
| |||
367 | 364 | | |
368 | 365 | | |
369 | 366 | | |
370 | | - | |
371 | | - | |
| 367 | + | |
372 | 368 | | |
373 | 369 | | |
374 | 370 | | |
| |||
387 | 383 | | |
388 | 384 | | |
389 | 385 | | |
390 | | - | |
391 | | - | |
392 | | - | |
393 | | - | |
394 | | - | |
395 | | - | |
396 | | - | |
397 | 386 | | |
398 | 387 | | |
399 | 388 | | |
| |||
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
553 | 553 | | |
554 | 554 | | |
555 | 555 | | |
556 | | - | |
557 | 556 | | |
558 | 557 | | |
559 | 558 | | |
| |||
0 commit comments