Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some issues with BVDAE solvers #229

Open
7 tasks
ErikQQY opened this issue Oct 30, 2024 · 0 comments
Open
7 tasks

Some issues with BVDAE solvers #229

ErikQQY opened this issue Oct 30, 2024 · 0 comments

Comments

@ErikQQY
Copy link
Member

ErikQQY commented Oct 30, 2024

With the merge of #217, the BVDAE solvers are available now🎉🎉🎉, but the internal need to be further refactored, here are some possible aspects for improvement:

  • The boundary conditions definition is different with the MIRK and shooting, actually there is also a difference between MIRK and Shooting, which reminds me of getting Boundary conditions should always use solution object #208 fixed.
  • The fixed points specification in BVDAE solvers, while MIRK, FIRK, and shooting methods just state condition points in boundary conditions definition, Ascher needs to explicitly state where the points are for the evaluation.
  • The internal side conditions evaluation is bad, we need to refactor that.
  • The recursive flatten and unflatten of arrays in all BVP solvers are being used everywhere, maybe we can directly bake them into RecursiveArrayTools.jl.
  • Some variables are not properly named, need to refactor these.
  • The jacobian of boundary conditions is inconvenient to use, we need to change that.
  • More......
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant