Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BVP Solvers do not accept certain MTK kwargs (:jac, etc.) #265

Open
vyudu opened this issue Jan 16, 2025 · 2 comments
Open

BVP Solvers do not accept certain MTK kwargs (:jac, etc.) #265

vyudu opened this issue Jan 16, 2025 · 2 comments
Labels

Comments

@vyudu
Copy link

vyudu commented Jan 16, 2025

With codegen to BVProblem being added to MTK soon it'd be nice if the BVP solvers could work with the Jacobian, W matrix, etc. that can be generated from it. Currently doing something like

bvp = SciMLBase.BVProblem(lksys, u0map, tspan; guesses, constraints, jac = true)
solve(bvp, MIRK4(), dt = 0.01)

will result in a Unrecognized keyword arguments: [:jac]

@vyudu vyudu added the bug label Jan 16, 2025
@ErikQQY
Copy link
Member

ErikQQY commented Jan 16, 2025

In ModelingToolkit.jl the similar usage for ODESystem(sys::ODESystem, ..., jac=true) is implemented as a dispatch in https://github.com/SciML/ModelingToolkit.jl/blob/2ca9ecfdee95f3026bfbc6b484f9403331615ed7/src/systems/diffeqs/abstractodesystem.jl#L786, so I think this feature need to be implemented in MTK as well.

@vyudu
Copy link
Author

vyudu commented Jan 16, 2025

Right, that part should be coming with SciML/ModelingToolkit.jl#3323

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants