Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix integrating with cache_parameters = true #391

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix integrating with cache_parameters = true #391

wants to merge 2 commits into from
+43 −8

Conversation

SouthEndMusic
Copy link
Member

Fixes #390

@SouthEndMusic SouthEndMusic changed the title Do the fix, test the fix Fix integrating with cache_parameters = true Feb 6, 2025
@SouthEndMusic SouthEndMusic mentioned this pull request Feb 6, 2025
Draft
sathvikbhagavan
sathvikbhagavan reviewed Feb 7, 2025
View reviewed changes
test/integral_tests.jl
@@ -63,6 +62,15 @@ function test_integral(method; args = [], kwargs = [], name::String)
@test_throws DataInterpolations.LeftExtrapolationError integral(func, t[1] - 1.0, t[2])
@test_throws DataInterpolations.RightExtrapolationError integral(
func, t[1], t[end] + 1.0)

# Test integration with cached parameters
if method != RegularizationSmooth
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on your changes, it should also work with RegularizationSmooth?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sathvikbhagavan sathvikbhagavan sathvikbhagavan left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when integrating with cache_parameters = true
2 participants
@SouthEndMusic @sathvikbhagavan