Skip to content

Commit 61dacc1

Browse files
committed
[tests] disable tests expected to fail w/o threads:on
Nowadays we compile with `--threads:on` by default!
1 parent 5899846 commit 61dacc1

File tree

1 file changed

+14
-13
lines changed

1 file changed

+14
-13
lines changed

tests/plotly/test_api.nim

+14-13
Original file line numberDiff line numberDiff line change
@@ -495,20 +495,21 @@ suite "show w/ filename without threads fails compilation":
495495
xs: xs, ys: ys)
496496
let plt = Plot[float](layout: layout, traces: @[d])
497497

498-
## NOTE: the following tests assume the test is compiled without `--threads:on`!
499-
test "Plot - saveImage fails":
500-
check compileFails(plt.saveImage("test.svg"))
498+
when not compileOption("threads"):
499+
## NOTE: the following tests assume the test is compiled without `--threads:on`!
500+
test "Plot - saveImage fails":
501+
check compileFails(plt.saveImage("test.svg"))
501502

502-
test "PlotJson - saveImage fails":
503-
check compileFails(plt.toPlotJson.saveImage("test.svg"))
503+
test "PlotJson - saveImage fails":
504+
check compileFails(plt.toPlotJson.saveImage("test.svg"))
504505

505-
test "Plot - show w/ filename w/o threads:on fails":
506-
check compileFails(plt.show("test.svg"))
506+
test "Plot - show w/ filename w/o threads:on fails":
507+
check compileFails(plt.show("test.svg"))
507508

508-
test "PlotJson - show w/ filename w/o threads:on fails":
509-
check compileFails(plt.toPlotJson.show("test.svg"))
509+
test "PlotJson - show w/ filename w/o threads:on fails":
510+
check compileFails(plt.toPlotJson.show("test.svg"))
510511

511-
test "Grid - show w/ filename w/o threads:on fails":
512-
var grid = createGrid(1)
513-
grid[0] = plt
514-
check compileFails(grid.show("test.svg"))
512+
test "Grid - show w/ filename w/o threads:on fails":
513+
var grid = createGrid(1)
514+
grid[0] = plt
515+
check compileFails(grid.show("test.svg"))

0 commit comments

Comments
 (0)