Skip to content

Conversation

@oxygen-dioxide
Copy link

No description provided.

@Oceania2018 Oceania2018 requested a review from Copilot December 2, 2025 01:47
Copilot finished reviewing on behalf of Oceania2018 December 2, 2025 01:48
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a GitHub Actions workflow for automated testing on pull requests and updates folder name casing in the solution file to improve cross-platform compatibility.

  • Introduces a multi-platform CI/CD workflow that runs tests across Windows, macOS, and Linux (including ARM variants)
  • Updates solution file to use lowercase "examples" folder path for consistency
  • Configures .NET 6.0 and 8.0 for testing

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
.github/workflows/test.yml New GitHub Actions workflow for running tests on multiple OS/architecture combinations
SciSharp.NumSharp.sln Updated folder references from "Examples" to "examples" for case-sensitive file system compatibility

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Comment on lines +15 to +24
- runs-on: windows-11-arm
arch: win-arm64
- runs-on: macos-13
arch: osx-x64
- runs-on: macos-15
arch: osx-arm64
- runs-on: ubuntu-latest
arch: linux-x64
- runs-on: ubuntu-24.04-arm
arch: linux-arm64
Copy link

Copilot AI Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The windows-11-arm and ubuntu-24.04-arm runners are not generally available on GitHub-hosted runners. These are typically only available for GitHub Enterprise Cloud customers with specific licensing. If you're using standard GitHub-hosted runners, these jobs will fail. Consider either:

  1. Removing these ARM runner configurations if they're not available in your environment
  2. Using self-hosted runners for ARM architectures
  3. Verifying your organization has access to these runner types
Suggested change
- runs-on: windows-11-arm
arch: win-arm64
- runs-on: macos-13
arch: osx-x64
- runs-on: macos-15
arch: osx-arm64
- runs-on: ubuntu-latest
arch: linux-x64
- runs-on: ubuntu-24.04-arm
arch: linux-arm64
- runs-on: macos-13
arch: osx-x64
- runs-on: macos-15
arch: osx-arm64
- runs-on: ubuntu-latest
arch: linux-x64

Copilot uses AI. Check for mistakes.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're outdated. According to GitHub's announcement, arm64 Linux and Windows runners are generally available since 2024-09-03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant