Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpin dask when slicing bug is fixed #6264

Open
stephenworsley opened this issue Dec 17, 2024 · 5 comments · May be fixed by #6312
Open

Unpin dask when slicing bug is fixed #6264

stephenworsley opened this issue Dec 17, 2024 · 5 comments · May be fixed by #6312
Assignees
@stephenworsley @ESadek-MO
Milestone
v3.12

Comments

@stephenworsley
Copy link
Contributor

stephenworsley commented Dec 17, 2024 •
edited
Loading

📰 Custom Issue

Dask is currently pinned by the bug raised in #6251, see dask/dask#11614. This pin should be removed when there is a version of dask which fixes this.
@trexfeathers trexfeathers mentioned this issue Dec 17, 2024
Merged
@trexfeathers
Copy link
Contributor

Once un-pinned, we should stop skipping these two doctests, which are fixed by future releases of Dask:

iris/lib/iris/common/resolve.py

Lines 2595 to 2598 in 71fa550

>>> Resolve(cube1, cube2).shape # doctest: +SKIP
(240, 37, 49)
>>> Resolve(cube2, cube1).shape # doctest: +SKIP
(240, 37, 49)

@ESadek-MO ESadek-MO mentioned this issue Dec 20, 2024
Closed
@schlunma schlunma mentioned this issue Feb 4, 2025
Closed
@schlunma
Copy link
Contributor

schlunma commented Feb 4, 2025

Dask 2025.1.0 is now available that includes this fix 🎉

@trexfeathers trexfeathers moved this to 📚 Backlog in 🦔 v3.12.0 Feb 10, 2025
@trexfeathers trexfeathers added this to the v3.12 milestone Feb 10, 2025
@valeriupredoi
Copy link

do you guys want me to open a PR to fix the pin? I can do that, for free 😁

@valeriupredoi valeriupredoi mentioned this issue Feb 11, 2025
Closed
@trexfeathers
Copy link
Contributor

do you guys want me to open a PR to fix the pin? I can do that, for free 😁

By all means 👍

@valeriupredoi valeriupredoi linked a pull request Feb 11, 2025 that will close this issue
Open
@valeriupredoi
Copy link

See #6312 - you owe me exactly one pint 🍺 - nothing's for free 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephenworsley stephenworsley

@ESadek-MO ESadek-MO

Labels
None yet
Projects
🚴 Peloton
Status: No status
🦔 v3.12.0
Status: 📚 Backlog
Milestone
v3.12
Development

Successfully merging a pull request may close this issue.

Unpin dask and pin it to >=2025.1.0 and unSKIP doctests valeriupredoi/iris
5 participants
@valeriupredoi @schlunma @trexfeathers @stephenworsley @ESadek-MO