Spring Cleaning

Remove unnecessary casts/parenthesis,
readonly attributes that are only set during initialization,
private variables that are only used within class,
remove references that are not needed,

added template .git files

Author: kwsch

.gitattributes

@@ -0,0 +1,22 @@
+# Auto detect text files and perform LF normalization
+* text=auto
+
+# Custom for Visual Studio
+*.cs     diff=csharp
+*.sln    merge=union
+*.csproj merge=union
+*.vbproj merge=union
+*.fsproj merge=union
+*.dbproj merge=union
+
+# Standard to msysgit
+*.doc  diff=astextplain
+*.DOC  diff=astextplain
+*.docx diff=astextplain
+*.DOCX diff=astextplain
+*.dot  diff=astextplain
+*.DOT  diff=astextplain
+*.pdf  diff=astextplain
+*.PDF  diff=astextplain
+*.rtf  diff=astextplain
+*.RTF  diff=astextplain

.gitignore

@@ -0,0 +1,243 @@
+#################
+## Eclipse
+#################
+
+*.pydevproject
+.project
+.metadata
+bin/
+tmp/
+*.tmp
+*.bak
+*.swp
+*~.nib
+local.properties
+.classpath
+.settings/
+.loadpath
+
+# External tool builders
+.externalToolBuilders/
+
+# Locally stored "Eclipse launch configurations"
+*.launch
+
+# CDT-specific
+.cproject
+
+# PDT-specific
+.buildpath
+
+
+#################
+## Visual Studio
+#################
+
+## Ignore Visual Studio temporary files, build results, and
+## files generated by popular Visual Studio add-ons.
+
+# User-specific files
+*.suo
+*.user
+*.sln.docstates
+
+# Build results
+
+[Dd]ebug/
+[Rr]elease/
+x64/
+build/
+[Bb]in/
+[Oo]bj/
+
+# MSTest test Results
+[Tt]est[Rr]esult*/
+[Bb]uild[Ll]og.*
+
+*_i.c
+*_p.c
+*.ilk
+*.meta
+*.obj
+*.pch
+*.pdb
+*.pgc
+*.pgd
+*.rsp
+*.sbr
+*.tlb
+*.tli
+*.tlh
+*.tmp
+*.tmp_proj
+*.log
+*.vspscc
+*.vssscc
+.builds
+*.pidb
+*.log
+*.scc
+
+# Visual C++ cache files
+ipch/
+*.aps
+*.ncb
+*.opensdf
+*.sdf
+*.cachefile
+
+# Visual Studio profiler
+*.psess
+*.vsp
+*.vspx
+
+# Guidance Automation Toolkit
+*.gpState
+
+# ReSharper is a .NET coding add-in
+_ReSharper*/
+*.[Rr]e[Ss]harper
+
+# TeamCity is a build add-in
+_TeamCity*
+
+# DotCover is a Code Coverage Tool
+*.dotCover
+
+# NCrunch
+*.ncrunch*
+.*crunch*.local.xml
+
+# Installshield output folder
+[Ee]xpress/
+
+# DocProject is a documentation generator add-in
+DocProject/buildhelp/
+DocProject/Help/*.HxT
+DocProject/Help/*.HxC
+DocProject/Help/*.hhc
+DocProject/Help/*.hhk
+DocProject/Help/*.hhp
+DocProject/Help/Html2
+DocProject/Help/html
+
+# Click-Once directory
+publish/
+
+# Publish Web Output
+*.Publish.xml
+*.pubxml
+
+# NuGet Packages Directory
+## TODO: If you have NuGet Package Restore enabled, uncomment the next line
+#packages/
+
+# Windows Azure Build Output
+csx
+*.build.csdef
+
+# Windows Store app package directory
+AppPackages/
+
+# Others
+sql/
+*.Cache
+ClientBin/
+[Ss]tyle[Cc]op.*
+~$*
+*~
+*.dbmdl
+*.[Pp]ublish.xml
+*.pfx
+*.publishsettings
+
+# RIA/Silverlight projects
+Generated_Code/
+
+# Backup & report files from converting an old project file to a newer
+# Visual Studio version. Backup files are not needed, because we have git ;-)
+_UpgradeReport_Files/
+Backup*/
+UpgradeLog*.XML
+UpgradeLog*.htm
+
+# SQL Server files
+App_Data/*.mdf
+App_Data/*.ldf
+
+
+#############
+## Qt Creator
+#############
+
+*.save
+*.autosave
+
+#############
+## GNU Emacs
+#############
+
+\#*
+.\#*
+*.elc
+
+
+#############
+## Windows detritus
+#############
+
+# Windows image file caches
+Thumbs.db
+ehthumbs.db
+
+# Folder config file
+Desktop.ini
+
+# Recycle Bin used on file shares
+$RECYCLE.BIN/
+
+
+#############
+## OS X
+#############
+
+.DS_Store
+
+
+#############
+## C#
+#############
+
+*.resources
+
+
+#############
+## Python
+#############
+
+*.py[co]
+
+# Packages
+*.egg
+*.egg-info
+dist/
+build/
+eggs/
+parts/
+var/
+sdist/
+develop-eggs/
+.installed.cfg
+
+# Installer logs
+pip-log.txt
+
+# Unit test / coverage reports
+.coverage
+.tox
+
+# Translations
+*.mo
+
+# Mr Developer
+.mr.developer.cfg

Rhydon/Encoding.cs

@@ -1,15 +1,14 @@
-using System;
-using System.Linq;
+using System.Linq;
 using System.Text;
 
 namespace Rhydon
 {
-    public class RBY_Encoding
+    public static class RBY_Encoding
     {
-        internal const byte CHAR_INVALID = 0xFF;
-        internal const byte CHAR_TRAINER = 0xFE;
-        internal const byte CHAR_PK_NUM = 0x7B;
-        internal const byte CHAR_MN_NUM = 0x7D;
+        private const byte CHAR_INVALID = 0xFF;
+        private const byte CHAR_TRAINER = 0xFE;
+        private const byte CHAR_PK_NUM = 0x7B;
+        private const byte CHAR_MN_NUM = 0x7D;
         internal const byte CHAR_MAL_NUM = 0x7E;
         internal const byte CHAR_FEM_NUM = 0x60;
 
@@ -35,12 +34,12 @@ public static byte[] GetBytes(string s)
                 s = FixString(s);
             if (s == "[TRAINER]")
                 return new[] { ASCII_To_RBY[CHAR_TRAINER] };
-            return s.Select(c => ASCII_To_RBY[(int)c]).Concat(new[] { (byte)0x50 }).ToArray();
+            return s.Select(c => ASCII_To_RBY[c]).Concat(new[] { (byte)0x50 }).ToArray();
         }
 
         public static bool Validate(string s)
         {
-            return !s.Any(c => ((int)c > 0xFF) || (ASCII_To_RBY[(int)c] == 0));
+            return !s.Any(c => c > 0xFF || ASCII_To_RBY[c] == 0);
         }
 
         public static string FixString(string s)
@@ -315,7 +314,7 @@ public static string FixString(string s)
 			0x00 /* 0xFF */
 		};
 
-        internal static readonly byte[] RBY_To_ASCII = new[] {
+        internal static readonly byte[] RBY_To_ASCII = {
 			CHAR_INVALID, /* 0x00 */
 			CHAR_INVALID, /* 0x01 */
 			CHAR_INVALID, /* 0x02 */
@@ -574,7 +573,5 @@ public static string FixString(string s)
 			(byte) '9'  /* 0xFF */
 		};
         #endregion
-
     }
-
 }

Rhydon/ItemList.cs

@@ -1,35 +1,26 @@
 using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Text;
-using System.Threading;
-using System.Threading.Tasks;
 
 namespace Rhydon
 {
     public class ItemList
     {
-        private int Capacity;
+        private readonly int Capacity;
         private int Count;
 
-        private ItemEntry[] items; 
+        private readonly ItemEntry[] items; 
 
         public ItemList(byte[] Source, int c)
         {
             Capacity = c;
             Count = Source[0];
-            Count = Source[0];
             if (Count > Capacity)
-                throw new ArgumentOutOfRangeException("Invalid Item List (count > Capacity)");
+                throw new ArgumentOutOfRangeException();
             items = new ItemEntry[Capacity];
             for (int i = 0; i < Capacity; i++)
             {
-                if (i < Count)
-                    items[i] = new ItemEntry(Source[1 + 2*i], Source[2 + 2*i]);
-                else
-                {
-                    items[i] = new ItemEntry(0, 0);
-                }
+                items[i] = i < Count 
+                    ? new ItemEntry(Source[1 + 2*i], Source[2 + 2*i]) 
+                    : new ItemEntry(0, 0);
             }
         }