git-filter-repo: Fix decompress error #6536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
All changes look good. Wait for review from human collaborators. git-filter-repo
|
niheaven
requested changes
Feb 14, 2025
bucket/git-filter-repo.json
Outdated
| @@ -7,12 +7,18 @@ | |||
| "Git": "git", | |||
| "Python 3": "python" | |||
| }, | |||
| "url": "https://github.com/newren/git-filter-repo/archive/v2.47.0.zip#/dl.7z", | |||
| "url": "https://github.com/newren/git-filter-repo/archive/v2.47.0.zip#/dl.bin", | |||
There was a problem hiding this comment.
Suggested change
| "url": "https://github.com/newren/git-filter-repo/archive/v2.47.0.zip#/dl.bin", | |
| "url": "https://github.com/newren/git-filter-repo/archive/v2.47.0.zip#/dl.zi_", |
Should use a meaningful extension
bucket/git-filter-repo.json
Outdated
Comment on lines
14
to
16
| "Expand-ZipArchive -Path \"$dir\\dl.bin\" -DestinationPath \"$dir\" -Removal", | ||
| "Move-Item \"$dir\\git-filter-repo-*\\*\" \"$dir\"; Remove-Item \"$dir\\git-filter-repo-*\"", | ||
| "Copy-Item \"$dir\\git-filter-repo\" \"$dir\\contrib\\filter-repo-demos\" | Out-Null" |
There was a problem hiding this comment.
Suggested change
| "Expand-ZipArchive -Path \"$dir\\dl.bin\" -DestinationPath \"$dir\" -Removal", | |
| "Move-Item \"$dir\\git-filter-repo-*\\*\" \"$dir\"; Remove-Item \"$dir\\git-filter-repo-*\"", | |
| "Copy-Item \"$dir\\git-filter-repo\" \"$dir\\contrib\\filter-repo-demos\" | Out-Null" | |
| "Expand-ZipArchive -Path \"$dir\\dl.zi_\" -DestinationPath \"$dir\" -Removal", | |
| "Move-Item \"$dir\\git-filter-repo-*\\*\" \"$dir\"; Remove-Item \"$dir\\git-filter-repo-*\"" |
The last command is not needed now imo.
There was a problem hiding this comment.
I don't think that's required either.
niheaven
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
Expand-ZipArchiveinstead ofExpand-7zArchiveto resolve #6451.Closes #6451
Relates to #6519
<manifest-name[@version]|chore>: <general summary of the pull request>