Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow this bucket to be made official? #14

Open
rasa opened this issue Dec 18, 2022 · 10 comments
Open

Allow this bucket to be made official? #14

rasa opened this issue Dec 18, 2022 · 10 comments

Comments

@rasa
Copy link
Member

rasa commented Dec 18, 2022

@MCOfficer Per ScoopInstaller/Scoop#5293 let us know your thoughts on allowing this bucket to be made official.

Thanks,
Ross

@MCOfficer
Copy link
Collaborator

Me maintaining this bucket has become a bit eeehh... It leaves much to be desired. It's better than the bucket you currently have, but an official nirsoft bucket really ought to have better active maintenance than this one. I'm open to transferring this bucket to anyone willing and able to do better than me.

@rasa
Copy link
Member Author

rasa commented Dec 18, 2022

We can transfer it to the ScoopInstaller organization, if that's ok. But let's wait a few days as we have yet to hear back from @kodibrown.

@PrplHaz4
Copy link
Contributor

PrplHaz4 commented Jan 4, 2023

We can transfer it to the ScoopInstaller organization, if that's ok. But let's wait a few days as we have yet to hear back from @kodibrown.

@rasa - thanks for taking it on - any word on adopting this bucket in the scoop org?

@rasa
Copy link
Member Author

rasa commented Jan 6, 2023

@MCOfficer We haven't heard back from @kodybrown and it's been three weeks. If you are still interested in moving this repo to @ScoopInstaller org, please transfer it to me, and I will transfer to our org, as you can't directly transfer it to the org per here. Thanks!

@MCOfficer
Copy link
Collaborator

It's all yours from here. Thank you for keeping Scoop awesome!

@PrplHaz4
Copy link
Contributor

PrplHaz4 commented Jan 6, 2023

It's all yours from here. Thank you for keeping Scoop awesome!

Thanks so much for your generosity and support all these years!

Any tips for the org on how best to update and maintain (or run via CI)?

Am I right in thinking that if Nirsoft published the hashes in the PAD file it would greatly simplify the work needed to maintain?

@MCOfficer
Copy link
Collaborator

MCOfficer commented Jan 6, 2023

Any tips for the org on how best to update and maintain (or run via CI)?

The python script is for occasionally synchronizing things with the pad file, not for everyday updates (and it needs a pip install requests). The CI currently consists of a random docker container running on my server, the way scoop did it 3 years ago; i believe there's a a much better system with Github Actions floating around nowadays.

Am I right in thinking that if Nirsoft published the hashes in the PAD file it would greatly simplify the work needed to maintain?

Hashes and whether there are 64-bit download URLs. As of now, the python script just does a best guess at their filename and checks if that exists.

MCOfficer added a commit that referenced this issue Jan 7, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@PrplHaz4
Copy link
Contributor

PrplHaz4 commented Jan 9, 2023

Am I right in thinking that if Nirsoft published the hashes in the PAD file it would greatly simplify the work needed to maintain?

Hashes and whether there are 64-bit download URLs. As of now, the python script just does a best guess at their filename and checks if that exists.

Thank again to you both. It looks like @rasa has already made a lot of progress on migrating the bucket over and getting it updated/working.

I've put my enhancement request to use Nirsoft-provided hashes and download links (eg https://www.nirsoft.net/hash_check/?software=shexview) here: #15 in the hopes it could ease the maintenance burden a bit.

@ikenichiro
Copy link

I've just noticed that this repo is becoming an official repo. Many thanks to MCOfficer for all the time and effort for maintaining this repo!

@PrplHaz4
Copy link
Contributor

Anything the community needs to do to help this happen? I've added it to a couple installs and haven't had any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants