Skip to content

Please Do Not Ask For The User’s Scratch Username And Password #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
Fluffy728 opened this issue Feb 28, 2025 · 9 comments
Closed
2 tasks done
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@Fluffy728
Copy link
Member

Fluffy728 commented Feb 28, 2025

Please do not use their usernames and passwords for sign up, instead we could try to use the Scratch APi for comments, I could make an auth project and we could ask for the user’s username, ask them to comment a code (BUT MAKE IT DIFFRENT EVERYTIME), then when they press OK, it checks if and who commented the code. Then they get signed in with that user that was used to comment the generated code. Or you could use Scratch Auth.

Even if you don’t store it it could scare users off, the website could get deleted, and people can hack. It also says “sign in with scratch”.

  • Remove the form
  • Complete it
@Fluffy728 Fluffy728 added bug Something isn't working help wanted Extra attention is needed labels Feb 28, 2025
@mcgdj
Copy link
Collaborator

mcgdj commented Feb 28, 2025 via email

@mcgdj
Copy link
Collaborator

mcgdj commented Mar 1, 2025

I'll work on it now. The last thing we want is to scare away users, though the login is only stored locally.

@Fluffy728 Fluffy728 removed their assignment Mar 1, 2025
@Fluffy728

This comment has been minimized.

@mcgdj
Copy link
Collaborator

mcgdj commented Mar 1, 2025

Got it. Also, I didn't realize Github didn't support PHP. I fixed it (so it just uses JavaScript), and I still think we're better off than before, but this is still something I have to make sure doesn't happen again...

@Fluffy728
Copy link
Member Author

What about Scratch Auth? Do we need that?

@Fluffy728

This comment has been minimized.

@mcgdj
Copy link
Collaborator

mcgdj commented Mar 1, 2025

Great. I'm not sure Scratch Auth is possible due to API limitations, but as I mentioned, the user has to post their code on their profile. It can only be accessed via local storage, effectively getting rid of impersonation.

@Fluffy728
Copy link
Member Author

But https://auth.itinerary.eu.org/

@Fluffy728
Copy link
Member Author

It’s done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants