Skip to content

Fix strikes page #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Fluffy728 opened this issue Apr 11, 2025 · 4 comments · Fixed by #70
Closed

Fix strikes page #69

Fluffy728 opened this issue Apr 11, 2025 · 4 comments · Fixed by #70
Assignees

Comments

@Fluffy728
Copy link
Member

No description provided.

@Fluffy728
Copy link
Member Author

JavaScript error

@Fluffy728 Fluffy728 moved this to Priority Todo in Website Apr 11, 2025
@mcgdj
Copy link
Collaborator

mcgdj commented Apr 22, 2025

@MentatBot please provide instructions for fixing this.

Copy link
Contributor

mentatbot bot commented Apr 22, 2025

I'm getting to work. See my steps and track my cost here.

  • Wake on any new activity.

Pull Requests:

I always see new activity while actively working. When paused, I'll only respond when tagged unless this box is checked.

Copy link
Contributor

mentatbot bot commented Apr 22, 2025

Hi @mcgdj, I've fixed the issues with the strikes page. Here's what I found and addressed:

  1. HTML Structure Issues:

    • There were nested/unclosed <style> tags causing rendering problems
    • The jQuery script was placed after the closing </html> tag
    • The HTML structure needed proper indentation and organization
  2. JavaScript Error:

    • The code was checking for parameter 'myscratchedaccount' but trying to access a non-existent element with that ID
    • Updated the logic to properly match the available dynamic content sections
  3. Content Fixes:

    • Changed heading from "Staff Profile" to "My Strikes" to correctly identify the page
    • Fixed a typo in the default section ("vaild" → "valid")

I've created Pull Request #70 with these changes. The page should now function correctly to display strikes based on the URL parameter.

@mcgdj mcgdj closed this as completed in #70 Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Priority Todo
Development

Successfully merging a pull request may close this issue.

2 participants