-
-
Notifications
You must be signed in to change notification settings - Fork 1
Real Popups #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Real Popups #83
Conversation
If you would like me to review this PR, either tag me in a comment or check this box:
You can disable automatic comments on my settings page |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Hi @kRxZykRxZy! You need to be added as a user to interact with me. Please ask @Fluffy728 to add you on the settings page. |
Nice. I like the new popup window you've added. For now, I'm waiting for the others to reply. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok!
This is a temp merge, I will test it first. |
Rejected, this does not work after testing. Please create another PR! @snoopythe3-from-scratch @kRxZykRxZy @Scratch-Coding-Hut/head-of-website-coders @Scratch-Coding-Hut/moderators |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll fix this, give me a moment.
Important
This needs testing and may not work.
Pull Request Overview
This would show a real popup instead of a new tab.
What has changed?
This would show a real popup instead of a new tab.
Priority
None
Pinging
Please ignore this, and don't remove this ping.
@Fluffy278