Skip to content

Real Popups #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025
Merged

Real Popups #83

merged 1 commit into from
Jun 16, 2025

Conversation

snoopythe3-from-scratch
Copy link
Collaborator

Important

This needs testing and may not work.

Pull Request Overview

This would show a real popup instead of a new tab.

What has changed?

This would show a real popup instead of a new tab.

Priority

None

Pinging

Please ignore this, and don't remove this ping.

@Fluffy278

Copy link
Contributor

mentatbot bot commented Jun 16, 2025

If you would like me to review this PR, either tag me in a comment or check this box:

  • Review PR

You can disable automatic comments on my settings page

Copy link

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Copy link
Contributor

mentatbot bot commented Jun 16, 2025

Hi @kRxZykRxZy! You need to be added as a user to interact with me. Please ask @Fluffy728 to add you on the settings page.

@mcgdj
Copy link
Collaborator

mcgdj commented Jun 16, 2025

Nice. I like the new popup window you've added. For now, I'm waiting for the others to reply.

Copy link
Member

@Fluffy728 Fluffy728 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok!

@Fluffy728 Fluffy728 merged commit 5a24fbf into main Jun 16, 2025
5 checks passed
@Fluffy728 Fluffy728 deleted the real-popups branch June 16, 2025 22:44
@Fluffy728
Copy link
Member

This is a temp merge, I will test it first.

@Fluffy728 Fluffy728 restored the real-popups branch June 16, 2025 22:45
@Fluffy728 Fluffy728 mentioned this pull request Jun 16, 2025
@Fluffy728 Fluffy728 deleted the real-popups branch June 16, 2025 22:46
@Fluffy728
Copy link
Member

Rejected, this does not work after testing. Please create another PR! @snoopythe3-from-scratch @kRxZykRxZy @Scratch-Coding-Hut/head-of-website-coders @Scratch-Coding-Hut/moderators

Copy link
Collaborator

@mcgdj mcgdj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix this, give me a moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants