Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: createGame & arena position control over API #395

Open
DEADF00D opened this issue Dec 29, 2021 · 4 comments
Open

[Feature]: createGame & arena position control over API #395

DEADF00D opened this issue Dec 29, 2021 · 4 comments
Labels
0.3.x Targeted for a 0.3.x version feature request New feature or request

Comments

@DEADF00D
Copy link

This plugin really rock, and I would like to extend it with some control plugins we made.
The point is to create arena (that I think is done by GameImpl.createGame method), but unfortunatly is completly unaccessible.
I tried to import the main .jar file as maven dependency and call directly createGame as I normally do for plugins without API, but with no luck.
Can you help me on this ?
Also, I think that would make a great add to the main project API.

@DEADF00D DEADF00D added the feature request New feature or request label Dec 29, 2021
@Misat11 Misat11 added the 0.3.x Targeted for a 0.3.x version label Dec 29, 2021
@Misat11
Copy link
Member

Misat11 commented Dec 29, 2021

our maven repository also contains the plugin itself (it has artifact id just "BedWars" and the rest is same). In the current stable version (0.2.22), the class is not called GameImpl but just Game.

@zlataovce
Copy link
Member

zlataovce commented Dec 29, 2021

We're going to add this in 0.3.0, but for the time being, you can access internals marked as private using Reflection, other internals can be accessed like the API (keep in mind that they may change unexpectedly). Also we have the plugin uploaded to our repo, so you don't have to shuffle with the plugin jar: https://repo.screamingsandals.org/#/releases/org/screamingsandals/bedwars/BedWars/0.2.22

@ScreamingSandals ScreamingSandals deleted a comment from Lort533 Dec 29, 2021
@DEADF00D
Copy link
Author

DEADF00D commented Jan 8, 2022

Okay, seems like it's working.
Thanks @Misat11 & @zlataovce for your precious advices.
Should I close the issue ?

@Misat11
Copy link
Member

Misat11 commented Jan 8, 2022

Definitely it'd be nice to have an API so keep it open for now.

@Misat11 Misat11 changed the title createGame & arena position control over API [Feature]: createGame & arena position control over API Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.3.x Targeted for a 0.3.x version feature request New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants