Skip to content

An hostname-based allowlist is too permissive #6

@DavidBruant

Description

@DavidBruant

It allows to redirect to the same hostname at a different port (where a malicious entity may be waiting for the access_token)

It allows for a redirection from a HTTPS origin to a HTTP origin with the same hostname (could be a typo for instance) and a "Man-in-the-middle" would capture the access_token

We should probably move to an origin-based allowlist

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions