Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V1 Microservice has restrictive/conflicting dependencies with common ML frameworks #4899

Open
mwm5945 opened this issue Jun 8, 2023 · 0 comments · May be fixed by #4911
Open

V1 Microservice has restrictive/conflicting dependencies with common ML frameworks #4899

mwm5945 opened this issue Jun 8, 2023 · 0 comments · May be fixed by #4911
Labels
bug v1

Comments

@mwm5945
Copy link
Contributor

mwm5945 commented Jun 8, 2023

Describe the bug

The V1 python microservice has restrictive dependencies, which can conflict with common ML frameworks when installing them. For example, newer version of tensorflow require flatbuffers>=2.0.0, which directly conflicts with the requirement here:

seldon-core/python/setup.py

Line 29 in f9d3950

"flatbuffers<2.0.0",
. I've also seen issues with URLlib, cryptography, and others. Would it be possible to loosen the requirements a bit here to allow broader packages to be utilized?

To reproduce

$ pip3 install seldon-core==1.16.0 tensorflow==2.12.0
... abbreviated output ...
ERROR: Cannot install seldon-core==1.16.0 and tensorflow-macos==2.13.0rc1 because these package versions have conflicting dependencies.

The conflict is caused by:
    seldon-core 1.16.0 depends on flatbuffers<2.0.0
    tensorflow-macos 2.12.0 depends on flatbuffers>=23.1.21

To fix this you could try to:
1. loosen the range of package versions you've specified
2. remove package versions to allow pip attempt to solve the dependency conflict

ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts

Expected behaviour

Environment

Model Details

  • Images of your model: [Output of: kubectl get seldondeployment -n <yourmodelnamespace> <seldondepname> -o yaml | grep image: where <yourmodelnamespace>]
  • Logs of your model: [You can get the logs of your model by running kubectl logs -n <yourmodelnamespace> <seldonpodname> <container>]
@mwm5945 mwm5945 added the bug label Jun 8, 2023
@ukclivecox ukclivecox added the v1 label Jun 9, 2023
@mwm5945 mwm5945 linked a pull request Jun 12, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Loosen v1 microservice dependencies mwm5945/seldon-core
2 participants
@ukclivecox @mwm5945