You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
prediction_pb2.Metric should not drop type key for COUNTER metrics.
context
I've encountered this problem when fixing custom metric logic in PR #4863. I'm trying to call client_custom_metrics for _raw methods to update seldon_metrics and concatenate custom metrics from msg (raw methods response) with user_model.metrics() (if implemented) and I get metrics validation errors for UserObjectLowLevelGrpc in test_metrics. Currently client_custom_metrics is not called for _raw methods and validation passes
The text was updated successfully, but these errors were encountered:
Describe the bug
A
SeldonMessage
with metrics of typeCOUNTER
is missing metric type key, unlike other metric types (GAUGE
,TIMER
)To reproduce
COUNTER
:Let's see whats inside the metrics. A
type: COUNTER
field is missing and validate_metrics function says metrics are invalid:This is different from
GAUGE
andTIMER
metrics, which havetype
key and passesvalidate_metrics
test:Expected behaviour
prediction_pb2.Metric
should not droptype
key forCOUNTER
metrics.context
I've encountered this problem when fixing custom metric logic in PR #4863. I'm trying to call
client_custom_metrics
for_raw
methods to updateseldon_metrics
and concatenate custom metrics from msg (raw methods response) withuser_model.metrics()
(if implemented) and I get metrics validation errors forUserObjectLowLevelGrpc
intest_metrics
. Currentlyclient_custom_metrics
is not called for_raw
methods and validation passesThe text was updated successfully, but these errors were encountered: