Skip to content

Commit c8abc2e

Browse files
committed
chore(agentic): remove unused sweep summary collection
1 parent 4e9744f commit c8abc2e

4 files changed

Lines changed: 7 additions & 86 deletions

File tree

.github/workflows/e2e-tests.yml

Lines changed: 1 addition & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -312,42 +312,8 @@ jobs:
312312
uses: ./.github/workflows/collect-evals.yml
313313
secrets: inherit
314314

315-
collect-agentic-results:
316-
needs: [test-sweep-agentic, test-sweep-multi-node-agentic]
317-
if: ${{ always() && (needs.test-sweep-agentic.result != 'skipped' || needs.test-sweep-multi-node-agentic.result != 'skipped') }}
318-
runs-on: ubuntu-latest
319-
steps:
320-
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
321-
with:
322-
submodules: true
323-
324-
- uses: actions/setup-python@v6
325-
with:
326-
python-version: '3.11'
327-
328-
- name: Install dependencies
329-
run: pip install pandas matplotlib numpy
330-
331-
- name: Download agentic artifacts
332-
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
333-
with:
334-
pattern: 'agentic_*'
335-
path: results/
336-
337-
- name: Run aggregation
338-
env:
339-
PYTHONPATH: utils/agentic-benchmark/scripts:utils/agentic-benchmark/analysis
340-
run: |
341-
python utils/agentic-benchmark/scripts/collect_sweep_results.py results/ aggregated/
342-
343-
- name: Upload aggregated results
344-
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
345-
with:
346-
name: agentic_aggregated
347-
path: aggregated/
348-
349315
calc-success-rate:
350-
needs: [collect-results, collect-evals, collect-agentic-results]
316+
needs: [collect-results, collect-evals]
351317
if: ${{ always() }}
352318
runs-on: ubuntu-latest
353319

utils/test_find_reusable_sweep_run.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -207,13 +207,11 @@ def test_artifact_names_excludes_expired_artifacts(monkeypatch) -> None:
207207
"paginated_github_api",
208208
lambda *args, **kwargs: [
209209
{"name": "results_bmk", "expired": True},
210-
{"name": "agentic_aggregated", "expired": False},
210+
{"name": "run-stats", "expired": False},
211211
],
212212
)
213213

214-
assert reuse.artifact_names("repo", 123, "token") == {
215-
"agentic_aggregated"
216-
}
214+
assert reuse.artifact_names("repo", 123, "token") == {"run-stats"}
217215

218216

219217
def test_main_skips_pr_synchronize_with_reuse_authorization(

utils/test_validate_reusable_sweep_artifacts.py

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -197,8 +197,6 @@ def test_multinode_agentic_identity_fields_match() -> None:
197197
def write_agentic_artifacts(
198198
root: Path,
199199
conc: int = 16,
200-
*,
201-
aggregate: bool = True,
202200
) -> None:
203201
result_name = f"dsv4_tp8_conc{conc}_offloadcpu_result"
204202
point_dir = root / f"bmk_agentic_{result_name}"
@@ -207,12 +205,6 @@ def write_agentic_artifacts(
207205
json.dumps(agentic_result(conc))
208206
)
209207
(root / f"agentic_{result_name}").mkdir()
210-
if aggregate:
211-
aggregate_dir = root / "agentic_aggregated"
212-
aggregate_dir.mkdir()
213-
(aggregate_dir / "summary.csv").write_text(
214-
f"exp_name,status\nagentic_{result_name},SUCCESS\n"
215-
)
216208

217209

218210
def test_eval_validation_requires_raw_result_dirs_not_eval_debug_dirs(
@@ -398,7 +390,7 @@ def test_fixed_sequence_validation_rejects_duplicate_identity(
398390
assert "fixed-sequence artifacts contain 1 duplicate row(s)" in errors
399391

400392

401-
def test_agentic_validation_checks_points_raw_and_aggregate(tmp_path: Path) -> None:
393+
def test_agentic_validation_checks_points_and_raw_artifacts(tmp_path: Path) -> None:
402394
write_agentic_artifacts(tmp_path)
403395

404396
assert validate_agentic_artifacts(tmp_path) == []
@@ -407,7 +399,7 @@ def test_agentic_validation_checks_points_raw_and_aggregate(tmp_path: Path) -> N
407399
def test_agentic_validation_accepts_run_sweep_point_artifacts(
408400
tmp_path: Path,
409401
) -> None:
410-
write_agentic_artifacts(tmp_path, aggregate=False)
402+
write_agentic_artifacts(tmp_path)
411403

412404
assert validate_agentic_artifacts(tmp_path) == []
413405

@@ -420,8 +412,6 @@ def test_agentic_validation_accepts_additional_source_identity(
420412
extra_dir.mkdir()
421413
(extra_dir / "extra.json").write_text(json.dumps(agentic_result(32)))
422414
(tmp_path / "agentic_extra").mkdir()
423-
summary = tmp_path / "agentic_aggregated" / "summary.csv"
424-
summary.write_text(summary.read_text() + "agentic_extra,SUCCESS\n")
425415

426416
assert validate_agentic_artifacts(tmp_path) == []
427417

@@ -443,7 +433,7 @@ def test_agentic_validation_requires_point_and_raw_artifacts(
443433
def test_agentic_validation_rejects_duplicate_point_identity(
444434
tmp_path: Path,
445435
) -> None:
446-
write_agentic_artifacts(tmp_path, aggregate=False)
436+
write_agentic_artifacts(tmp_path)
447437
point_dir = (
448438
tmp_path / "bmk_agentic_dsv4_tp8_conc16_offloadcpu_result"
449439
)

utils/validate_reusable_sweep_artifacts.py

Lines changed: 1 addition & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
from __future__ import annotations
55

66
import argparse
7-
import csv
87
import json
98
import re
109
import shutil
@@ -250,9 +249,7 @@ def validate_agentic_artifacts(
250249
raw_names = {
251250
path.name
252251
for path in artifacts_dir.iterdir()
253-
if path.is_dir()
254-
and path.name.startswith("agentic_")
255-
and path.name != "agentic_aggregated"
252+
if path.is_dir() and path.name.startswith("agentic_")
256253
}
257254
if point_names != raw_names:
258255
missing_raw = point_names - raw_names
@@ -262,36 +259,6 @@ def validate_agentic_artifacts(
262259
for name in sorted(extra_raw):
263260
errors.append(f"unexpected raw agentic artifact dir: {name}")
264261

265-
aggregate_dir = artifacts_dir / "agentic_aggregated"
266-
summary_path = aggregate_dir / "summary.csv"
267-
if aggregate_dir.exists():
268-
if not summary_path.is_file():
269-
errors.append("missing agentic_aggregated/summary.csv")
270-
else:
271-
with open(summary_path, newline="") as handle:
272-
summary_rows = [
273-
str(row.get("exp_name") or "")
274-
for row in csv.DictReader(handle)
275-
if row.get("exp_name")
276-
]
277-
duplicate_names = [
278-
name
279-
for name, count in Counter(summary_rows).items()
280-
if count > 1
281-
]
282-
for name in sorted(duplicate_names):
283-
errors.append(
284-
f"agentic aggregate has duplicate experiment: {name}"
285-
)
286-
summary_names = set(summary_rows)
287-
if summary_names != raw_names:
288-
for name in sorted(raw_names - summary_names):
289-
errors.append(f"agentic aggregate is missing experiment: {name}")
290-
for name in sorted(summary_names - raw_names):
291-
errors.append(
292-
f"agentic aggregate has unexpected experiment: {name}"
293-
)
294-
295262
return errors
296263

297264

0 commit comments

Comments
 (0)