misc: Fix Clippy lints

Author: Serial-ATA

Cargo.toml

@@ -34,8 +34,7 @@ explicit_outlives_requirements = "deny"
 unknown_lints                  = "allow"
 
 [workspace.lints.clippy]
-dbg_macro                          = "forbid"
-string_to_string                   = "forbid"
+dbg_macro                          = "deny"
 pedantic                           = { level = "deny", priority = -1 }
 all                                = { level = "deny", priority = -1 }
 too_many_lines                     = "allow"
@@ -72,6 +71,7 @@ struct_excessive_bools 		       = "allow" # I have yet to find one case of this
 needless_continue                  = "allow" # All occurences of this lint are just for clarity in large loops
 unbuffered_bytes                   = "allow" # It is up to the caller to wrap their data in `BufReader`s
 struct_field_names                 = "allow"
+items_after_statements             = "allow"
 
 [workspace.lints.rustdoc]
 broken_intra_doc_links = "deny"

examples/custom_resolver/src/main.rs

@@ -44,6 +44,7 @@ struct MyFile {
 }
 
 impl MyFile {
+	#[allow(clippy::unnecessary_wraps)]
 	pub fn parse_my_file<R>(_reader: &mut R, _parse_options: ParseOptions) -> LoftyResult<Self>
 	where
 		R: std::io::Read + std::io::Seek,

lofty/src/ape/tag/mod.rs

@@ -923,7 +923,7 @@ mod tests {
 
 	#[test_log::test]
 	fn skip_reading_cover_art() {
-		let p = Picture::unchecked(std::iter::repeat(0).take(50).collect::<Vec<u8>>())
+		let p = Picture::unchecked(std::iter::repeat_n(0, 50).collect::<Vec<u8>>())
 			.pic_type(PictureType::CoverFront)
 			.mime_type(MimeType::Jpeg)
 			.build();

lofty/src/id3/v2/tag/tests.rs

@@ -1284,7 +1284,7 @@ fn hold_back_4_character_txxx_description() {
 
 #[test_log::test]
 fn skip_reading_cover_art() {
-	let p = Picture::unchecked(std::iter::repeat(0).take(50).collect::<Vec<u8>>())
+	let p = Picture::unchecked(std::iter::repeat_n(0, 50).collect::<Vec<u8>>())
 		.pic_type(PictureType::CoverFront)
 		.mime_type(MimeType::Jpeg)
 		.build();

lofty/src/mp4/ilst/mod.rs

@@ -1465,7 +1465,7 @@ mod tests {
 
 	#[test_log::test]
 	fn skip_reading_cover_art() {
-		let p = Picture::unchecked(std::iter::repeat(0).take(50).collect::<Vec<u8>>())
+		let p = Picture::unchecked(std::iter::repeat_n(0, 50).collect::<Vec<u8>>())
 			.pic_type(PictureType::CoverFront)
 			.mime_type(MimeType::Jpeg)
 			.build();

lofty/src/ogg/tag.rs

@@ -896,7 +896,7 @@ mod tests {
 
 	#[test_log::test]
 	fn skip_reading_cover_art() {
-		let p = Picture::unchecked(std::iter::repeat(0).take(50).collect::<Vec<u8>>())
+		let p = Picture::unchecked(std::iter::repeat_n(0, 50).collect::<Vec<u8>>())
 			.pic_type(PictureType::CoverFront)
 			.mime_type(MimeType::Jpeg)
 			.build();

lofty/tests/files/util/mod.rs

@@ -22,14 +22,13 @@ pub fn temp_file(path: impl AsRef<Path>) -> File {
 /// Copy `path` into a [`temp_file()`] and parse it via [`Probe`]
 pub fn read(path: impl AsRef<Path>) -> BoundTaggedFile<File> {
 	let file = temp_file(path);
-	let tagged_file = Probe::new(file)
+
+	Probe::new(file)
 		.options(ParseOptions::new())
 		.guess_file_type()
 		.unwrap()
 		.read_bound()
-		.unwrap();
-
-	tagged_file
+		.unwrap()
 }
 
 /// Verify that the file at `path` has no tags

lofty/tests/taglib/test_apetag.rs

@@ -87,15 +87,14 @@ fn test_invalid_keys() {
 }
 
 #[test_log::test]
-#[ignore]
+#[ignore = "Marker test, Lofty doesn't replicate this API"]
 fn test_text_binary() {
-	// Marker test, this is useless as Lofty does not have a similar API that the test is based upon:
 	// https://github.com/taglib/taglib/blob/a31356e330674640a07bef7d71d08242cae8e9bf/tests/test_apetag.cpp#L153
 }
 
 // TODO: Does not work! We fall for this collision.
 #[test_log::test]
-#[ignore]
+#[ignore = "We currently fall for this collision"]
 fn test_id3v1_collision() {
 	let mut file = temp_file!("tests/taglib/data/no-tags.mpc");
 	{

lofty/tests/taglib/test_fileref.rs

@@ -86,10 +86,10 @@ fn test_musepack() {
 	file_ref_save("click.mpc", FileType::Mpc);
 }
 
+// TODO: We don't support ASF yet
 #[test_log::test]
-#[ignore]
+#[ignore = "AFK is not supported yet"]
 fn test_asf() {
-	// TODO: We don't support ASF yet
 	// file_ref_save("silence-1.asf", FileType::ASF);
 }
 
@@ -113,10 +113,10 @@ fn test_mp3() {
 	file_ref_save("xing.mp3", FileType::Mpeg);
 }
 
+// TODO: We don't support TTA yet
 #[test_log::test]
-#[ignore]
+#[ignore = "TTA is not supported yet"]
 fn test_true_audio() {
-	// TODO: We don't support TTA yet
 	// file_ref_save("empty.tta", FileType::TrueAudio);
 }
 
@@ -145,8 +145,9 @@ fn test_wav() {
 	file_ref_save("empty.wav", FileType::Wav);
 }
 
+// TODO: We don't yet support FLAC in oga
 #[test_log::test]
-#[ignore] // TODO: We don't yet support FLAC in oga
+#[ignore = "FLAC in OGA isn't supported yet"]
 fn test_oga_flac() {
 	file_ref_save("empty_flac.oga", FileType::Flac);
 }

lofty/tests/taglib/test_flac.rs

@@ -217,7 +217,7 @@ fn test_repeated_save_2() {}
 
 // TODO: We don't make use of padding blocks yet
 #[test_log::test]
-#[ignore]
+#[ignore = "FLAC padding blocks aren't used yet"]
 fn test_repeated_save_3() {
 	let mut file = temp_file!("tests/taglib/data/no-tags.flac");
 
@@ -425,7 +425,7 @@ fn test_zero_sized_padding_2() {
 
 // TODO: We don't make use of padding blocks yet
 #[test_log::test]
-#[ignore]
+#[ignore = "FLAC padding blocks aren't used yet"]
 fn test_shrink_padding() {
 	let mut file = temp_file!("tests/taglib/data/silence-44-s.flac");
 	{
@@ -480,7 +480,7 @@ fn test_empty_id3v2() {
 
 // TODO: TagLib doesn't fully remove Vorbis Comments when stripping. It will preserve the vendor string. Should we do the same?
 #[test_log::test]
-#[ignore]
+#[ignore = "Needs to be looked into more"]
 fn test_strip_tags() {
 	// NOTE: In the TagLib test suite, this also tests ID3v1 and ID3v2. That is not replicated here.