Skip to content

Commit 0d42f73

Browse files
committed
In general, you should use the array literal notation when possible. It is easier to read, it gives the compiler a chance to optimize your code, and it's mostly faster too.
1 parent f0964c1 commit 0d42f73

File tree

2 files changed

+86
-1
lines changed

2 files changed

+86
-1
lines changed
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
InPO8pvCMD9mUh_JaTShthpznssMFIICRymMeOi7QVChk76V-EFLUoiXeUjw3OC903vEi4fIDHW7Cg2M90JNyK-fwzVsnd5StkBdeWanv5Of1EDMfZY6sK3Z_UnA7qkB2u6Mm31rthr24Yh9J8hCZxAETxkKpd_zVvvy_bjUoqYZWkx2lI11v2lkQB3QgTn5tHPIV1NY5uGlweZZu1rH7UnUFrZF9TzBnL2hBOb82VfdJch3-kTp1UE9I2HTf5b0YmZtGX8Rozvvf4P40wG8V7WfKb0qab_rJuTF3XMXq3tHBsf5tm6eg4zfobEr_s2eoVJFXVQRXHzjWDCGg5wb_l7faPIaaKzXIBUNLA-wteHz06dGnYUlYVxv0PO5AwM54vaS_z8-ihS-c739CEMu1IeIp5FWjxApSIw2bg7LNXvHgCmhK87Y9nP2TzkIIKmJa2qiQKL-cycmTWc-15zwGraaFfshj-JiznHQ6Pxg4i5uie8nTfuCBdF0lgaVhZoJjQ_4hJeLnb5ON_f4PEr_14eaftxX1U9hvtXyeAj-pvTZkc_WSXBIuRKjdEuzy3MPORtQaQa2khASdhkeCqlavrV-KZWM0NWX8nEHNnJkLNIYqqrRSLbpw-49tjTqzfEVsX7bFOovtQuPfGUDMFU41vsLi52YYtc6i_gvronFdHk
1+
E79Y8Mu1unbrVUarnYnB2V54ymsAauwfQy6DT4vV8djAYhDwH6bfqfESPU1GPBo8sMwTvPsLc4pFRXVmM-cvRnlFYbzEZEjU4syOe8-sh6O4mG3DsmlnV_rimfnuLGWPOM8LU2KileaSf2XoGWE5tXZ8PtTjtRo2uxiF8fiD252Fb4i2u8DxyZ6cZYpBEacjBD7T_fQ71wW2wUZJsLn79GyzkrZ0DNQLxHEByPGpYrjhvJrc-s0jfydZlGeDUuna07bPDprV1qmO1YdX93NVUPrzPLCGTBGnI8MiGreD_2t4sGHbL9YEpqsGM3RRjECQF_3E7B11nV-296qAEV_3OsR16l9i-qeTCPKhpTW1rEip-NeLdiZyVRjmeafuZ6y12zxqXdo-XiNxWAMPH-o6v50-5XidZW_athHTObQec1MxaY9vOEbJHNbAKkHGKCPUiQGasWxkHPPDGNLIYRK5LQPw4pSpnGgk8Fbd_SRY9MPNtlFxbtfSQT-wOcmTaemFoG7kTB2ckBtxUsU-wzLgm1tyADjdIbGi4VsgXd5MOXri3hVGM91uG5Z3s138zGjOxMhBytP_anPM9DBYV6DgTp3WWO667cykHQAuF_yUEnGJpIsPMOtKeCuMX-rla82cpPlcsSkyqgcVsMqgAuPR1Vrptbkuyqee55OF3whW9DA
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,85 @@
1+
<?xml version="1.0" encoding="UTF-8"?><record_update table="scan_script_only_check">
2+
<scan_script_only_check action="INSERT_OR_UPDATE">
3+
<active>true</active>
4+
<category>manageability</category>
5+
<description>In general, you should use the array literal notation when possible. It is easier to read, it gives the compiler a chance to optimize your code, and it's mostly faster too.</description>
6+
<documentation_url/>
7+
<finding_type>scan_finding</finding_type>
8+
<name>Don't use new Array()</name>
9+
<priority>3</priority>
10+
<resolution_details>Validated new Array() pattern on Business rules, Client scripts and Script includes</resolution_details>
11+
<run_condition/>
12+
<score_max>100</score_max>
13+
<score_min>0</score_min>
14+
<score_scale>1</score_scale>
15+
<script><![CDATA[(function(finding, current) {
16+
17+
var grBr = new GlideRecord('sys_script'); //Business rule
18+
grBr.addActiveQuery();
19+
grBr.query();
20+
while (grBr.next()) {
21+
var scriptContent = grBr.getValue('script');
22+
// Regular expression to check for 'new Array()'
23+
var pattern = /new\s+Array\s*\(/;
24+
if (pattern.test(scriptContent)) {
25+
finding.increment();
26+
}
27+
28+
}
29+
30+
var grCl = new GlideRecord('sys_script_client'); //Client script
31+
grCl.addActiveQuery();
32+
grCl.query();
33+
while (grCl.next()) {
34+
var scriptContent1 = grCl.getValue('script');
35+
// Regular expression to check for 'new Array()'
36+
var pattern1 = /new\s+Array\s*\(/;
37+
if (pattern1.test(scriptContent1)) {
38+
finding.increment();
39+
}
40+
41+
}
42+
43+
var grSi = new GlideRecord('sys_script_include'); //Script Include
44+
grSi.addActiveQuery();
45+
grSi.query();
46+
while (grSi.next()) {
47+
var scriptContent2 = grSi.getValue('script');
48+
// Regular expression to check for 'new Array()'
49+
var pattern2 = /new\s+Array\s*\(/;
50+
if (pattern2.test(scriptContent2)) {
51+
finding.increment();
52+
}
53+
54+
}
55+
56+
57+
58+
})(finding, current);]]></script>
59+
<short_description>Don't use new Array()</short_description>
60+
<sys_class_name>scan_script_only_check</sys_class_name>
61+
<sys_created_by>admin</sys_created_by>
62+
<sys_created_on>2024-10-14 18:14:56</sys_created_on>
63+
<sys_id>7593193c5315521000b51901a0490ec5</sys_id>
64+
<sys_mod_count>2</sys_mod_count>
65+
<sys_name>Don't use new Array()</sys_name>
66+
<sys_package display_value="Example Instance Checks" source="x_appe_exa_checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_package>
67+
<sys_policy/>
68+
<sys_scope display_value="Example Instance Checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_scope>
69+
<sys_update_name>scan_script_only_check_7593193c5315521000b51901a0490ec5</sys_update_name>
70+
<sys_updated_by>admin</sys_updated_by>
71+
<sys_updated_on>2024-10-14 18:18:21</sys_updated_on>
72+
</scan_script_only_check>
73+
<sys_translated_text action="delete_multiple" query="documentkey=7593193c5315521000b51901a0490ec5"/>
74+
<sys_es_latest_script action="INSERT_OR_UPDATE">
75+
<id>7593193c5315521000b51901a0490ec5</id>
76+
<sys_created_by>admin</sys_created_by>
77+
<sys_created_on>2024-10-14 18:14:55</sys_created_on>
78+
<sys_id>86771d305355521000b51901a0490e92</sys_id>
79+
<sys_mod_count>0</sys_mod_count>
80+
<sys_updated_by>admin</sys_updated_by>
81+
<sys_updated_on>2024-10-14 18:14:55</sys_updated_on>
82+
<table>scan_script_only_check</table>
83+
<use_es_latest>true</use_es_latest>
84+
</sys_es_latest_script>
85+
</record_update>

0 commit comments

Comments
 (0)