Check for Orphaned tickets (#130)

* Check for tickets without assignment group

* Update README.md

* Instead of using GlideRecord unnecessarily, made use of the table filters. This has improved the efficiency and optimized the run time as well.

---------

Co-authored-by: admin <[email protected]>
Co-authored-by: niamccash <[email protected]>

Author: 3 people

README.md

@@ -147,8 +147,7 @@ During the time it can be a situation that person is no longer active in the sys
 GlideLDAP API usage is unsupported by ServiceNow and hence should be avoided, rather use LDAP Server Data Sources to pull data from LDAP via MID Server or directly through an internet facing LDAP.
 
 ### Check for Orphaned Tickets
-Tickets from tables such as Incident, Change Request, Problem, and other task-related tables should always have an Assignment Group specified. These tickets represent issues or requests that require attention and action. Leaving the Assignment Group field empty can result in unresolved issues or delays in implementing fixes, as no team will be accountable for the resolution. Since the Assignment Group is meant to designate the responsible team for managing these tickets, it should not be left blank.
-
+Tickets from tables such as Incident, Change Request, Problem, and other task-related tables should always have an Assignment Group specified. These tickets represent issues or requests that require attention and action. Leaving the Assignment Group field empty can result in unresolved issues or delays in implementing fixes, as no team will be accountable for the resolution. Since the Assignment Group is meant to designate the responsible team for managing these tickets, it should never be left blank.
 
 ## Category: Upgradability
 

ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt

@@ -1 +1 @@
-NphMlwVg49IDN_AmbhZA_S2n4C2Ak0kx2FHZhxUGSGGxUbqgZMunGHiqZzRmFpvjBevGWNbaflHkL2XtSDBN4OyJbkF2BqC_swBzwqMIAVV449V_huL8FUWbgEpPvhHD2uyLtmpJR4q4WfEjJzmjWQnXFksmQtAHDFZp7M4XpWRfyFc_r05eE9u10khR0-YcO18-wKcYnWt4sJGYiyZhzioxcrb_D8yHEfrX6CAJUaQUy79-ADc9GNx6LJSw9MdryaoB1idOH2U5-FRpcwwxHmY2AxV7c7DBvuGz7JKQD_KGjoClwWGb64Cm0Nbzh3IHYibnbJ7kabppL5LbMsnlURkBdTF67Mgm-IgasNyunYfcSpdbZSV7_hmB5CjJ0MH2y8HAIr105Y1Tx71M-O4dd_bh7w5xIlslgatPf3fUQ7r85nbd-OUY6Tpw7WJtbk5qTaxPKcWZBdB1OVL__9pYW7_9UxcOdlehuflVEqixu89Jv3IyvP9JT8m-RJqZDU0J61y90w07smRDIv0DDXgNHbfuENQ6Zb48wIEY77h3Jg40h6NqiNEkx_P8RZLC3eC3r4kwFEbdvW-XKmebx5SKiXwfSzqez8v6wYhf5GVI-QmnJEBeus9roO2nh43hEJ-lMuBni_JjjXcENBcwcxj8-oRBWhHrukHwcPU80N7F-mY
+UBvFrDYpp6F473PapuKpJKvmmOUFgHEiVD5h695pnIT46m0IVAx59x1ktpNoZWBTXgM7AdJP1coxhN00Shmw9bNXm_HzYL92UD4dYmuICsujNrQr31qwCPeozLHR3BkzlPvWytL5BfPWcqGU-XSsarhtGPDjxgC2FP4hthcVI3uLDUY6HVQ8NAuLvOL3sEcCUuAMpVy6ZZjVZMVULf47a0Q8uS3aVM-Nn2UB4i5ifDA10sVReTr6N9HxC3A54aCwdMBDEY8krcVl7O_2q2QNS2UPoXc2Os0PxlJCzfBZYgvdq2Wa07TUEPv9hM_Gd-MYKC_9tJpmGuiIwkdUKo1Sdg0zrfTBq5bK03aonAUQ3YohDTcbHXyDJ0vXycn1eb4wgzzgZwlY5yILELwfm3t4_A1KYANrO3IC_ImJNe3nj8GGhuKVhdAVxfbrfjmcredgTeCIY5AyzzhR815b2zX0PPxvYYJOIVTajm6GWIH8yvUwV5q1lSrMYHw4nDIRsDUjH30qpg7EIV4ivBtO-lrCmwbXCsv6wpXJWqbtReK82OCZEWN3ovn1RYThAD55WAJkMt40_D0X7t1afak0eKUDTDK_V8lSQSeZ9d_D6cMtr2QlgZgHxX7jdmkn8KK0f9TCa07z4J5s4TJUFUxkriPZDimd3NcG3gpIJzV3AJOgqeE

ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_7334dda283455210ae0854b6feaad378.xml

@@ -3,7 +3,8 @@
         <active>true</active>
         <advanced>true</advanced>
         <category>manageability</category>
-        <conditions table="incident">active=true^EQ<item endquery="false" field="active" goto="false" newquery="false" operator="=" or="false" value="true"/>
+        <conditions table="incident">active=true^assignment_group=^EQ<item endquery="false" field="active" goto="false" newquery="false" operator="=" or="false" value="true"/>
+            <item endquery="false" field="assignment_group" goto="false" newquery="false" operator="=" or="false" value=""/>
             <item endquery="true" field="" goto="false" newquery="false" operator="=" or="false" value=""/>
         </conditions>
         <description>Tickets from tables such as Incident, Change Request, Problem, and other task-related tables should always have an Assignment Group specified. These tickets represent issues or requests that require attention and action. Leaving the Assignment Group field empty can result in unresolved issues or delays in implementing fixes, as no team will be accountable for the resolution. Since the Assignment Group is meant to designate the responsible team for managing these tickets, it should never be left blank.</description>
@@ -17,27 +18,30 @@
         <score_min>0</score_min>
         <score_scale>1</score_scale>
         <script><![CDATA[(function(finding, current) {
-    var IncID = current.getValue('sys_id');
-    var inc = new GlideRecord('incident');
-    inc.addQuery('sys_id', IncID);
-    inc.addEncodedQuery("assignment_group!=null");
-    if (!inc.hasNext()) {
-        finding.increment();
-    }
+    //var IncID = current.getValue('sys_id');
+    // var inc = new GlideRecord('incident');
+    // inc.addQuery('sys_id', IncID);
+    // inc.addEncodedQuery("assignment_group!=null");
+    // if (!inc.hasNext()) {
+    //     finding.increment();
+    // }
+	//if(current.assignment_group!=null){
+         finding.increment();
+     //}
 })(finding, current);]]></script>
         <short_description>Tickets from Incident table should have assignment group specified.</short_description>
         <sys_class_name>scan_table_check</sys_class_name>
         <sys_created_by>admin</sys_created_by>
         <sys_created_on>2024-10-07 18:22:05</sys_created_on>
         <sys_id>7334dda283455210ae0854b6feaad378</sys_id>
-        <sys_mod_count>9</sys_mod_count>
+        <sys_mod_count>12</sys_mod_count>
         <sys_name>Check for Orphaned tickets</sys_name>
         <sys_package display_value="Example Instance Checks" source="x_appe_exa_checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_package>
         <sys_policy/>
         <sys_scope display_value="Example Instance Checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_scope>
         <sys_update_name>scan_table_check_7334dda283455210ae0854b6feaad378</sys_update_name>
         <sys_updated_by>admin</sys_updated_by>
-        <sys_updated_on>2024-10-07 18:33:38</sys_updated_on>
+        <sys_updated_on>2024-10-09 06:30:13</sys_updated_on>
         <table>incident</table>
         <use_manifest>false</use_manifest>
     </scan_table_check>