From 6d16276fcc97282949fe0ee552857fd473ca81fb Mon Sep 17 00:00:00 2001
From: admin <rampriyabala01@gmail.com>
Date: Mon, 14 Oct 2024 09:31:48 -0700
Subject: [PATCH 1/2] For instance scan for automate testing with ServiceNow's
 Automated Test Framework to ensure functionality after updates and
 deployments.

---
 ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt |  2 +-
 ...check_357638f05391521000b51901a0490e6e.xml | 56 +++++++++++++++++++
 2 files changed, 57 insertions(+), 1 deletion(-)
 create mode 100644 ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_357638f05391521000b51901a0490e6e.xml

diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt b/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt
index 3dc5a7f..e5667f5 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt
@@ -1 +1 @@
-CuNEYHj5RbBsjVJxohTMD1xntLLtuzW06YrIQxv_dnuv66Z-CP9Yyz94aT1y6VMee62ueoZ-zoVm79qzmSN0EDnNTIajGUE-L9E8z-wSmPjpDRK6unp5pT-WyQru961HXU1NDT6tYoVYpmHPnC1pxK1hGqlJ5xCFlFjoYHaWTOMQ-jgr2lppwmOLGMGR7znGbC3ffVubbJzVWxZF2A54U5qoSwKmMb-Sl6nBVJvbZz8finGJvOBn8WzxH6DP_rUNqXJ4ZflVbC2EWzi2mlf_jhEvu35jXElgy6I7myTSoOJvWiK8J6arVkKEt1MNTtewGnDrFnAbFFZ53T08x7UafmirFgZuS4MbzwCYGQ_dX9IlcB-5OLXuB1JYApTLKEJnT364IFKOpAgwzZm5F9dhRAYQG6qVRonDCHrXl1ZJ1WFEMgDCksXtQpTcc53Fe-cH348-sbttOrFExqMtN8HmrJxdjJWFQB0WIPnb7BLMIc6qvc0QIfku9KZpHSlse1cttB-pn_l5UM07YLgjoWCB2wvGaLkZdjDOT0MZizytu7SaAs0SFgm4Q2g4p3xTJ9C78cM24TaT0oQ_gIehRDaf-ETeb4XCdMj1hpaRB4PR2JquoRXJvkfZ7bB6l0ahyfDeQvKqk2cmDf0Mt2CKXeALoAOwe3vhtLMTXKOL1NBAjm4
\ No newline at end of file
+tG-IQ3gIIotqELbKefsjaKLRXAfKT5UCb90GMAzdOGjWm3gW0SvUTgZCObB8HbG38f2ZIz_cGHzE8h1Dbh66hcWYk9onFL6yx5pPy_HaM03tfsR3bmu29LtBhi1Mlb2qAbhfkvO4ZC46mcJZPOxd0reUiW1n5LBiNyM23sGTwxRPuA-ooNcBOztJh_qeMvxknDn-Wm6RYSE1_8w4lwUtYIHInJeIMiyRoQ6D4F3pxo0xaXHl0LlOvFobeMC5LOlLL0dv4nck-oaNAvFiaOG1FvI-7ygRnMoaJHsnTeFhPcb097zMZaPlIAQqjF1L8Mdy7O90zW8eUAkdCvnDurh5aHeutoBb3jdPXC-nO628hbqe-N1KQV-pnFKBOrMaVdI3jTrJlc82fN6lNWtJiwIhcbZZ6SREA32cQvbZMdByYjdBEGFGo94JIR6rzuEsMfz-7ppaumipljUD60K3dg9yA1bAqJd--C1cqwrFursf_XaiGNxQ0LFwKjNKH-lJbSZ5mSffVV57477EX2XV3HEqx47EL5rmtZnG52C_E63ky0clzZLO_00Tl34mE04i_1YqUBXsqry27Ub4o0UksPESR1xjq5mjEKs1dOmpPE0KgBMhWhlNTamVrIdB5h7Z95cgx6n1O19jPnhRjg_lkYgvh_yV-x2uimlO5Hl7Gw6e08g
\ No newline at end of file
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_357638f05391521000b51901a0490e6e.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_357638f05391521000b51901a0490e6e.xml
new file mode 100644
index 0000000..763bc98
--- /dev/null
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_357638f05391521000b51901a0490e6e.xml
@@ -0,0 +1,56 @@
+<?xml version="1.0" encoding="UTF-8"?><record_update table="scan_table_check">
+    <scan_table_check action="INSERT_OR_UPDATE">
+        <active>true</active>
+        <advanced>true</advanced>
+        <category>upgradability</category>
+        <conditions table="sys_properties">name=sn_atf.runner.enabled^value=false^EQ<item endquery="false" field="name" goto="false" newquery="false" operator="=" or="false" value="sn_atf.runner.enabled"/>
+            <item endquery="false" field="value" goto="false" newquery="false" operator="=" or="false" value="false"/>
+            <item endquery="true" field="" goto="false" newquery="false" operator="=" or="false" value=""/>
+        </conditions>
+        <description>Automate your testing with ServiceNow's Automated Test Framework to ensure functionality after updates and deployments.</description>
+        <documentation_url/>
+        <finding_type>scan_finding</finding_type>
+        <name>Encourage ATFs</name>
+        <priority>2</priority>
+        <resolution_details>https://docs.servicenow.com/bundle/xanadu-application-development/page/administer/auto-test-framework/task/atf-enable-tests.html&#13;
+&#13;
+https://www.servicenow.com/community/developer-forum/how-to-get-type-of-instance-via-script/m-p/2029442</resolution_details>
+        <run_condition/>
+        <score_max>100</score_max>
+        <score_min>0</score_min>
+        <score_scale>1</score_scale>
+        <script><![CDATA[(function (finding, current) {
+     // Checks if we are in a non-production instance
+	if (gs.getProperty("glide.installation.production") === "false")
+		finding.increment();
+	
+})(finding, current);]]></script>
+        <short_description>Validate ATFs are enabled in sub production instances</short_description>
+        <sys_class_name>scan_table_check</sys_class_name>
+        <sys_created_by>admin</sys_created_by>
+        <sys_created_on>2024-10-14 16:09:20</sys_created_on>
+        <sys_id>357638f05391521000b51901a0490e6e</sys_id>
+        <sys_mod_count>4</sys_mod_count>
+        <sys_name>Encourage ATFs</sys_name>
+        <sys_package display_value="Example Instance Checks" source="x_appe_exa_checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_package>
+        <sys_policy/>
+        <sys_scope display_value="Example Instance Checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_scope>
+        <sys_update_name>scan_table_check_357638f05391521000b51901a0490e6e</sys_update_name>
+        <sys_updated_by>admin</sys_updated_by>
+        <sys_updated_on>2024-10-14 16:26:20</sys_updated_on>
+        <table>sys_properties</table>
+        <use_manifest>false</use_manifest>
+    </scan_table_check>
+    <sys_translated_text action="delete_multiple" query="documentkey=357638f05391521000b51901a0490e6e"/>
+    <sys_es_latest_script action="INSERT_OR_UPDATE">
+        <id>357638f05391521000b51901a0490e6e</id>
+        <sys_created_by>admin</sys_created_by>
+        <sys_created_on>2024-10-14 16:09:19</sys_created_on>
+        <sys_id>96baf8785391521000b51901a0490e96</sys_id>
+        <sys_mod_count>0</sys_mod_count>
+        <sys_updated_by>admin</sys_updated_by>
+        <sys_updated_on>2024-10-14 16:09:19</sys_updated_on>
+        <table>scan_table_check</table>
+        <use_es_latest>true</use_es_latest>
+    </sys_es_latest_script>
+</record_update>

From 5da23d96a1faa6005ee7fe028251e480af7d76c8 Mon Sep 17 00:00:00 2001
From: admin <rampriyabala01@gmail.com>
Date: Mon, 14 Oct 2024 10:38:03 -0700
Subject: [PATCH 2/2] Always avoid using native js "document" object for DOM
 manipulation in service portal. Instead we should use AngularJS equivalent
 capabilities to achieve the same.

---
 ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt |  2 +-
 ...check_e65c4d305315521000b51901a0490e38.xml | 57 +++++++++++++++++++
 2 files changed, 58 insertions(+), 1 deletion(-)
 create mode 100644 ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_e65c4d305315521000b51901a0490e38.xml

diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt b/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt
index e5667f5..d368d5b 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt
@@ -1 +1 @@
-tG-IQ3gIIotqELbKefsjaKLRXAfKT5UCb90GMAzdOGjWm3gW0SvUTgZCObB8HbG38f2ZIz_cGHzE8h1Dbh66hcWYk9onFL6yx5pPy_HaM03tfsR3bmu29LtBhi1Mlb2qAbhfkvO4ZC46mcJZPOxd0reUiW1n5LBiNyM23sGTwxRPuA-ooNcBOztJh_qeMvxknDn-Wm6RYSE1_8w4lwUtYIHInJeIMiyRoQ6D4F3pxo0xaXHl0LlOvFobeMC5LOlLL0dv4nck-oaNAvFiaOG1FvI-7ygRnMoaJHsnTeFhPcb097zMZaPlIAQqjF1L8Mdy7O90zW8eUAkdCvnDurh5aHeutoBb3jdPXC-nO628hbqe-N1KQV-pnFKBOrMaVdI3jTrJlc82fN6lNWtJiwIhcbZZ6SREA32cQvbZMdByYjdBEGFGo94JIR6rzuEsMfz-7ppaumipljUD60K3dg9yA1bAqJd--C1cqwrFursf_XaiGNxQ0LFwKjNKH-lJbSZ5mSffVV57477EX2XV3HEqx47EL5rmtZnG52C_E63ky0clzZLO_00Tl34mE04i_1YqUBXsqry27Ub4o0UksPESR1xjq5mjEKs1dOmpPE0KgBMhWhlNTamVrIdB5h7Z95cgx6n1O19jPnhRjg_lkYgvh_yV-x2uimlO5Hl7Gw6e08g
\ No newline at end of file
+i_BjMOi9sxzRAYEoKQTyqmvU0fzO1wvs16ONlSntq91XLDlYsoVVgLGnL_Pql8lXuhENdj6DQbjG8yBXFzaTNNrjSRo1tvTlKMSREQmPVQNfj2STT1IXYIehedgFy5Al1Av4anp18YO3u56S4GkD2V8yA-d8IgRwhmFuLB_bZmx2TEBUSQxXqKSsZhbe6oWn3wVb1L47k9RHwqyLIt9WphsEhP52Gey49IUC-I5iDm1Ko93syfvhdFL0FX2el5zCW3g31CG85wenOJYEsUCKZ109XJJWa_3JsYZQTlBlDzxQ2Bq8-DWpgydmWDhRBvHPURa4tlWEBRZuXC0HIQWvAX_gvueBdVRl8XRhnkE7tL-tnE-jGSf6SHQi73eBfj5oit8baCPzaVEYvVpxBl_AN5rRWxqXFxZv8XjJqgWDG-gO_dFntKZPDNvs3ikqemCuEeYEYzf8IMuj06xbumTB6DdxwY-dOHVuTQ5UZ5g2BKLTUfRBzqxFd5e655-CaL8RP1D9OXHjPn-aY6TNd-c4Rx_j36j3zJovj0svg8g-2i3WgnTCntlAsNrXRDtqRvl-a6-2RgEhQ1ug98qMHkEpRHhUwiAIA3-YEIpaxJt6i6qBwlpompDad8rAmltd_bP_W-xd6Ipzs-whgMH5KQZuCABwsqnsUQTN_gZ3rrbDvLg
\ No newline at end of file
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_e65c4d305315521000b51901a0490e38.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_e65c4d305315521000b51901a0490e38.xml
new file mode 100644
index 0000000..6d7564d
--- /dev/null
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_e65c4d305315521000b51901a0490e38.xml
@@ -0,0 +1,57 @@
+<?xml version="1.0" encoding="UTF-8"?><record_update table="scan_table_check">
+    <scan_table_check action="INSERT_OR_UPDATE">
+        <active>true</active>
+        <advanced>true</advanced>
+        <category>manageability</category>
+        <conditions/>
+        <description>Always avoid using native js "document" object for DOM manipulation in service portal. Instead we should use AngularJS equivalent capabilities to achieve the same.</description>
+        <documentation_url/>
+        <finding_type>scan_finding</finding_type>
+        <name>Avoid using javascript "document" object in Portal</name>
+        <priority>1</priority>
+        <resolution_details/>
+        <run_condition/>
+        <score_max>100</score_max>
+        <score_min>0</score_min>
+        <score_scale>1</score_scale>
+        <script><![CDATA[(function (finding, current) {
+	var regex = /gel\s*\(|[\s\w\d]document\.[a-zA-Z]+|\.onchange\s*\(|\.onclick\s*\(|\$.+?\s*\(|Event\.|jQuery\s*\(/g;
+
+	var scriptValue = current.getValue("client_script") || "";
+	var matches = scriptValue.match(regex);
+
+	if (matches) {
+		matches.forEach(function(match) {
+			finding.increment();
+		});
+	}
+})(finding, current);]]></script>
+        <short_description>Avoid using javascript "document" object in Portal</short_description>
+        <sys_class_name>scan_table_check</sys_class_name>
+        <sys_created_by>admin</sys_created_by>
+        <sys_created_on>2024-10-14 17:36:18</sys_created_on>
+        <sys_id>e65c4d305315521000b51901a0490e38</sys_id>
+        <sys_mod_count>0</sys_mod_count>
+        <sys_name>Avoid using javascript "document" object in Portal</sys_name>
+        <sys_package display_value="Example Instance Checks" source="x_appe_exa_checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_package>
+        <sys_policy/>
+        <sys_scope display_value="Example Instance Checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_scope>
+        <sys_update_name>scan_table_check_e65c4d305315521000b51901a0490e38</sys_update_name>
+        <sys_updated_by>admin</sys_updated_by>
+        <sys_updated_on>2024-10-14 17:36:18</sys_updated_on>
+        <table>sp_widget</table>
+        <use_manifest>false</use_manifest>
+    </scan_table_check>
+    <sys_translated_text action="delete_multiple" query="documentkey=e65c4d305315521000b51901a0490e38"/>
+    <sys_es_latest_script action="INSERT_OR_UPDATE">
+        <id>e65c4d305315521000b51901a0490e38</id>
+        <sys_created_by>admin</sys_created_by>
+        <sys_created_on>2024-10-14 17:36:18</sys_created_on>
+        <sys_id>54ae89b05315521000b51901a0490e99</sys_id>
+        <sys_mod_count>0</sys_mod_count>
+        <sys_updated_by>admin</sys_updated_by>
+        <sys_updated_on>2024-10-14 17:36:18</sys_updated_on>
+        <table>scan_table_check</table>
+        <use_es_latest>true</use_es_latest>
+    </sys_es_latest_script>
+</record_update>