From 37a0727ee0e7e9e21cbded23c3b0cf55a6a8dbe1 Mon Sep 17 00:00:00 2001
From: admin <rampriyabala01@gmail.com>
Date: Wed, 16 Oct 2024 07:20:48 -0700
Subject: [PATCH 1/3] Highly recommended practice to use ATFs for regression
 testing  on instance upgrade and releases.

---
 ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt |  2 +-
 ...check_6f14fe555359161000b51901a0490ef9.xml | 54 +++++++++++++++++++
 2 files changed, 55 insertions(+), 1 deletion(-)
 create mode 100644 ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_6f14fe555359161000b51901a0490ef9.xml

diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt b/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt
index b764fd1..a5813a2 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt
@@ -1 +1 @@
-vdzK57T2bhYH4R3tr5_N6r8DKdLmhtc5_AMSqsrGL2lDDQtzZxnmirx38up8Jm2-CI3CDMpa7Udq0cV06a0WfIeCBFsws8y-joYHTxiD-lAbbpy7LKyBy-szR_kO4mFszdz7Kikp9bbMUwWTIPbtRQzbapfu6HH7iEFepuUdA9SOlwPJAAaBRxCUQeo8Hg9Hxb7ubHmvx87l7IwoGN2ezq07g2EMDh3wkpLdXVXdMoPd-Hf9g8X-V4ENLaGI-5wQnvXgX_w_shWoupz_WdTA3ir94Eh3Nu2jiM29wNQDNrlsTvslryId4vq8M8ME13Vi7UpuHw6Ec-ooT6OXdBMkvgsVAtCARdy79UbAgT_p9E3KL3rbJPozp-7I8wOf3n1WETwJkDsAUMzBp3LWF8_BqfxFeYFCEQV3l3xC8ic2ZQn_98i9fpgURFU9Ec2BEGbbMfpm7KehrFl0bNOVDTDEWIETdt80lvfR1i0-8Yk1vHWvLdB94dHoPw1a77oWht1HxEMkNzE1m38ANVQVZq2-pbVdIiAYCLeRBdd5i_LrNLpF7iCHBpAawuxX5BQIVKBW3WNTPhWUdV9_a1_394CDBmYswn8XiQSx0Vi0hfjuuMp9J9sQxOVVq2MFyWZiDvhIX2CJutq8xn27shQc7Y5xeZN5SVosFrv3irWYkzJuKoU
\ No newline at end of file
+2GmWsJ-o1b3QV3-6URGiSXSMI8C_MGtuzUzllO-E25BLlW8xY3T33MhCEIjrlR3Iagmuub4YikspwkRRYc_er66_c1onVimbRiN2socYSYWwCzxsJwJ_42oE5oqKePrOLryz7_pU_jzxOYRNa0xBvwEidli_M_kIXOSrwXflcA6Y_bMzciNW2YcnLDxK96tAoSooIaBQEw4x7xKxIIE-ejLeYlU6l11ELhmCn_wOXE-PnAkBU643SDLxBxPp8qsDW791X4ZPOM5_iL6U7Bdtrvb6Kn6mcHZNPFLJC8q7IrJ0wv19MuJlQp-Zi0BH9dg-oN6s5cIKOHYFiINFgINPK2wNocUSVJERDkqoHZOCq0T69m0FxKrEh3B4zujM0zgqx0uXCHVDK08hAyEGISYo7xFU6rUBZhBzLtaVLNHmOOlXlka3h9t8B9mEjYaBcInBbwzMwSgmTIYtN_GuwVekOY-L8R6Iz8ni3sNTd7s36vHxzmSKy0KHMRmzLCS7x8ig1LROAn2UWlX_yrv7AUtwSi1ENYOxw7ayF6mCwxU37FECms1bZVOJWpnfZtQH86cSsZc0FNGyswWUFJRi-XIS0fQA-zl7NVpElIJBONXSK_16Y3uTMx-nr3M5zOiQK5VBUN5SsAGfDucfu-VVwM9-O5HUSs_LGuA9J1Pt4xqKj-8
\ No newline at end of file
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_6f14fe555359161000b51901a0490ef9.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_6f14fe555359161000b51901a0490ef9.xml
new file mode 100644
index 0000000..9a7db28
--- /dev/null
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_6f14fe555359161000b51901a0490ef9.xml
@@ -0,0 +1,54 @@
+<?xml version="1.0" encoding="UTF-8"?><record_update table="scan_table_check">
+    <scan_table_check action="INSERT_OR_UPDATE">
+        <active>true</active>
+        <advanced>true</advanced>
+        <category>manageability</category>
+        <conditions table="sys_properties">name=sn_atf.runner^value=false^EQ<item endquery="false" field="name" goto="false" newquery="false" operator="=" or="false" value="sn_atf.runner"/>
+            <item endquery="false" field="value" goto="false" newquery="false" operator="=" or="false" value="false"/>
+            <item endquery="true" field="" goto="false" newquery="false" operator="=" or="false" value=""/>
+        </conditions>
+        <description/>
+        <documentation_url/>
+        <finding_type>scan_finding</finding_type>
+        <name>ATF usage instance</name>
+        <priority>2</priority>
+        <resolution_details/>
+        <run_condition/>
+        <score_max>100</score_max>
+        <score_min>0</score_min>
+        <score_scale>1</score_scale>
+        <script><![CDATA[(function (finding, current) {
+     // Checks if we are in a non-production instance
+	if (gs.getProperty("glide.installation.production") === "false")
+		finding.increment();
+	
+})(finding, current);]]></script>
+        <short_description>Checking ATFs are using in  Non production instances.</short_description>
+        <sys_class_name>scan_table_check</sys_class_name>
+        <sys_created_by>admin</sys_created_by>
+        <sys_created_on>2024-10-16 14:19:07</sys_created_on>
+        <sys_id>6f14fe555359161000b51901a0490ef9</sys_id>
+        <sys_mod_count>0</sys_mod_count>
+        <sys_name>ATF usage instance</sys_name>
+        <sys_package display_value="Example Instance Checks" source="x_appe_exa_checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_package>
+        <sys_policy/>
+        <sys_scope display_value="Example Instance Checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_scope>
+        <sys_update_name>scan_table_check_6f14fe555359161000b51901a0490ef9</sys_update_name>
+        <sys_updated_by>admin</sys_updated_by>
+        <sys_updated_on>2024-10-16 14:19:07</sys_updated_on>
+        <table>sys_properties</table>
+        <use_manifest>false</use_manifest>
+    </scan_table_check>
+    <sys_translated_text action="delete_multiple" query="documentkey=6f14fe555359161000b51901a0490ef9"/>
+    <sys_es_latest_script action="INSERT_OR_UPDATE">
+        <id>6f14fe555359161000b51901a0490ef9</id>
+        <sys_created_by>admin</sys_created_by>
+        <sys_created_on>2024-10-16 14:19:06</sys_created_on>
+        <sys_id>57a4ba915359161000b51901a0490e13</sys_id>
+        <sys_mod_count>0</sys_mod_count>
+        <sys_updated_by>admin</sys_updated_by>
+        <sys_updated_on>2024-10-16 14:19:06</sys_updated_on>
+        <table>scan_table_check</table>
+        <use_es_latest>true</use_es_latest>
+    </sys_es_latest_script>
+</record_update>

From 3fdd9ab8baadc275ef192443b53f98794e51426b Mon Sep 17 00:00:00 2001
From: admin <rampriyabala01@gmail.com>
Date: Thu, 17 Oct 2024 19:30:56 -0700
Subject: [PATCH 2/3] =?UTF-8?q?Use=20Logging=20Levels:=20Instead=20of=20gs?=
 =?UTF-8?q?.log(),=20consider=20using=20more=20appropriate=20logging=20lev?=
 =?UTF-8?q?els,=20such=20as:=20gs.info()=20for=20informational=20messages.?=
 =?UTF-8?q?=20gs.warn()=20for=20warnings=20that=20don=E2=80=99t=20break=20?=
 =?UTF-8?q?functionality=20but=20may=20need=20attention.=20gs.error()=20fo?=
 =?UTF-8?q?r=20logging=20errors=20that=20require=20investigation.?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt |  2 +-
 ...check_6b832a7953d1d61000b51901a0490e24.xml | 53 +++++++++++++++++++
 2 files changed, 54 insertions(+), 1 deletion(-)
 create mode 100644 ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_script_only_check_6b832a7953d1d61000b51901a0490e24.xml

diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt b/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt
index a5813a2..a747ec2 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt
@@ -1 +1 @@
-2GmWsJ-o1b3QV3-6URGiSXSMI8C_MGtuzUzllO-E25BLlW8xY3T33MhCEIjrlR3Iagmuub4YikspwkRRYc_er66_c1onVimbRiN2socYSYWwCzxsJwJ_42oE5oqKePrOLryz7_pU_jzxOYRNa0xBvwEidli_M_kIXOSrwXflcA6Y_bMzciNW2YcnLDxK96tAoSooIaBQEw4x7xKxIIE-ejLeYlU6l11ELhmCn_wOXE-PnAkBU643SDLxBxPp8qsDW791X4ZPOM5_iL6U7Bdtrvb6Kn6mcHZNPFLJC8q7IrJ0wv19MuJlQp-Zi0BH9dg-oN6s5cIKOHYFiINFgINPK2wNocUSVJERDkqoHZOCq0T69m0FxKrEh3B4zujM0zgqx0uXCHVDK08hAyEGISYo7xFU6rUBZhBzLtaVLNHmOOlXlka3h9t8B9mEjYaBcInBbwzMwSgmTIYtN_GuwVekOY-L8R6Iz8ni3sNTd7s36vHxzmSKy0KHMRmzLCS7x8ig1LROAn2UWlX_yrv7AUtwSi1ENYOxw7ayF6mCwxU37FECms1bZVOJWpnfZtQH86cSsZc0FNGyswWUFJRi-XIS0fQA-zl7NVpElIJBONXSK_16Y3uTMx-nr3M5zOiQK5VBUN5SsAGfDucfu-VVwM9-O5HUSs_LGuA9J1Pt4xqKj-8
\ No newline at end of file
+FFSb285LVQLVwwSy1sN9TSS_xgKMdxMueRetT0HDGeIrQsCSVVqvJzq4M3L_pFYItVzRNDhnJyUVmYX7kiDXTToGUlLA1bTP6qfEDtDOKAjH87dpFAYY0oCn-BigJNe6f5mwNAGVBXr3LuZsGmtUK_ximdlxUEYd2DZxoRROrqzIDgwXIAvh0-j8KEYoBGFnBral4LH5FhuzlJImUAh098OvSvclL5NbEYBf4VBqcQZvIP0u2vboUXo2rJ16Kn3iNtzuxPYimD5mfRTRkV7zFDIUxiwGXxf7ncKbO3VZh7DcKeHkGN1Y1RSR1Q_3KyIwoW0YLyKn22G80MIiVx__BKyrof0MY632nGIwHhAstzV83wEoStOilvUdjSJKPNxx9aAft3baZjboj6P8La47D0rfw5lgqOIHq1TnThxjiAlBctfD78qPrva7lfQmipEPZuFHfrKqJ32T_MbAug2xxmt22tnbKCDBDfw8MUc5v3nprsHYFFewiMuZflFHhISDzjSPs2TIy60TrSISouTfVY-p4IgG_v-eSXage9wzpvjoHQZnMwvZrePEtW62OkG8TmD86uZtWTHlPYo2Prj1OGaXZRGHvd3K4bbdtwOWKq9exXozy83yl_w_U3ich8kLj1LuppKxCmMQVEnPvUSdxqwtkqGidBLqZKTcVLCFqJc
\ No newline at end of file
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_script_only_check_6b832a7953d1d61000b51901a0490e24.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_script_only_check_6b832a7953d1d61000b51901a0490e24.xml
new file mode 100644
index 0000000..57ea32e
--- /dev/null
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_script_only_check_6b832a7953d1d61000b51901a0490e24.xml
@@ -0,0 +1,53 @@
+<?xml version="1.0" encoding="UTF-8"?><record_update table="scan_script_only_check">
+    <scan_script_only_check action="INSERT_OR_UPDATE">
+        <active>true</active>
+        <category>upgradability</category>
+        <description>Use Logging Levels: Instead of gs.log(), consider using more appropriate logging levels, such as:&#13;
+gs.info() for informational messages.&#13;
+gs.warn() for warnings that don’t break functionality but may need attention.&#13;
+gs.error() for logging errors that require investigation.</description>
+        <documentation_url/>
+        <finding_type>scan_finding</finding_type>
+        <name>Avoid usage of  gs.log()</name>
+        <priority>3</priority>
+        <resolution_details/>
+        <run_condition/>
+        <score_max>100</score_max>
+        <score_min>0</score_min>
+        <score_scale>1</score_scale>
+        <script><![CDATA[(function (finding, columnValue) {
+	var matches = columnValue.match(/gs\.log\s*\(/g);
+
+	if (matches) {
+            matches.forEach(function(element) {
+                    finding.increment();
+            });
+	}
+})(finding, columnValue);]]></script>
+        <short_description>Avoid usage of  gs.log() in prod</short_description>
+        <sys_class_name>scan_script_only_check</sys_class_name>
+        <sys_created_by>admin</sys_created_by>
+        <sys_created_on>2024-10-18 02:30:31</sys_created_on>
+        <sys_id>6b832a7953d1d61000b51901a0490e24</sys_id>
+        <sys_mod_count>0</sys_mod_count>
+        <sys_name>Avoid usage of  gs.log()</sys_name>
+        <sys_package display_value="Example Instance Checks" source="x_appe_exa_checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_package>
+        <sys_policy/>
+        <sys_scope display_value="Example Instance Checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_scope>
+        <sys_update_name>scan_script_only_check_6b832a7953d1d61000b51901a0490e24</sys_update_name>
+        <sys_updated_by>admin</sys_updated_by>
+        <sys_updated_on>2024-10-18 02:30:31</sys_updated_on>
+    </scan_script_only_check>
+    <sys_translated_text action="delete_multiple" query="documentkey=6b832a7953d1d61000b51901a0490e24"/>
+    <sys_es_latest_script action="INSERT_OR_UPDATE">
+        <id>6b832a7953d1d61000b51901a0490e24</id>
+        <sys_created_by>admin</sys_created_by>
+        <sys_created_on>2024-10-18 02:30:31</sys_created_on>
+        <sys_id>07a5a23953d1d61000b51901a0490e95</sys_id>
+        <sys_mod_count>0</sys_mod_count>
+        <sys_updated_by>admin</sys_updated_by>
+        <sys_updated_on>2024-10-18 02:30:31</sys_updated_on>
+        <table>scan_script_only_check</table>
+        <use_es_latest>true</use_es_latest>
+    </sys_es_latest_script>
+</record_update>

From c5d0f6c8d1640eb6ce5a9037ca915dbde9374343 Mon Sep 17 00:00:00 2001
From: admin <rampriyabala01@gmail.com>
Date: Sun, 20 Oct 2024 10:30:53 -0700
Subject: [PATCH 3/3] We should ensure that inactive users are removed from
 being assigned as Catalog item owners.

---
 ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt |  2 +-
 ...check_25a5c4b65311121000b51901a0490e4f.xml | 41 +++++++++++++++++++
 2 files changed, 42 insertions(+), 1 deletion(-)
 create mode 100644 ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_25a5c4b65311121000b51901a0490e4f.xml

diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt b/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt
index a747ec2..7f8541f 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt
@@ -1 +1 @@
-FFSb285LVQLVwwSy1sN9TSS_xgKMdxMueRetT0HDGeIrQsCSVVqvJzq4M3L_pFYItVzRNDhnJyUVmYX7kiDXTToGUlLA1bTP6qfEDtDOKAjH87dpFAYY0oCn-BigJNe6f5mwNAGVBXr3LuZsGmtUK_ximdlxUEYd2DZxoRROrqzIDgwXIAvh0-j8KEYoBGFnBral4LH5FhuzlJImUAh098OvSvclL5NbEYBf4VBqcQZvIP0u2vboUXo2rJ16Kn3iNtzuxPYimD5mfRTRkV7zFDIUxiwGXxf7ncKbO3VZh7DcKeHkGN1Y1RSR1Q_3KyIwoW0YLyKn22G80MIiVx__BKyrof0MY632nGIwHhAstzV83wEoStOilvUdjSJKPNxx9aAft3baZjboj6P8La47D0rfw5lgqOIHq1TnThxjiAlBctfD78qPrva7lfQmipEPZuFHfrKqJ32T_MbAug2xxmt22tnbKCDBDfw8MUc5v3nprsHYFFewiMuZflFHhISDzjSPs2TIy60TrSISouTfVY-p4IgG_v-eSXage9wzpvjoHQZnMwvZrePEtW62OkG8TmD86uZtWTHlPYo2Prj1OGaXZRGHvd3K4bbdtwOWKq9exXozy83yl_w_U3ich8kLj1LuppKxCmMQVEnPvUSdxqwtkqGidBLqZKTcVLCFqJc
\ No newline at end of file
+dhVh82oanv3yRYvJIkdBm3V7WLPR9gULJ6St-2eVRBgP0U5oc_L5OgQ7Fk6yuLs9Q41xu9Z9iFTsIQ9l_u-_mSgfaFnWIiMpSVCiGXzBbbp27mCQGsMya-8yLvEBpAe0KQSk4kLPXq3hXIETHxU00FBpPAfUjYsoBEL-cF3FEp7_I_jZ844YchNvVieHuEw9UaJNqqymHps6RYJvXxQcCz0K0haVjOmbd_Pr3Og9OEhdspup1rOuoNln5JZ68d2UgBILq8N2dtnulLVT0w-iAPEgg5ReN0cxR6gImXAsWTYZruU5kjqPPiWRv_RwJfEkI-GCL8SinkoKF9HfCFYR9x0iiyIAqJhRiiFNYhCahVJe-oLippNrEzHBdRGRvy8BcmbLFTMwjw47z58msYF-8v4BhO2cgFt-k1z9a8FbGICewW8f4ToNQ8Meib0Xe94gb126urLKk0xbyGJZsdE2BZSSSk_3MGWH6AfSmaFe8T0VKwqFoeQtyXwVt0vhJ-tI7T1VGLRkUcEkaHdfPTZXoyr0biqwTzY3rHh61j9u-pLn6jrgAl29aQ9tWpcBh8wTvb0oWz2PZEeS7baITO7U44bztJ8Obv6L_I-kekvESiP_AWYl9W8dpXTD_Hi39YIPqCyYOidTvDW9GG-3ROKg97vo0CIFhJR4zFpycPV_kAg
\ No newline at end of file
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_25a5c4b65311121000b51901a0490e4f.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_25a5c4b65311121000b51901a0490e4f.xml
new file mode 100644
index 0000000..70ae33e
--- /dev/null
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_25a5c4b65311121000b51901a0490e4f.xml
@@ -0,0 +1,41 @@
+<?xml version="1.0" encoding="UTF-8"?><record_update table="scan_table_check">
+    <scan_table_check action="INSERT_OR_UPDATE">
+        <active>true</active>
+        <advanced>false</advanced>
+        <category>upgradability</category>
+        <conditions table="sc_cat_item">owner.active=false^EQ<item endquery="false" field="owner.active" goto="false" newquery="false" operator="=" or="false" value="false"/>
+            <item endquery="true" field="" goto="false" newquery="false" operator="=" or="false" value=""/>
+        </conditions>
+        <description>We should ensure that inactive users are removed from being assigned as Catalog item owners.</description>
+        <documentation_url/>
+        <finding_type>scan_finding</finding_type>
+        <name>Inactive User Check : Catalog Iem</name>
+        <priority>2</priority>
+        <resolution_details/>
+        <run_condition/>
+        <score_max>100</score_max>
+        <score_min>0</score_min>
+        <score_scale>1</score_scale>
+        <script><![CDATA[(function (engine) {
+
+    // Add your code here
+
+})(engine);]]></script>
+        <short_description>Check Catalog Item owner is Active user</short_description>
+        <sys_class_name>scan_table_check</sys_class_name>
+        <sys_created_by>admin</sys_created_by>
+        <sys_created_on>2024-10-20 17:30:07</sys_created_on>
+        <sys_id>25a5c4b65311121000b51901a0490e4f</sys_id>
+        <sys_mod_count>0</sys_mod_count>
+        <sys_name>Inactive User Check : Catalog Iem</sys_name>
+        <sys_package display_value="Example Instance Checks" source="x_appe_exa_checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_package>
+        <sys_policy/>
+        <sys_scope display_value="Example Instance Checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_scope>
+        <sys_update_name>scan_table_check_25a5c4b65311121000b51901a0490e4f</sys_update_name>
+        <sys_updated_by>admin</sys_updated_by>
+        <sys_updated_on>2024-10-20 17:30:07</sys_updated_on>
+        <table>sc_cat_item</table>
+        <use_manifest>false</use_manifest>
+    </scan_table_check>
+    <sys_translated_text action="delete_multiple" query="documentkey=25a5c4b65311121000b51901a0490e4f"/>
+</record_update>