diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/author_elective_update/scan_linter_check_c2db61672f561110a1803e0ef699b64b.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/author_elective_update/scan_linter_check_c2db61672f561110a1803e0ef699b64b.xml
index d16baa9..2e34d76 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/author_elective_update/scan_linter_check_c2db61672f561110a1803e0ef699b64b.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/author_elective_update/scan_linter_check_c2db61672f561110a1803e0ef699b64b.xml
@@ -89,7 +89,7 @@
a33d22c047397110243ff19f016d43fasys_upgrade_history
- current
+ previousadmin2023-10-05 20:43:22184d62c047397110243ff19f016d43a4
@@ -102,7 +102,7 @@
d44d62c0e739711006b12536250952a4:-1288508107
- 4976874c47797110243ff19f016d43ef
+ 4976874c47797110243ff19f016d43efsys_metadata_deletesmartcarleen2023-10-05 22:33:28
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/author_elective_update/scan_table_check_0306196a07221110e765f9fc7c1ed07b.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/author_elective_update/scan_table_check_0306196a07221110e765f9fc7c1ed07b.xml
index bb904e5..c1f2c79 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/author_elective_update/scan_table_check_0306196a07221110e765f9fc7c1ed07b.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/author_elective_update/scan_table_check_0306196a07221110e765f9fc7c1ed07b.xml
@@ -67,13 +67,14 @@
169615aaf122111071af545cbffcdb5e:1517693554
- 0ac7ddaa07221110e765f9fc7c1ed09b
+ 0ac7ddaa07221110e765f9fc7c1ed09bsys_metadata_deleteadmin2022-10-17 23:19:31scan_table_check17859954039f4abebc7d0e2289a8edc40306196a07221110e765f9fc7c1ed07b
+ 0User Roles from Deleted Usersca8467c41b9abc10ce0f62c3b24bcbaa
@@ -82,5 +83,7 @@
30a78b9b9290467a96959a65d2b2d304scan_table_check_0306196a07221110e765f9fc7c1ed07bda9615aa07221110e765f9fc7c1ed05e
+ admin
+ 2024-10-30 10:37:25
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/author_elective_update/scan_table_check_d44f0a4097b29510dd0178300153af7e.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/author_elective_update/scan_table_check_d44f0a4097b29510dd0178300153af7e.xml
index e9541ec..a0a0f9c 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/author_elective_update/scan_table_check_d44f0a4097b29510dd0178300153af7e.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/author_elective_update/scan_table_check_d44f0a4097b29510dd0178300153af7e.xml
@@ -91,7 +91,7 @@
a33d22c047397110243ff19f016d43fasys_upgrade_history
- current
+ previousadmin2023-10-05 20:43:24f04da2c047397110243ff19f016d43e2
@@ -104,7 +104,7 @@
b04da2c075397110e824409ae7478ee2:-932205653
- 0176830047b97110243ff19f016d43e4
+ 0176830047b97110243ff19f016d43e4sys_metadata_deletesmartcarleen2023-10-05 22:33:28
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/author_elective_update/scan_table_check_e660164097b29510dd0178300153af2e.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/author_elective_update/scan_table_check_e660164097b29510dd0178300153af2e.xml
index 2c73f4c..4e885e8 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/author_elective_update/scan_table_check_e660164097b29510dd0178300153af2e.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/author_elective_update/scan_table_check_e660164097b29510dd0178300153af2e.xml
@@ -91,7 +91,7 @@
a33d22c047397110243ff19f016d43fasys_upgrade_history
- current
+ previousadmin2023-10-05 20:43:24784da2c047397110243ff19f016d43e8
@@ -104,7 +104,7 @@
384da2c05a397110be15161e1fd2b8e8:-1513497005
- 4976830047b97110243ff19f016d43ea
+ 4976830047b97110243ff19f016d43easys_metadata_deletesmartcarleen2023-10-05 22:33:28
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/author_elective_update/scan_table_check_eb21adf797697110710650081153af9c.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/author_elective_update/scan_table_check_eb21adf797697110710650081153af9c.xml
index 1c863c5..20dfdf3 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/author_elective_update/scan_table_check_eb21adf797697110710650081153af9c.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/author_elective_update/scan_table_check_eb21adf797697110710650081153af9c.xml
@@ -104,7 +104,7 @@
2f87514b95dd1250d8d7157d4a5955fd:0,e267d9c752dd1250e0ae7bf3aa17e665:-2023533997,eea83dedc1c5de50dcb00ddc90e599ae:1356454248
- 1379110bc3dd1250faa4bd33e4013183
+ 1379110bc3dd1250faa4bd33e4013183sys_metadata_deleteadmin2024-10-21 18:10:05
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/author_elective_update/scan_table_check_fbdce17f2fb2fc505dcb59ab2799b6d0.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/author_elective_update/scan_table_check_fbdce17f2fb2fc505dcb59ab2799b6d0.xml
deleted file mode 100644
index cc047c8..0000000
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/author_elective_update/scan_table_check_fbdce17f2fb2fc505dcb59ab2799b6d0.xml
+++ /dev/null
@@ -1,110 +0,0 @@
-
-
- true
- false
-
- upgradability
- super_class.name=sys_user^EQ
-
-
- Extending the sys_user table is NOT recommended because it can cause problems when a user needs to be present in both tables. Remember that the User ID [sys_user.user_name] is a unique field.
-
-If you have:
-sys_user
-contract_user extends sys_user
-subsidiary_user extends sys_user
-Then you create Bob who is a contract_user
-Bob's class will never be sys_user.
-Bob can never be a subsidiary_user.
-To make Bob both a contract_user and a subsidiary_user, Bob must have 2 accounts.
-
- scan_finding
- User table should not be extended
- 2
- Reevaluate the requirements behind this and remove the extended tables:
-- Different process-related requirements should be tackled by standardizing processes at an organizational level.
-
- 100
- 0
- 1
-
- User table should not be extended
- scan_table_check
- nia.mccash
- 2021-10-01 16:32:00
- fbdce17f2fb2fc505dcb59ab2799b6d0
- 1
- User table should not be extended
- ca8467c41b9abc10ce0f62c3b24bcbaa
-
- ca8467c41b9abc10ce0f62c3b24bcbaa
- scan_table_check_fbdce17f2fb2fc505dcb59ab2799b6d0
- nia.mccash
- 2021-10-01 16:34:13
-
sys_db_object
- false
-
-
- DELETE
- ca8467c41b9abc10ce0f62c3b24bcbaa
-
- d11553a0dbb3df0ccbf6d5b0cf961947
- dev69016
- scan_table_check_fbdce17f2fb2fc505dcb59ab2799b6d0
- <?xml version="1.0" encoding="UTF-8"?><record_update table="scan_table_check"><scan_table_check action="INSERT_OR_UPDATE"><active>true</active><advanced>false</advanced><attributes/><category>upgradability</category><conditions table="sys_db_object">super_class.name=sys_user^EQ<item endquery="false" field="super_class.name" goto="false" newquery="false" operator="=" or="false" value="sys_user"/><item endquery="true" field="" goto="false" newquery="false" operator="=" or="false" value=""/></conditions><description>Extending the sys_user table is NOT recommended because it can cause problems when a user needs to be present in both tables. Remember that the User ID [sys_user.user_name] is a unique field.
-
-If you have:
-sys_user
-contract_user extends sys_user
-subsidiary_user extends sys_user
-Then you create Bob who is a contract_user
-Bob's class will never be sys_user.
-Bob can never be a subsidiary_user.
-To make Bob both a contract_user and a subsidiary_user, Bob must have 2 accounts.</description><documentation_url/><finding_type>scan_finding</finding_type><name>User table should not be extended</name><priority>2</priority><resolution_details>Reevaluate the requirements behind this and remove the extended tables:
-- Different process-related requirements should be tackled by standardizing processes at an organizational level. </resolution_details><run_condition/><score_max>100</score_max><score_min>0</score_min><score_scale>1</score_scale><script><![CDATA[(function (engine) {
-
- // Add your code here
-
-})(engine);]]></script><short_description>User table should not be extended</short_description><sys_class_name>scan_table_check</sys_class_name><sys_created_by>nia.mccash</sys_created_by><sys_created_on>2021-10-01 16:32:00</sys_created_on><sys_id>fbdce17f2fb2fc505dcb59ab2799b6d0</sys_id><sys_mod_count>1</sys_mod_count><sys_name>User table should not be extended</sys_name><sys_package display_value="Example Instance Checks" source="x_appe_exa_checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_package><sys_policy/><sys_scope display_value="Example Instance Checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_scope><sys_update_name>scan_table_check_fbdce17f2fb2fc505dcb59ab2799b6d0</sys_update_name><sys_updated_by>nia.mccash</sys_updated_by><sys_updated_on>2021-10-01 16:34:13</sys_updated_on><table>sys_db_object</table><use_manifest>false</use_manifest></scan_table_check></record_update>
- 1668297445
- User table should not be extended
-
- 0d6daf032ffeb8505dcb59ab2799b6e1
- sys_update_set
- current
- nia.mccash
- 2021-10-01 16:34:13
- 824539fb2ff2fc505dcb59ab2799b62b
- 0
- 17c3cb4c9b10000001
- nia.mccash
- 2021-10-01 16:34:13
- Table Check
- 0a4539fbeef2fc5050e254d248f3de2a
- 0a4539fbeef2fc5050e254d248f3de2a:1668297445,75c4717719f2fc5076a78eda34a02d45:-1792330661
-
-
- 656693ff2f7efc505dcb59ab2799b628
- sys_metadata_delete
- nia.mccash
- 2021-10-01 23:38:32
- scan_table_check
- 8bdb0dfae5f94c43bb83282705ea20d9
- fbdce17f2fb2fc505dcb59ab2799b6d0
- 0
- User table should not be extended
- ca8467c41b9abc10ce0f62c3b24bcbaa
-
-
- ca8467c41b9abc10ce0f62c3b24bcbaa
- 30a78b9b9290467a96959a65d2b2d304
- scan_table_check_fbdce17f2fb2fc505dcb59ab2799b6d0
- 824539fb2ff2fc505dcb59ab2799b62b
- nia.mccash
- 2021-10-01 23:38:32
-
-
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt b/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt
index c065425..0015c61 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt
@@ -1 +1 @@
-2GkIkYTRLHBrnaK0BLk-XjxdsvdTIZ9jJdpNRMX35K_6xuWTi5y1Ry99K-DOjlG11wqAiWwvl7aCdE4ZWrSiATbI0lxnUdQ9WxlKwYNvs1x4VCYSXFOyYvTvKT3kiAZAzCrckOa4Em4EIaQWsrb_I8Hs0bgKv33rj-ePUrlm_eyaKJ2rnW23umP3MLy86FEu-J5jxkDLisX7iqlAtjOoRsUQBweQsMoxupOYvfpdE9hb2_IVDL9CoKdTg80_4ggyJ8PNBz0-61EPdmnU7cRKcwrgivmxrwlsMZRJ1uYb2HSI-uveGE4A7AF1o6mBZIz6ssbtFd7EiA0adaGXD5P15jiG014hPjkYP4HKiiA0_Yjt6wL60LGi3OSCJ9gd8YGeijcceUhadJ8o7-_9kKB87bMrCZLimt0eMOU9IP8roKLd8mrCC7yROA1N93b861zaMf9Rya_aFIMJAxF42hodGemepQf6byCLRA_-rQf6UZS9gCn3BUKuaXq3SQ-zJZRa8abRZPslmATdHB_qc3qD-zHdKaau-2U4IjCX5uN8_zJWyiHrskGbzNbjghd7A0IyCLH5cWiIxHZp41YeMQQhXX0ZQyhH8rnFFviKVQkfU9MEVdpqhBTLKe5B0bM5sXYhejFEzKJayrE0FcpgYQhxsN3AyPQpH5w62LMaCkTbugU
\ No newline at end of file
+XwYWgF_RgCfq9W2rP9dsKHeJbZGdj-h74z2oDOlfDw3vXesh-TXJ61UjuHdsfGhuNObsGSTauO-z80LCe7y1YTBuCWejpy8kwJp5ZmswmLre4FpAN_o9WNNvfBj57DSSQafvCo4aMS4mWh-zwJurT1DErdGAH7cmnGtdjmQU0hTWu8VNSjgERKjKYJlky299gImjru3-0IBGJkhTKBSg1TkXUfVVCJcmh0Mgc2WliF22hjHZgxghJuAYWCDmV7BFXcfHXIlEvJXK4vkuSsClZd0dzWdRHHIQ7jsW5W8G3rY_0H2YJixYkarvQQW3pzNYsiKW5Cob76ZLsQkATWZmLGPzNn5RDQnNJfA6J0Tmo-CCfprWJJmygdLqttXJQzbECsNsWZZxyNafD5ck7r21mZwhKKA2pcx-_9oOUCn3YmECwHKEDb3GNqcJsWiGZKV4KKLBxh7dnXr2MKBL29kDlygZskywwG6Li2kcTYNtZcLVTj_HdLGMUG4KdvUINIvmK44R69CjsvOcBqOuizg98G73-jyFdMJ1hj-h4MsN2Lfb5mEYFDMZ3am4Ow868tdCr8gtUXDHAYlDA5evNOsyjAsyGHoP-C7fHGf83Y9DVeYDztBoyLrgXECePpVn2rP9yZJMtt3NvdsgPccds832CCdP1UZ6xN4hqsGI143ftGk
\ No newline at end of file
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/sys_app_ca8467c41b9abc10ce0f62c3b24bcbaa.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/sys_app_ca8467c41b9abc10ce0f62c3b24bcbaa.xml
index 825590d..6d660f1 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/sys_app_ca8467c41b9abc10ce0f62c3b24bcbaa.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/sys_app_ca8467c41b9abc10ce0f62c3b24bcbaa.xml
@@ -5,6 +5,7 @@
logfalse
+ falsehelsinki_es5true
@@ -15,6 +16,7 @@
Example Instance Checks
+ falsefalse
@@ -24,6 +26,7 @@
x_appe_exa_checks
+ sys_appdaniel.draes
@@ -40,4 +43,5 @@
1.0.0
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_column_type_check_4514d5c7400730107f44dbb3b15cf295.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_column_type_check_4514d5c7400730107f44dbb3b15cf295.xml
index fb67d61..ca15dfe 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_column_type_check_4514d5c7400730107f44dbb3b15cf295.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_column_type_check_4514d5c7400730107f44dbb3b15cf295.xml
@@ -35,4 +35,5 @@
ali.abdulrazak2021-10-11 17:02:49
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_column_type_check_c5493fd897523110839d76021153afb8.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_column_type_check_c5493fd897523110839d76021153afb8.xml
index 7413a49..ed55dd7 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_column_type_check_c5493fd897523110839d76021153afb8.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_column_type_check_c5493fd897523110839d76021153afb8.xml
@@ -47,4 +47,5 @@
admin2023-10-31 17:25:20
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_0b7623d41b1afc10ce0f62c3b24bcb24.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_0b7623d41b1afc10ce0f62c3b24bcb24.xml
index 6651bdf..fc8b761 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_0b7623d41b1afc10ce0f62c3b24bcb24.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_0b7623d41b1afc10ce0f62c3b24bcb24.xml
@@ -4,6 +4,7 @@
performanceIf a cache flush is triggered as part of a non-ootb script execution this will require the platform to rebuild the cache before returning to its BAU state. This activity has a significant performance impact.https://developer.servicenow.com/app.do#!/api_doc?v=newyork&id=r_SGSYS-setProperty_S_S_S
+ Cache flushed as part of scripts2Remove any cache flush triggers unless necessary. Recommended is only the pre-defined cache flush actions that are built into out the box solutions.
@@ -62,4 +63,5 @@ Care should be taken when setting system properties (sys_properties) using this
mark.roethof2021-10-03 16:55:38
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_0eeac3042f0730103307235df699b6d1.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_0eeac3042f0730103307235df699b6d1.xml
index 9609d61..26120d2 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_0eeac3042f0730103307235df699b6d1.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_0eeac3042f0730103307235df699b6d1.xml
@@ -40,4 +40,5 @@ For the rare cases where you are interested in the whole XML document, simply mu
mark.roethof2021-10-02 17:26:47
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_1043deaf2ffa7c505dcb59ab2799b6a6.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_1043deaf2ffa7c505dcb59ab2799b6a6.xml
index cab388f..6a0a88d 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_1043deaf2ffa7c505dcb59ab2799b6a6.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_1043deaf2ffa7c505dcb59ab2799b6a6.xml
@@ -1,7 +1,6 @@
true
- securityThe eval() function evaluates or executes an argument. Improper use of eval() opens up your code for injection attacks and debugging can be more challenging, as no line numbers are displayed with an error, for example.https://developer.servicenow.com/dev.do#!/guides/rome/now-platform/tpb-guide/scripting_technical_best_practices#avoid-the-eval-function-
@@ -39,4 +38,5 @@ GlideEvaluator.evaluateString("gs.log('Hello World');");nia.mccash2021-10-02 14:12:05
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_1c72ae442fc370905dcb59ab2799b6e2.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_1c72ae442fc370905dcb59ab2799b6e2.xml
index 0380cc8..c322140 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_1c72ae442fc370905dcb59ab2799b6e2.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_1c72ae442fc370905dcb59ab2799b6e2.xml
@@ -1,7 +1,6 @@
true
- manageabilityAvoid using hard-coded values in scripts, as they can lead to unpredictable results and can be difficult to track down later. Hard coding sys_ids is not recommended, as they may not be the same between instances. https://developer.servicenow.com/dev.do#!/guides/rome/now-platform/tpb-guide/scripting_technical_best_practices#do-not-use-hard-coded-values
@@ -46,4 +45,16 @@
nia.mccash2021-10-04 14:07:43
+
+
+ 1c72ae442fc370905dcb59ab2799b6e2
+ admin
+ 2024-10-30 10:47:11
+ 576a8631c3e55250a8361dd1b40131e6
+ 0
+ admin
+ 2024-10-30 10:47:11
+
scan_linter_check
+ false
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_22a19fd62f4778105dcb59ab2799b6e5.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_22a19fd62f4778105dcb59ab2799b6e5.xml
index a608fab..fcefd85 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_22a19fd62f4778105dcb59ab2799b6e5.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_22a19fd62f4778105dcb59ab2799b6e5.xml
@@ -1,7 +1,6 @@
true
- performanceThe value of a reference field is a sys_id. When you dot-walk to the sys_id, the system does an additional database query to retrieve the caller_id record, then retrieves the sys_id. This can lead to performance issues. https://developer.servicenow.com/dev.do#!/guides/rome/now-platform/tpb-guide/scripting_technical_best_practices#avoid-dot-walking-to-the-sys-id-of-a-reference-field
@@ -55,4 +54,5 @@ var id = current.getValue('caller_id');
nia.mccash2021-10-10 01:16:46
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_236a0a79c3a55250a8361dd1b40131dd.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_236a0a79c3a55250a8361dd1b40131dd.xml
new file mode 100644
index 0000000..efce3e3
--- /dev/null
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_236a0a79c3a55250a8361dd1b40131dd.xml
@@ -0,0 +1,59 @@
+
+
+ true
+ manageability
+ Avoid using hard-coded values in scripts, as they can lead to unpredictable results and can be difficult to track down later. Hard coding sys_ids is not recommended, as they may not be the same between instances.
+ https://developer.servicenow.com/dev.do#!/guides/rome/now-platform/tpb-guide/scripting_technical_best_practices#do-not-use-hard-coded-values
+ scan_finding
+ Do not use hard-coded sys_ids Contri
+ 3
+ Instead, try looking up a value by reference or by creating a property and retrieving the value with gs.getProperty().
+
+ 100
+ 0
+ 1
+
+ Do not use hard-coded sys_ids
+ scan_linter_check
+ admin
+ 2024-10-30 10:47:12
+ 236a0a79c3a55250a8361dd1b40131dd
+ 0
+ Do not use hard-coded sys_ids Contri
+ ca8467c41b9abc10ce0f62c3b24bcbaa
+
+ ca8467c41b9abc10ce0f62c3b24bcbaa
+ scan_linter_check_236a0a79c3a55250a8361dd1b40131dd
+ admin
+ 2024-10-30 10:47:12
+
+
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_2e2a8fc02f0730103307235df699b659.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_2e2a8fc02f0730103307235df699b659.xml
index 494589f..d39401e 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_2e2a8fc02f0730103307235df699b659.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_2e2a8fc02f0730103307235df699b659.xml
@@ -39,4 +39,5 @@
mark.roethof2021-10-02 17:23:33
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_4986078c2f6330d05dcb59ab2799b6d9.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_4986078c2f6330d05dcb59ab2799b6d9.xml
index 87d3b0b..7dc655b 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_4986078c2f6330d05dcb59ab2799b6d9.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_4986078c2f6330d05dcb59ab2799b6d9.xml
@@ -1,7 +1,6 @@
true
- performanceProviding an alternate, default value when calling gs.getProperty() helps mitigate risk of errors when property does not exist.
@@ -67,10 +66,14 @@
nia.mccash2021-10-27 13:39:004986078c2f6330d05dcb59ab2799b6d9
+ 0Provide alternate value when fetching Glide propertyca8467c41b9abc10ce0f62c3b24bcbaaca8467c41b9abc10ce0f62c3b24bcbaascan_linter_check_4986078c2f6330d05dcb59ab2799b6d9
+ admin
+ 2024-10-30 10:37:20
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_4bdb65272f561110a1803e0ef699b68e.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_4bdb65272f561110a1803e0ef699b68e.xml
index b55801c..86c3dbe 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_4bdb65272f561110a1803e0ef699b68e.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_4bdb65272f561110a1803e0ef699b68e.xml
@@ -58,4 +58,5 @@
admin2022-10-08 17:05:28
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_51e943c02f0730103307235df699b64b.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_51e943c02f0730103307235df699b64b.xml
index b8ac2c2..2dcdd49 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_51e943c02f0730103307235df699b64b.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_51e943c02f0730103307235df699b64b.xml
@@ -39,4 +39,5 @@
mark.roethof2021-10-02 17:22:22
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_88cb65272f561110a1803e0ef699b688.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_88cb65272f561110a1803e0ef699b688.xml
index 446c8cd..8322129 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_88cb65272f561110a1803e0ef699b688.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_88cb65272f561110a1803e0ef699b688.xml
@@ -37,4 +37,5 @@
admin2022-10-08 17:05:00
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_90db61672f561110a1803e0ef699b648.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_90db61672f561110a1803e0ef699b648.xml
index 8f279da..20986c9 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_90db61672f561110a1803e0ef699b648.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_90db61672f561110a1803e0ef699b648.xml
@@ -58,4 +58,5 @@
admin2022-10-08 17:05:17
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_b46a4fc02f0730103307235df699b6e0.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_b46a4fc02f0730103307235df699b6e0.xml
index 30c3823..9d80df0 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_b46a4fc02f0730103307235df699b6e0.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_b46a4fc02f0730103307235df699b6e0.xml
@@ -92,4 +92,5 @@
mark.roethof2021-10-02 17:24:32
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_c0f4d1102f87b0905dcb59ab2799b693.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_c0f4d1102f87b0905dcb59ab2799b693.xml
index e3926fd..c25179a 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_c0f4d1102f87b0905dcb59ab2799b693.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_c0f4d1102f87b0905dcb59ab2799b693.xml
@@ -1,7 +1,6 @@
true
- securityThe platform is Javascript and a lot of code is run in a global variable scope.
@@ -55,4 +54,5 @@ When using more than one GlideRecord in your script, you may also accidentally r
nia.mccash2021-10-04 14:05:50
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_d58d1d3f2f6d7110d53f821df699b63d.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_d58d1d3f2f6d7110d53f821df699b63d.xml
index 02db9d5..221b86d 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_d58d1d3f2f6d7110d53f821df699b63d.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_d58d1d3f2f6d7110d53f821df699b63d.xml
@@ -42,4 +42,5 @@ https://www.servicenow.com/community/now-platform-articles/demystifying-instance
admin2023-10-04 20:23:03
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_e09640b5158330107f4499658835edbb.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_e09640b5158330107f4499658835edbb.xml
index 1e81123..ac676c8 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_e09640b5158330107f4499658835edbb.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_e09640b5158330107f4499658835edbb.xml
@@ -38,4 +38,5 @@ For client side scripts, you can either access the URL via scractpad from server
admin2021-10-07 13:39:33
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_f7cb61672f561110a1803e0ef699b618.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_f7cb61672f561110a1803e0ef699b618.xml
index 37eb3d5..edbc6ed 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_f7cb61672f561110a1803e0ef699b618.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_f7cb61672f561110a1803e0ef699b618.xml
@@ -38,4 +38,5 @@
admin2022-10-08 17:05:15
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_script_only_check_0376b5332f21b110d53f821df699b664.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_script_only_check_0376b5332f21b110d53f821df699b664.xml
index 8d940cf..833947c 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_script_only_check_0376b5332f21b110d53f821df699b664.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_script_only_check_0376b5332f21b110d53f821df699b664.xml
@@ -50,4 +50,5 @@
admin2023-10-04 22:18:37
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_script_only_check_0dfff25a2f83301002f0ffecf699b649.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_script_only_check_0dfff25a2f83301002f0ffecf699b649.xml
index 6377037..810f52a 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_script_only_check_0dfff25a2f83301002f0ffecf699b649.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_script_only_check_0dfff25a2f83301002f0ffecf699b649.xml
@@ -1,7 +1,6 @@
true
- manageabilityUpdate set should not have more than 1000 updates as it makes it difficult for the release team to analyze, also could potentially bring in environment slowness while committing
@@ -35,10 +34,14 @@
admin2021-10-09 18:01:530dfff25a2f83301002f0ffecf699b649
+ 0Update set should not have more than 1000 updatesca8467c41b9abc10ce0f62c3b24bcbaaca8467c41b9abc10ce0f62c3b24bcbaascan_script_only_check_0dfff25a2f83301002f0ffecf699b649
+ admin
+ 2024-10-30 10:37:20
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_script_only_check_1e7511642f2330100b40bea62799b6f1.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_script_only_check_1e7511642f2330100b40bea62799b6f1.xml
index 134ff54..a829c54 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_script_only_check_1e7511642f2330100b40bea62799b6f1.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_script_only_check_1e7511642f2330100b40bea62799b6f1.xml
@@ -1,7 +1,6 @@
true
- 906611642f2330100b40bea62799b6b7securityIt is worthy to check all reports that are with role public - as they can expose data to unauthenticated users via:
https : / / <instance>.service-now.com/sys_report_display.do?sysparm_report_id=<sysID>
@@ -30,10 +29,14 @@
admin2021-10-28 18:46:021e7511642f2330100b40bea62799b6f1
+ 0Public reports to be verified ca8467c41b9abc10ce0f62c3b24bcbaaca8467c41b9abc10ce0f62c3b24bcbaascan_script_only_check_1e7511642f2330100b40bea62799b6f1
+ admin
+ 2024-10-30 10:37:20
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_script_only_check_266f17f52f121110a1803e0ef699b6a1.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_script_only_check_266f17f52f121110a1803e0ef699b6a1.xml
index d00d561..9b2d503 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_script_only_check_266f17f52f121110a1803e0ef699b6a1.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_script_only_check_266f17f52f121110a1803e0ef699b6a1.xml
@@ -60,4 +60,5 @@ In some cases, the reference gets broken. Technically the field will still hold
admin2022-10-03 15:00:59
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_script_only_check_4cfd41f82f43f0107c12db9df699b691.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_script_only_check_4cfd41f82f43f0107c12db9df699b691.xml
index 2af0017..6a79831 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_script_only_check_4cfd41f82f43f0107c12db9df699b691.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_script_only_check_4cfd41f82f43f0107c12db9df699b691.xml
@@ -4,6 +4,7 @@
performanceSynchronous usage of AJAX calls (getXMLWait) pauses the browser interaction until data is retrieved from the server side and thereby reducing user experience. Using them in an onLoad or onChange client side scripts is not a best practice recommendation and can create performance issues for your usershttps://support.servicenow.com/kb?id=kb_article_view&sysparm_article=KB0517273
+ Using Synchronous AJAX calls in client script2Relpace getXMLWait with Asynchronous GlideAjax calls ie use getXML or getXMLAnswer with a callback function
@@ -43,4 +44,5 @@
admin2021-10-04 17:12:11
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_script_only_check_63ddf5782f6691104f07a1fef699b624.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_script_only_check_63ddf5782f6691104f07a1fef699b624.xml
index a01a8c7..bb97a30 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_script_only_check_63ddf5782f6691104f07a1fef699b624.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_script_only_check_63ddf5782f6691104f07a1fef699b624.xml
@@ -37,10 +37,14 @@
admin2022-10-12 15:36:3463ddf5782f6691104f07a1fef699b624
+ 0EDM table doesn't have clone exclusion on Prodca8467c41b9abc10ce0f62c3b24bcbaareadca8467c41b9abc10ce0f62c3b24bcbaascan_script_only_check_63ddf5782f6691104f07a1fef699b624
+ admin
+ 2024-10-30 10:37:21
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_script_only_check_718e43b42f2330100b40bea62799b67f.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_script_only_check_718e43b42f2330100b40bea62799b67f.xml
index f0b3ddf..8551b30 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_script_only_check_718e43b42f2330100b40bea62799b67f.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_script_only_check_718e43b42f2330100b40bea62799b67f.xml
@@ -1,7 +1,6 @@
true
- 125fc7742f2330100b40bea62799b6fbsecurity
@@ -30,10 +29,14 @@
admin2021-10-29 22:13:02718e43b42f2330100b40bea62799b67f
+ 0Locked out user for Scheduled Jobca8467c41b9abc10ce0f62c3b24bcbaaca8467c41b9abc10ce0f62c3b24bcbaascan_script_only_check_718e43b42f2330100b40bea62799b67f
+ admin
+ 2024-10-30 10:37:21
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_script_only_check_7f8a38342f0330103307235df699b6b3.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_script_only_check_7f8a38342f0330103307235df699b6b3.xml
index 7944301..f00c55b 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_script_only_check_7f8a38342f0330103307235df699b6b3.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_script_only_check_7f8a38342f0330103307235df699b6b3.xml
@@ -56,4 +56,5 @@
mark.roethof2021-10-04 14:52:29
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_script_only_check_9c5f1fb52f121110a1803e0ef699b6ad.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_script_only_check_9c5f1fb52f121110a1803e0ef699b6ad.xml
index 18cca9f..699ac29 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_script_only_check_9c5f1fb52f121110a1803e0ef699b6ad.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_script_only_check_9c5f1fb52f121110a1803e0ef699b6ad.xml
@@ -51,4 +51,5 @@ In some cases, the reference gets broken. Technically the field will still hold
admin2022-10-03 15:00:33
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_script_only_check_d11fd7f52f121110a1803e0ef699b601.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_script_only_check_d11fd7f52f121110a1803e0ef699b601.xml
index 2c3fdc7..313d424 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_script_only_check_d11fd7f52f121110a1803e0ef699b601.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_script_only_check_d11fd7f52f121110a1803e0ef699b601.xml
@@ -61,4 +61,5 @@ In some cases, the reference gets broken. Technically the field will still hold
admin2022-10-03 15:00:07
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_script_only_check_fb01f46edb7a9190c4ebc5860596190b.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_script_only_check_fb01f46edb7a9190c4ebc5860596190b.xml
index adc444e..48a8a23 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_script_only_check_fb01f46edb7a9190c4ebc5860596190b.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_script_only_check_fb01f46edb7a9190c4ebc5860596190b.xml
@@ -32,10 +32,14 @@ Note: It was suggested by ServiceNow support to add table "http_connection" in c
admin2022-10-30 07:13:38fb01f46edb7a9190c4ebc5860596190b
+ 0HTTP connection records not excluded on clones from Prodca8467c41b9abc10ce0f62c3b24bcbaaca8467c41b9abc10ce0f62c3b24bcbaascan_script_only_check_fb01f46edb7a9190c4ebc5860596190b
+ admin
+ 2024-10-30 10:37:21
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_003db2922f43301002f0ffecf699b617.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_003db2922f43301002f0ffecf699b617.xml
index 5785358..f5c6ce1 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_003db2922f43301002f0ffecf699b617.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_003db2922f43301002f0ffecf699b617.xml
@@ -2,7 +2,6 @@
truefalse
- manageabilitydescriptionISEMPTY^state!=ignore^EQ
@@ -28,12 +27,16 @@
admin2021-10-09 16:31:59003db2922f43301002f0ffecf699b617
+ 0Update Set Description Emptyca8467c41b9abc10ce0f62c3b24bcbaaca8467c41b9abc10ce0f62c3b24bcbaascan_table_check_003db2922f43301002f0ffecf699b617
+ admin
+ 2024-10-30 10:37:21
false
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_12b47a84977211108e72fed11153af8e.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_12b47a84977211108e72fed11153af8e.xml
index 643cedb..b9ea13e 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_12b47a84977211108e72fed11153af8e.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_12b47a84977211108e72fed11153af8e.xml
@@ -27,12 +27,16 @@
admin2022-10-22 22:07:4912b47a84977211108e72fed11153af8e
+ 0Active users with past employment end dateca8467c41b9abc10ce0f62c3b24bcbaaca8467c41b9abc10ce0f62c3b24bcbaascan_table_check_12b47a84977211108e72fed11153af8e
+ admin
+ 2024-10-30 10:37:21
sn_hr_core_profile
false
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_145e91272f367c505dcb59ab2799b6c0.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_145e91272f367c505dcb59ab2799b6c0.xml
index 6857ff5..64828e6 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_145e91272f367c505dcb59ab2799b6c0.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_145e91272f367c505dcb59ab2799b6c0.xml
@@ -11,6 +11,7 @@
Script includes only load when called.
https://developer.servicenow.com/dev.do#!/guides/rome/now-platform/tpb-guide/business_rules_technical_best_practices
+ Use Script Includes Instead of Global Business Rules2If you have already written a global Business Rule, move the function definition to a Script Include. The name of the Script Include must match the name of the function for the Script Include to work properly. There is no need to modify any calls to the named function.
@@ -39,4 +40,5 @@ Script includes only load when called.
false
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_28d33b441bdabc10ce0f62c3b24bcbcb.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_28d33b441bdabc10ce0f62c3b24bcbcb.xml
index 23dbfb8..86c03e9 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_28d33b441bdabc10ce0f62c3b24bcbcb.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_28d33b441bdabc10ce0f62c3b24bcbcb.xml
@@ -9,6 +9,7 @@
getMessage used in a client script needs to have the message key added to the Messages field on the script record.http://docs.servicenow.com/csh?topicname=t_TranslateAClientScriptMessage.html
+ getMessage() called in Client Script 3Use the messages field on the client script record to load the message key being used in getMessage().
@@ -37,4 +38,5 @@
sys_script_client
false
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_2b77e92f2fb67c505dcb59ab2799b61f.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_2b77e92f2fb67c505dcb59ab2799b61f.xml
index 9235487..2ce3839 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_2b77e92f2fb67c505dcb59ab2799b61f.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_2b77e92f2fb67c505dcb59ab2799b61f.xml
@@ -9,6 +9,7 @@
A global client script is any client script where the selected Table is Global. Global client scripts have no table restrictions; therefore they will load on every page in the system introducing browser load delay in the process. There is no benefit to loading this kind of scripts on every page.https://developer.servicenow.com/dev.do#!/guides/rome/now-platform/tpb-guide/client_scripting_technical_best_practices#client-scripting-practices-to-avoid-
+ Avoid Global Client Scripts2As an alternative, and for a more modular and scalable approach, consider moving client scripts to a base table (such as Task [task] or Configuration Item [cmdb_ci]) that can be inherited for all the child/extending tables. This eliminates the system loading the scripts on every form in the UI - such as home pages or Service Catalog where they are rarely (if ever) needed.
@@ -37,4 +38,5 @@
false
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_532dc24e976611108e72fed11153af9a.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_532dc24e976611108e72fed11153af9a.xml
index a7ada9f..57b054e 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_532dc24e976611108e72fed11153af9a.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_532dc24e976611108e72fed11153af9a.xml
@@ -29,12 +29,16 @@
admin2022-10-16 15:11:54532dc24e976611108e72fed11153af9a
+ 0Check Business Rules without Discription or commentca8467c41b9abc10ce0f62c3b24bcbaaca8467c41b9abc10ce0f62c3b24bcbaascan_table_check_532dc24e976611108e72fed11153af9a
+ admin
+ 2024-10-30 10:37:22
sys_script
false
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_552c3f3a400330107f44dbb3b15cf2f8.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_552c3f3a400330107f44dbb3b15cf2f8.xml
index ad7a6c1..689b8a4 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_552c3f3a400330107f44dbb3b15cf2f8.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_552c3f3a400330107f44dbb3b15cf2f8.xml
@@ -45,4 +45,5 @@ This will result in the business rule calling itself again, which would then cal
false
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_6db4a7081b9abc10ce0f62c3b24bcbd0.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_6db4a7081b9abc10ce0f62c3b24bcbd0.xml
index 0a3618e..51b0f0d 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_6db4a7081b9abc10ce0f62c3b24bcbd0.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_6db4a7081b9abc10ce0f62c3b24bcbd0.xml
@@ -6,6 +6,7 @@
When two Script Includes exist with the same name in the same scope, when those script includes are called it is unreliable as to which Script Include will actually be instantiated.http://docs.servicenow.com/csh?topicname=c_ScriptIncludes.html
+ Duplicate Script Include Name2Ensure all your Script Includes have unique names. Rename any script include with a duplicate name with a unique name.d
@@ -44,4 +45,5 @@
false
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_77a6af2f1b363c10b32c642aab4bcb36.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_77a6af2f1b363c10b32c642aab4bcb36.xml
index 362b563..871df2b 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_77a6af2f1b363c10b32c642aab4bcb36.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_77a6af2f1b363c10b32c642aab4bcb36.xml
@@ -9,6 +9,7 @@
Enforce existing access controls and require additional access to data. In addition to requiring authentication to access the API, require authorization to access data. https://docs.servicenow.com/csh?topicname=scripted-rest-good-practices.html
+ Scripted REST API without Authentication2Scripted REST APIs should be not be public but enforce access controls and require additional access to data.
@@ -39,4 +40,5 @@ Configure these API resources to require a more strict ACL.
sys_ws_operation
false
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_7818ddaa07221110e765f9fc7c1ed0a5.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_7818ddaa07221110e765f9fc7c1ed0a5.xml
index 6295b41..2244fd1 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_7818ddaa07221110e765f9fc7c1ed0a5.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_7818ddaa07221110e765f9fc7c1ed0a5.xml
@@ -30,12 +30,16 @@
admin2022-10-17 23:21:277818ddaa07221110e765f9fc7c1ed0a5
+ 0Active groups without active usersca8467c41b9abc10ce0f62c3b24bcbaaca8467c41b9abc10ce0f62c3b24bcbaascan_table_check_7818ddaa07221110e765f9fc7c1ed0a5
+ admin
+ 2024-10-30 10:37:22
sys_user_group
false
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_7c3f6f6b1b763c10b32c642aab4bcb10.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_7c3f6f6b1b763c10b32c642aab4bcb10.xml
index 6621ded..412930c 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_7c3f6f6b1b763c10b32c642aab4bcb10.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_7c3f6f6b1b763c10b32c642aab4bcb10.xml
@@ -11,6 +11,7 @@
Models are specific versions or various configurations of an asset.
Models are used for managing and tracking assets through various ServiceNow platform asset applications, including Product Catalog, Asset Management, and Procurement.
http://docs.servicenow.com/csh?topicname=c_ManagingProductCatalogItems.html
+ Product Catalog without Product Models3An Item in the Product Catalog should always be linked to a Product Model.
@@ -39,4 +40,5 @@ Models are used for managing and tracking assets through various ServiceNow plat
pc_product_cat_item
false
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_889f5a42976a11108e72fed11153af50.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_889f5a42976a11108e72fed11153af50.xml
index 525d736..5bb1340 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_889f5a42976a11108e72fed11153af50.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_889f5a42976a11108e72fed11153af50.xml
@@ -29,12 +29,16 @@
admin2022-10-16 15:16:11889f5a42976a11108e72fed11153af50
+ 0Check Script Includes without Discription or commentca8467c41b9abc10ce0f62c3b24bcbaaca8467c41b9abc10ce0f62c3b24bcbaascan_table_check_889f5a42976a11108e72fed11153af50
+ admin
+ 2024-10-30 10:37:22
sys_script_include
false
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_88fbb74c1bdabc10ce0f62c3b24bcb22.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_88fbb74c1bdabc10ce0f62c3b24bcb22.xml
index 04b666e..4ed1a8f 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_88fbb74c1bdabc10ce0f62c3b24bcb22.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_88fbb74c1bdabc10ce0f62c3b24bcb22.xml
@@ -6,6 +6,7 @@
Every table should be secured by ACLshttp://docs.servicenow.com/csh?topicname=acl-rule-types.html
+ Tables without ACLs2For tables that have no ACLs defined, the default deny property can be used to make the wildcard table ACL rules restrict the read, write, create, and delete operations on all tables unless the user has the admin role or meets the requirements of another table ACL rule. This means that custom tables without ACLs will not be accessible by any other user beside admin.
@@ -44,4 +45,5 @@
false
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_952af3c81bdabc10ce0f62c3b24bcbb6.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_952af3c81bdabc10ce0f62c3b24bcbb6.xml
index 8b5b511..991aca0 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_952af3c81bdabc10ce0f62c3b24bcbb6.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_952af3c81bdabc10ce0f62c3b24bcbb6.xml
@@ -11,6 +11,7 @@
Read and Delete ACLs are frequently executed. Having complex database lookups can harm performance.https://docs.servicenow.com/csh?topicname=acl-advanced-config.html
+ Glide-API in ACL2Avoid database lookups in Access Control rules, as this can significantly impact performance.
@@ -39,4 +40,5 @@
false
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_b31e1c5c2f0e7110b0b62d5df699b619.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_b31e1c5c2f0e7110b0b62d5df699b619.xml
index ea6744e..b7862e9 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_b31e1c5c2f0e7110b0b62d5df699b619.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_b31e1c5c2f0e7110b0b62d5df699b619.xml
@@ -1,42 +1,43 @@
-
-
-
-true
-false
-manageability
-active=true^owner.active=false^EQ
-
-
-For the dashboard there should be an active owner who can administer/customize/adjust dashboards.
+
+
+ true
+ false
+ manageability
+ active=true^owner.active=false^EQ
+
+
+
+ For the dashboard there should be an active owner who can administer/customize/adjust dashboards.
During the time it can be a situation that person is no longer active in the system. It can be discovered and fixed with new person.
-
-scan_finding
-Active notification without any recipients
-3
-Find a new active person who can act as a dasboard owner
-
-100
-0
-1
-
-Dashboard Owner no longer active
-scan_table_check
-admin
-2023-10-18 15:12:12
-b31e1c5c2f0e7110b0b62d5df699b619
-1
-Active notification without any recipients
-global
-
-global
-scan_table_check_b31e1c5c2f0e7110b0b62d5df699b619
-admin
-2023-10-18 15:13:15
-
pa_dashboards
-false
-
-
+ Dashboard Owner no longer active
+ scan_table_check
+ admin
+ 2023-10-18 15:12:12
+ b31e1c5c2f0e7110b0b62d5df699b619
+ 1
+ Active notification without any recipients
+ ca8467c41b9abc10ce0f62c3b24bcbaa
+
+ ca8467c41b9abc10ce0f62c3b24bcbaa
+ scan_table_check_b31e1c5c2f0e7110b0b62d5df699b619
+ admin
+ 2023-10-18 15:13:15
+
false
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_ba0c998d875251106b0f20af8bbb3515.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_ba0c998d875251106b0f20af8bbb3515.xml
index b0eb5c8..d5d0137 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_ba0c998d875251106b0f20af8bbb3515.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_ba0c998d875251106b0f20af8bbb3515.xml
@@ -28,12 +28,16 @@ The best ways to get data into form/browser from the database are g_scratchpad,
admin2022-09-30 21:33:04ba0c998d875251106b0f20af8bbb3515
+ 0GlideRecord API in client scriptca8467c41b9abc10ce0f62c3b24bcbaaca8467c41b9abc10ce0f62c3b24bcbaascan_table_check_ba0c998d875251106b0f20af8bbb3515
+ admin
+ 2024-10-30 10:37:23
sys_script_client
false
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_bb3bf7a31bf63c10b32c642aab4bcb75.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_bb3bf7a31bf63c10b32c642aab4bcb75.xml
index a92add7..04c501e 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_bb3bf7a31bf63c10b32c642aab4bcb75.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_bb3bf7a31bf63c10b32c642aab4bcb75.xml
@@ -10,6 +10,7 @@
- To support a custom Incident table a high amount of customization to the other ITSM processes is required
- New functionality in future releases might not work on extended tables or would require further customization.
+ Incident table should not be extended1Reevaluate the requirements behind this and remove the extended tables:
@@ -40,4 +41,5 @@
sys_db_object
false
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_bd68e1cabc0330107f448f0d49361473.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_bd68e1cabc0330107f448f0d49361473.xml
index 08ff6a4..15f48a9 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_bd68e1cabc0330107f448f0d49361473.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_bd68e1cabc0330107f448f0d49361473.xml
@@ -47,4 +47,5 @@ In certain exception cases, if you need to use current.update() eg in onAfter sc
false
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_d3f47b4b97823110dd0178300153af08.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_d3f47b4b97823110dd0178300153af08.xml
index 7d60cea..f03b714 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_d3f47b4b97823110dd0178300153af08.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_d3f47b4b97823110dd0178300153af08.xml
@@ -41,4 +41,5 @@ Also, can set the property 'glide.ui.per_page' sys property value to 10, 20, 50
sys_user_preference
false
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_d4be41f82f43f0107c12db9df699b69d.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_d4be41f82f43f0107c12db9df699b69d.xml
index a8bc4ea..ffb6e20 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_d4be41f82f43f0107c12db9df699b69d.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_d4be41f82f43f0107c12db9df699b69d.xml
@@ -11,6 +11,7 @@
A business rule is triggered whenever a user opens a list or form view or when a user inserts/updates or deletes a record. Without any conditions added, it will always evaluate to true and triggerred at all times. This can add to the performance increasing server processing time and hence it is recommended to restrict business rule execution by either adding a condition or filter condition or a role condition and preventing its execution unless it is necessary.
+ Business Rule without any conditions3Define a condition on the Condition field or the Filter Condition or the Role Condition, the system will first evaluate these conditions and only then proceed to the execution of business rule script. If the condition fails, then the script wont execute. This will improve system performance and user experience.
@@ -39,4 +40,5 @@
sys_script
false
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_dcc8978c2f4a7110b0b62d5df699b603.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_dcc8978c2f4a7110b0b62d5df699b603.xml
index f283be2..bcb41f0 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_dcc8978c2f4a7110b0b62d5df699b603.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_dcc8978c2f4a7110b0b62d5df699b603.xml
@@ -1,40 +1,40 @@
-
-
-
-true
-false
-manageability
-active=true^recipient_usersISEMPTY^recipient_fieldsISEMPTY^recipient_groupsISEMPTY^EQ
-
-
-
-
-
-
-
-scan_finding
-Active notification without any recipients
-3
-
-
-100
-0
-1
-
-Neither of recipients class is specified
-scan_table_check
-admin
-2023-10-18 10:09:08
-dcc8978c2f4a7110b0b62d5df699b603
-1
-Active notification without any recipients
-global
-
-global
-scan_table_check_dcc8978c2f4a7110b0b62d5df699b603
-admin
-2023-10-18 10:09:26
-
sysevent_email_action
-false
-
-
+
+
+ true
+ false
+ manageability
+ active=true^recipient_usersISEMPTY^recipient_fieldsISEMPTY^recipient_groupsISEMPTY^EQ
+
+
+
+
+
+
+
+ scan_finding
+ Active notification without any recipients
+ 3
+
+
+ 100
+ 0
+ 1
+
+ Neither of recipients class is specified
+ scan_table_check
+ admin
+ 2023-10-18 10:09:08
+ dcc8978c2f4a7110b0b62d5df699b603
+ 1
+ Active notification without any recipients
+ ca8467c41b9abc10ce0f62c3b24bcbaa
+
+ ca8467c41b9abc10ce0f62c3b24bcbaa
+ scan_table_check_dcc8978c2f4a7110b0b62d5df699b603
+ admin
+ 2023-10-18 10:09:26
+
false
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_fbdce17f2fb2fc505dcb59ab2799b6d0.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_fbdce17f2fb2fc505dcb59ab2799b6d0.xml
index 5fe300e..9cc11b9 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_fbdce17f2fb2fc505dcb59ab2799b6d0.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_fbdce17f2fb2fc505dcb59ab2799b6d0.xml
@@ -2,7 +2,6 @@
truefalse
- upgradabilitysuper_class.name=sys_user^EQ
@@ -48,4 +47,5 @@ To make Bob both a contract_user and a subsidiary_user, Bob must have 2 accounts