Skip to content

Commit af1941b

Browse files
committed
Add erroring for when variables are given for aBulkOps query
1 parent b07001c commit af1941b

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

packages/app/src/cli/services/bulk-operations/execute-bulk-operation.ts

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import {AppLinkedInterface} from '../../models/app/app.js'
44
import {renderSuccess, renderInfo, renderWarning} from '@shopify/cli-kit/node/ui'
55
import {outputContent, outputToken} from '@shopify/cli-kit/node/output'
66
import {ensureAuthenticatedAdmin} from '@shopify/cli-kit/node/session'
7+
import {AbortError} from '@shopify/cli-kit/node/error'
78
import {parse} from 'graphql'
89

910
interface ExecuteBulkOperationInput {
@@ -23,7 +24,14 @@ export async function executeBulkOperation(input: ExecuteBulkOperationInput): Pr
2324

2425
const adminSession = await ensureAuthenticatedAdmin(storeFqdn)
2526

26-
const bulkOperationResponse = isMutation(query)
27+
const operationIsMutation = isMutation(query)
28+
if (!operationIsMutation && variables) {
29+
throw new AbortError(
30+
outputContent`The ${outputToken.yellow('--variables')} flag can only be used with mutations, not queries.`,
31+
)
32+
}
33+
34+
const bulkOperationResponse = operationIsMutation
2735
? await runBulkOperationMutation({adminSession, query, variables})
2836
: await runBulkOperationQuery({adminSession, query})
2937

packages/app/src/cli/services/bulk-operations/run-query.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ export async function runBulkOperationQuery(
1414
options: BulkOperationRunQueryOptions,
1515
): Promise<BulkOperationRunQueryMutation['bulkOperationRunQuery']> {
1616
const {adminSession, query} = options
17+
1718
const response = await adminRequestDoc<BulkOperationRunQueryMutation, {query: string}>({
1819
query: BulkOperationRunQuery,
1920
session: adminSession,

0 commit comments

Comments
 (0)