[PR feedback] minor polish adjustments after Gonzalo's review

Author: jordanverasamy

packages/app/src/cli/services/bulk-operations/execute-bulk-operation.test.ts

@@ -345,7 +345,7 @@ describe('executeBulkOperation', () => {
     expect(watchBulkOperation).toHaveBeenCalledWith(mockAdminSession, createdBulkOperation.id)
     expect(renderSuccess).toHaveBeenCalledWith(
       expect.objectContaining({
-        headline: expect.stringContaining('Bulk operation succeeded.'),
+        headline: expect.stringContaining('Bulk operation succeeded:'),
         body: expect.arrayContaining([expect.stringContaining('https://example.com/download')]),
       }),
     )

packages/app/src/cli/services/bulk-operations/execute-bulk-operation.ts

@@ -97,7 +97,7 @@ function renderBulkOperationResult(operation: BulkOperation): void {
       break
     case 'COMPLETED':
       if (operation.url) {
-        const downloadMessage = outputContent`Download results ${outputToken.link('here.', operation.url)}`.value
+        const downloadMessage = outputContent`Download results ${outputToken.link('here', operation.url)}.`.value
         renderSuccess({headline, body: [downloadMessage], customSections})
       } else {
         renderSuccess({headline, customSections})

packages/app/src/cli/services/bulk-operations/format-bulk-operation-status.test.ts

@@ -31,22 +31,22 @@ describe('formatBulkOperationStatus', () => {
 
   test('formats COMPLETED status', () => {
     const result = formatBulkOperationStatus(createMockOperation({status: 'COMPLETED', objectCount: 100}))
-    expect(result.value).toContain('Bulk operation succeeded.')
-    expect(result.value).toContain('(100 objects)')
+    expect(result.value).toContain('Bulk operation succeeded:')
+    expect(result.value).toContain('100 objects')
   })
 
   test('formats FAILED status with error code', () => {
     const result = formatBulkOperationStatus(
       createMockOperation({status: 'FAILED', objectCount: 10, errorCode: 'ACCESS_DENIED'}),
     )
     expect(result.value).toContain('Bulk operation failed.')
-    expect(result.value).toContain('(error: ACCESS_DENIED)')
+    expect(result.value).toContain('Error: ACCESS_DENIED')
   })
 
   test('formats FAILED status without error code', () => {
     const result = formatBulkOperationStatus(createMockOperation({status: 'FAILED', objectCount: 10, errorCode: null}))
     expect(result.value).toContain('Bulk operation failed.')
-    expect(result.value).toContain('(error: unknown)')
+    expect(result.value).toContain('Error: unknown')
   })
 
   test('formats CANCELING status', () => {

packages/app/src/cli/services/bulk-operations/format-bulk-operation-status.ts

@@ -12,9 +12,9 @@ export function formatBulkOperationStatus(
     case 'CREATED':
       return outputContent`Starting...`
     case 'COMPLETED':
-      return outputContent`Bulk operation succeeded. ${outputToken.gray(`(${String(operation.objectCount)} objects)`)}`
+      return outputContent`Bulk operation succeeded: ${outputToken.gray(`${String(operation.objectCount)} objects`)}`
     case 'FAILED':
-      return outputContent`Bulk operation failed. ${outputToken.gray(`(error: ${operation.errorCode ?? 'unknown'})`)}`
+      return outputContent`Bulk operation failed. ${outputToken.errorText(`Error: ${operation.errorCode ?? 'unknown.'}`)}`
     case 'CANCELING':
       return outputContent`Bulk operation canceling...`
     case 'CANCELED':