Add production-mode flag to app dev command

- Added `--production-mode` flag to `shopify app dev` command with default false
- Updated `DevSessionOptions` and `DevSessionPayload` interfaces to include `productionMode` parameter
- Added `productionMode` parameter to GraphQL dev session create/update mutations
- Modified all related interfaces and classes to pass the flag through the API chain
- Updated `DevSessionDelete` signature to omit both `assetsUrl` and `productionMode`

Co-authored-by: Ryan DJ Lee <[email protected]>

Author: zzooeeyy

packages/app/src/cli/api/graphql/app-dev/generated/dev-session-create.ts

@@ -7,6 +7,7 @@ import {TypedDocumentNode as DocumentNode} from '@graphql-typed-document-node/co
 export type DevSessionCreateMutationVariables = Types.Exact<{
   appId: Types.Scalars['String']['input']
   assetsUrl: Types.Scalars['String']['input']
+  productionMode: Types.Scalars['Boolean']['input']
 }>
 
 export type DevSessionCreateMutation = {
@@ -33,6 +34,11 @@ export const DevSessionCreate = {
           variable: {kind: 'Variable', name: {kind: 'Name', value: 'assetsUrl'}},
           type: {kind: 'NonNullType', type: {kind: 'NamedType', name: {kind: 'Name', value: 'String'}}},
         },
+        {
+          kind: 'VariableDefinition',
+          variable: {kind: 'Variable', name: {kind: 'Name', value: 'productionMode'}},
+          type: {kind: 'NonNullType', type: {kind: 'NamedType', name: {kind: 'Name', value: 'Boolean'}}},
+        },
       ],
       selectionSet: {
         kind: 'SelectionSet',
@@ -51,6 +57,11 @@ export const DevSessionCreate = {
                 name: {kind: 'Name', value: 'assetsUrl'},
                 value: {kind: 'Variable', name: {kind: 'Name', value: 'assetsUrl'}},
               },
+              {
+                kind: 'Argument',
+                name: {kind: 'Name', value: 'productionMode'},
+                value: {kind: 'Variable', name: {kind: 'Name', value: 'productionMode'}},
+              },
             ],
             selectionSet: {
               kind: 'SelectionSet',

packages/app/src/cli/api/graphql/app-dev/generated/dev-session-update.ts

@@ -7,6 +7,7 @@ import {TypedDocumentNode as DocumentNode} from '@graphql-typed-document-node/co
 export type DevSessionUpdateMutationVariables = Types.Exact<{
   appId: Types.Scalars['String']['input']
   assetsUrl: Types.Scalars['String']['input']
+  productionMode: Types.Scalars['Boolean']['input']
 }>
 
 export type DevSessionUpdateMutation = {
@@ -33,6 +34,11 @@ export const DevSessionUpdate = {
           variable: {kind: 'Variable', name: {kind: 'Name', value: 'assetsUrl'}},
           type: {kind: 'NonNullType', type: {kind: 'NamedType', name: {kind: 'Name', value: 'String'}}},
         },
+        {
+          kind: 'VariableDefinition',
+          variable: {kind: 'Variable', name: {kind: 'Name', value: 'productionMode'}},
+          type: {kind: 'NonNullType', type: {kind: 'NamedType', name: {kind: 'Name', value: 'Boolean'}}},
+        },
       ],
       selectionSet: {
         kind: 'SelectionSet',
@@ -51,6 +57,11 @@ export const DevSessionUpdate = {
                 name: {kind: 'Name', value: 'assetsUrl'},
                 value: {kind: 'Variable', name: {kind: 'Name', value: 'assetsUrl'}},
               },
+              {
+                kind: 'Argument',
+                name: {kind: 'Name', value: 'productionMode'},
+                value: {kind: 'Variable', name: {kind: 'Name', value: 'productionMode'}},
+              },
             ],
             selectionSet: {
               kind: 'SelectionSet',

packages/app/src/cli/api/graphql/app-dev/queries/dev-session-create.graphql

@@ -1,5 +1,5 @@
-mutation DevSessionCreate($appId: String!, $assetsUrl: String!) {
-  devSessionCreate(appId: $appId, assetsUrl: $assetsUrl) {
+mutation DevSessionCreate($appId: String!, $assetsUrl: String!, $productionMode: Boolean!) {
+  devSessionCreate(appId: $appId, assetsUrl: $assetsUrl, productionMode: $productionMode) {
     userErrors {
       message
       on

packages/app/src/cli/api/graphql/app-dev/queries/dev-session-update.graphql

@@ -1,5 +1,5 @@
-mutation DevSessionUpdate($appId: String!, $assetsUrl: String!) {
-  devSessionUpdate(appId: $appId, assetsUrl: $assetsUrl) {
+mutation DevSessionUpdate($appId: String!, $assetsUrl: String!, $productionMode: Boolean!) {
+  devSessionUpdate(appId: $appId, assetsUrl: $assetsUrl, productionMode: $productionMode) {
     userErrors {
       message
       on

packages/app/src/cli/commands/app/dev.ts

@@ -123,6 +123,12 @@ If you're using the Ruby app template, then you need to complete the following s
         'Key used to authenticate GraphiQL requests. Should be specified if exposing GraphiQL on a publicly accessible URL. By default, no key is required.',
       env: 'SHOPIFY_FLAG_GRAPHIQL_KEY',
     }),
+    'production-mode': Flags.boolean({
+      hidden: false,
+      description: 'Run the app in production mode.',
+      env: 'SHOPIFY_FLAG_PRODUCTION_MODE',
+      default: false,
+    }),
   }
 
   public static analyticsStopCommand(): string | undefined {
@@ -212,6 +218,7 @@ If you're using the Ruby app template, then you need to complete the following s
       graphiqlPort: flags['graphiql-port'],
       graphiqlKey: flags['graphiql-key'],
       tunnel,
+      productionMode: flags['production-mode'],
     }
 
     await dev(devOptions)

packages/app/src/cli/services/dev.ts

@@ -81,6 +81,7 @@ export interface DevOptions {
   notify?: string
   graphiqlPort?: number
   graphiqlKey?: string
+  productionMode: boolean
 }
 
 export async function dev(commandOptions: DevOptions) {

packages/app/src/cli/services/dev/processes/dev-session/dev-session-process.ts

@@ -17,6 +17,7 @@ export interface DevSessionProcessOptions {
   appPreviewURL: string
   appLocalProxyURL: string
   devSessionStatusManager: DevSessionStatusManager
+  productionMode: boolean
 }
 
 export interface DevSessionProcess extends BaseProcess<DevSessionProcessOptions> {

packages/app/src/cli/services/dev/processes/dev-session/dev-session.ts

@@ -16,6 +16,7 @@ interface DevSessionPayload {
   shopFqdn: string
   appId: string
   assetsUrl: string
+  productionMode: boolean
 }
 
 export interface UserError {
@@ -246,7 +247,12 @@ export class DevSession {
     // Create or update the dev session
     if (currentBundleController.signal.aborted) return {status: 'aborted'}
     try {
-      const payload = {shopFqdn: this.options.storeFqdn, appId: this.options.appId, assetsUrl: signedURL}
+      const payload = {
+        shopFqdn: this.options.storeFqdn, 
+        appId: this.options.appId, 
+        assetsUrl: signedURL,
+        productionMode: this.options.productionMode
+      }
       if (this.statusManager.status.isReady) {
         return this.devSessionUpdateWithRetry(payload)
       } else {
@@ -290,6 +296,7 @@ export class DevSession {
    * @param payload - The payload to update the dev session with
    */
   private async devSessionUpdateWithRetry(payload: DevSessionPayload): Promise<DevSessionResult> {
+    await this.logger.info(`Dev session update options: ${JSON.stringify(payload)}`)
     const result = await performActionWithRetryAfterRecovery(
       async () => this.options.developerPlatformClient.devSessionUpdate(payload),
       () => this.options.developerPlatformClient.refreshToken(),
@@ -306,6 +313,7 @@ export class DevSession {
    * @param payload - The payload to create the dev session with
    */
   private async devSessionCreateWithRetry(payload: DevSessionPayload): Promise<DevSessionResult> {
+    await this.logger.info(`Dev session create options: ${JSON.stringify(payload)}`)
     const result = await performActionWithRetryAfterRecovery(
       async () => this.options.developerPlatformClient.devSessionCreate(payload),
       () => this.options.developerPlatformClient.refreshToken(),

packages/app/src/cli/services/dev/processes/setup-dev-processes.ts

@@ -159,6 +159,7 @@ export async function setupDevProcesses({
           appPreviewURL: appPreviewUrl,
           appLocalProxyURL: devConsoleURL,
           devSessionStatusManager,
+          productionMode: commandOptions.productionMode,
         })
       : await setupDraftableExtensionsProcess({
           localApp: reloadedApp,

packages/app/src/cli/utilities/developer-platform-client.ts

@@ -197,6 +197,7 @@ export interface DevSessionOptions {
   shopFqdn: string
   appId: string
   assetsUrl: string
+  productionMode: boolean
 }
 
 type WithUserErrors<T> = T & {
@@ -299,6 +300,6 @@ export interface DeveloperPlatformClient {
   appDeepLink: (app: MinimalAppIdentifiers) => Promise<string>
   devSessionCreate: (input: DevSessionOptions) => Promise<DevSessionCreateMutation>
   devSessionUpdate: (input: DevSessionOptions) => Promise<DevSessionUpdateMutation>
-  devSessionDelete: (input: Omit<DevSessionOptions, 'assetsUrl'>) => Promise<DevSessionDeleteMutation>
+  devSessionDelete: (input: Omit<DevSessionOptions, 'assetsUrl' | 'productionMode'>) => Promise<DevSessionDeleteMutation>
   getCreateDevStoreLink: (input: string) => Promise<string>
 }

packages/app/src/cli/utilities/developer-platform-client/app-management-client.ts

@@ -940,17 +940,17 @@ export class AppManagementClient implements DeveloperPlatformClient {
     return appDeepLink({id, organizationId})
   }
 
-  async devSessionCreate({appId, assetsUrl, shopFqdn}: DevSessionOptions): Promise<DevSessionCreateMutation> {
+  async devSessionCreate({appId, assetsUrl, shopFqdn, productionMode}: DevSessionOptions): Promise<DevSessionCreateMutation> {
     const appIdNumber = String(numberFromGid(appId))
-    return appDevRequest(DevSessionCreate, shopFqdn, await this.token(), {appId: appIdNumber, assetsUrl})
+    return appDevRequest(DevSessionCreate, shopFqdn, await this.token(), {appId: appIdNumber, assetsUrl, productionMode})
   }
 
-  async devSessionUpdate({appId, assetsUrl, shopFqdn}: DevSessionOptions): Promise<DevSessionUpdateMutation> {
+  async devSessionUpdate({appId, assetsUrl, shopFqdn, productionMode}: DevSessionOptions): Promise<DevSessionUpdateMutation> {
     const appIdNumber = String(numberFromGid(appId))
-    return appDevRequest(DevSessionUpdate, shopFqdn, await this.token(), {appId: appIdNumber, assetsUrl})
+    return appDevRequest(DevSessionUpdate, shopFqdn, await this.token(), {appId: appIdNumber, assetsUrl, productionMode})
   }
 
-  async devSessionDelete({appId, shopFqdn}: Omit<DevSessionOptions, 'assetsUrl'>): Promise<DevSessionDeleteMutation> {
+  async devSessionDelete({appId, shopFqdn}: Omit<DevSessionOptions, 'assetsUrl' | 'productionMode'>): Promise<DevSessionDeleteMutation> {
     const appIdNumber = String(numberFromGid(appId))
     return appDevRequest(DevSessionDelete, shopFqdn, await this.token(), {appId: appIdNumber})
   }