add test for abort in theme environment

Author: EvilGenius13

packages/theme/src/cli/utilities/theme-environment/theme-environment.test.ts

@@ -11,10 +11,11 @@ import {describe, expect, test, vi, beforeEach, afterEach} from 'vitest'
 import {buildTheme} from '@shopify/cli-kit/node/themes/factories'
 import {createEvent} from 'h3'
 import * as output from '@shopify/cli-kit/node/output'
+import {fetchChecksums} from '@shopify/cli-kit/node/themes/api'
 import {IncomingMessage, ServerResponse} from 'node:http'
 import {Socket} from 'node:net'
 
-vi.mock('@shopify/cli-kit/node/themes/api', () => ({fetchChecksums: () => Promise.resolve([])}))
+vi.mock('@shopify/cli-kit/node/themes/api', () => ({fetchChecksums: vi.fn(() => Promise.resolve([]))}))
 vi.mock('./remote-theme-watcher.js')
 vi.mock('./storefront-renderer.js')
 vi.spyOn(output, 'outputDebug')
@@ -187,6 +188,22 @@ describe('setupDevServer', () => {
     })
   })
 
+  test('should catch errors from fetchChecksums and reject backgroundJobPromise', async () => {
+    // Given
+    const context: DevServerContext = {
+      ...defaultServerContext,
+    }
+    const expectedError = new Error('Failed to fetch checksums from API')
+
+    vi.mocked(fetchChecksums).mockRejectedValueOnce(expectedError)
+
+    // When
+    const {backgroundJobPromise} = setupDevServer(developmentTheme, context)
+
+    // Then
+    await expect(backgroundJobPromise).rejects.toThrow('Failed to fetch checksums from API')
+  })
+
   describe('request handling', async () => {
     const context = {...defaultServerContext}
     const server = setupDevServer(developmentTheme, context)

packages/theme/src/cli/utilities/theme-environment/theme-environment.ts

@@ -62,7 +62,9 @@ function ensureThemeEnvironmentSetup(
   const abort = (error: Error): never => {
     renderThrownError('Failed to perform the initial theme synchronization.', error)
     rejectBackgroundJob(error)
-    // Return a permanently pending promise to stop execution without throwing
+    // Return a never-resolving promise to stop this promise chain without throwing.
+    // Throwing would trigger catch handlers and continue execution. This stops the
+    // chain while the error is handled through the separate backgroundJobPromise channel.
     return new Promise<never>(() => {}) as never
   }