IconControl: fix update events for Windows

thewizrd · thewizrd · commit 22cda7f2f110 · 2025-07-10T13:54:37.000-04:00
diff --git a/SimpleWeather.Windows/Main/WeatherNow.xaml.cs b/SimpleWeather.Windows/Main/WeatherNow.xaml.cs
@@ -80,7 +80,6 @@ public ElementTheme ControlTheme
 
         private bool UpdateBindings = false;
         private bool UpdateTheme = false;
-        private bool ClearGraphIconCache = false;
 
         public WeatherNow()
         {
@@ -169,7 +168,6 @@ private void Settings_OnSettingsChanged(SettingsChangedEventArgs e)
             if (e.Key == SettingsManager.KEY_ICONSSOURCE)
             {
                 // When page is loaded again from cache, clear icon cache
-                ClearGraphIconCache = true;
                 UpdateBindings = true;
             }
             else if (e.Key == SettingsManager.KEY_USERTHEME)
@@ -420,12 +418,6 @@ protected override void OnNavigatedTo(NavigationEventArgs e)
                 UpdateTheme = false;
             }
 
-            if (ClearGraphIconCache)
-            {
-                WeatherBox?.UpdateWeatherIcon();
-                ClearGraphIconCache = false;
-            }
-
             if (UpdateBindings)
             {
                 this.Bindings.Update();

Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,6 @@ public ElementTheme ControlTheme`
`80`	`80`
`81`	`81`	`private bool UpdateBindings = false;`
`82`	`82`	`private bool UpdateTheme = false;`
`83`		`- private bool ClearGraphIconCache = false;`
`84`	`83`
`85`	`84`	`public WeatherNow()`
`86`	`85`	`{`
`@@ -169,7 +168,6 @@ private void Settings_OnSettingsChanged(SettingsChangedEventArgs e)`
`169`	`168`	`if (e.Key == SettingsManager.KEY_ICONSSOURCE)`
`170`	`169`	`{`
`171`	`170`	`// When page is loaded again from cache, clear icon cache`
`172`		`- ClearGraphIconCache = true;`
`173`	`171`	`UpdateBindings = true;`
`174`	`172`	`}`
`175`	`173`	`else if (e.Key == SettingsManager.KEY_USERTHEME)`
`@@ -420,12 +418,6 @@ protected override void OnNavigatedTo(NavigationEventArgs e)`
`420`	`418`	`UpdateTheme = false;`
`421`	`419`	`}`
`422`	`420`
`423`		`- if (ClearGraphIconCache)`
`424`		`- {`
`425`		`- WeatherBox?.UpdateWeatherIcon();`
`426`		`- ClearGraphIconCache = false;`
`427`		`- }`
`428`		`-`
`429`	`421`	`if (UpdateBindings)`
`430`	`422`	`{`
`431`	`423`	`this.Bindings.Update();`