Add failed directory handling to JSON review processing script

Implemented functionality to move invalid and failed JSON files to a dedicated 'failed' directory. This enhancement improves error management by organizing problematic files, allowing for easier troubleshooting and review of processing issues.

Author: stephen-rowan

Scripts/process_json_reviews.py

@@ -26,6 +26,7 @@
 REPO_NAME = "Graph-Python-scripts"
 REVIEWS_DIR = Path("reviews")
 PROCESSED_DIR = Path("reviews/processed")
+FAILED_DIR = Path("reviews/failed")
 
 # Method names to validate
 METHODS = [
@@ -181,6 +182,14 @@ def process_json_file(file_path: Path, repo: Any) -> Tuple[bool, Optional[str]]:
         is_valid, error_msg = validate_review(review_data)
         if not is_valid:
             print(f"  ✗ Validation failed: {error_msg}")
+            # Move invalid file to failed directory
+            try:
+                FAILED_DIR.mkdir(parents=True, exist_ok=True)
+                failed_path = FAILED_DIR / file_path.name
+                shutil.move(str(file_path), str(failed_path))
+                print(f"  → Moved invalid file to: {failed_path}")
+            except Exception as move_error:
+                print(f"  ⚠ Could not move invalid file: {move_error}", file=sys.stderr)
             return False, error_msg
         print(f"  ✓ Validation passed")
 
@@ -189,6 +198,14 @@ def process_json_file(file_path: Path, repo: Any) -> Tuple[bool, Optional[str]]:
         issue_number = create_github_issue(repo, review_data)
         if issue_number is None:
             print(f"  ✗ Failed to create GitHub Issue")
+            # Move failed file to failed directory
+            try:
+                FAILED_DIR.mkdir(parents=True, exist_ok=True)
+                failed_path = FAILED_DIR / file_path.name
+                shutil.move(str(file_path), str(failed_path))
+                print(f"  → Moved failed file to: {failed_path}")
+            except Exception as move_error:
+                print(f"  ⚠ Could not move failed file: {move_error}", file=sys.stderr)
             return False, "Failed to create GitHub Issue"
         print(f"  ✓ Created GitHub Issue #{issue_number}")
 
@@ -203,6 +220,15 @@ def process_json_file(file_path: Path, repo: Any) -> Tuple[bool, Optional[str]]:
 
     except json.JSONDecodeError as e:
         print(f"  ✗ JSON decode error: {e}")
+        # Move invalid JSON file to failed directory
+        try:
+            FAILED_DIR.mkdir(parents=True, exist_ok=True)
+            failed_path = FAILED_DIR / file_path.name
+            if file_path.exists():
+                shutil.move(str(file_path), str(failed_path))
+                print(f"  → Moved invalid JSON file to: {failed_path}")
+        except Exception as move_error:
+            print(f"  ⚠ Could not move invalid file: {move_error}", file=sys.stderr)
         return False, f"Invalid JSON: {e}"
     except FileNotFoundError as e:
         print(f"  ✗ File not found: {e}")
@@ -214,6 +240,14 @@ def process_json_file(file_path: Path, repo: Any) -> Tuple[bool, Optional[str]]:
         print(f"  ✗ Unexpected error: {e}")
         import traceback
         traceback.print_exc()
+        # Move failed file to failed directory
+        try:
+            FAILED_DIR.mkdir(parents=True, exist_ok=True)
+            failed_path = FAILED_DIR / file_path.name
+            shutil.move(str(file_path), str(failed_path))
+            print(f"  → Moved failed file to: {failed_path}")
+        except Exception as move_error:
+            print(f"  ⚠ Could not move failed file: {move_error}", file=sys.stderr)
         return False, f"Error processing file: {e}"
 
 
@@ -248,8 +282,10 @@ def main() -> None:
     print(f"\nChecking directories...")
     os.makedirs(REVIEWS_DIR, exist_ok=True)
     os.makedirs(PROCESSED_DIR, exist_ok=True)
+    os.makedirs(FAILED_DIR, exist_ok=True)
     print(f"✓ Reviews directory: {REVIEWS_DIR}")
     print(f"✓ Processed directory: {PROCESSED_DIR}")
+    print(f"✓ Failed directory: {FAILED_DIR}")
 
     # Find all JSON files in reviews directory (exclude processed directory)
     print(f"\nScanning for JSON files in {REVIEWS_DIR}...")