Enhance review processing script and GitHub Actions workflow

Added a function to ensure required labels exist in the GitHub repository, improving issue creation reliability. Updated the workflow to handle failures gracefully during the processing of JSON reviews, ensuring commits are attempted even if previous steps fail. Enhanced error handling in the script for better debugging and user feedback.

Author: stephen-rowan

.github/workflows/process_json_reviews.yml

@@ -35,18 +35,19 @@ jobs:
       env:
         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       run: |
-        python scripts/process_json_reviews.py
+        python scripts/process_json_reviews.py || exit 1
     
     - name: Commit and push processed files
+      if: success() || failure()  # Run even if previous step failed
       run: |
         git config --local user.email "[email protected]"
         git config --local user.name "GitHub Action"
         git remote set-url origin https://x-access-token:${{ secrets.GITHUB_TOKEN }}@github.com/${{ github.repository }}.git
-        git add reviews/processed/
+        git add reviews/processed/ || true
         if git diff --staged --quiet; then
           echo "No processed files to commit"
         else
-          git commit -m "Move processed JSON reviews to processed/ directory [skip ci]"
-          git push origin HEAD:main
+          git commit -m "Move processed JSON reviews to processed/ directory [skip ci]" || exit 0
+          git push origin HEAD:main || exit 0
         fi
 

Scripts/process_json_reviews.py

@@ -108,9 +108,33 @@ def format_issue_body(review_data: Dict[str, Any]) -> str:
     return "\n".join(body_lines)
 
 
+def ensure_labels_exist(repo: Any) -> None:
+    """Ensure required labels exist in the repository."""
+    required_labels = {
+        "review": "1f76b4",  # Blue
+        "correct": "0e8a16",  # Green
+        "needs-review": "fbca04",  # Yellow
+        "incorrect": "d73a4a",  # Red
+    }
+    
+    existing_labels = {label.name: label for label in repo.get_labels()}
+    
+    for label_name, label_color in required_labels.items():
+        if label_name not in existing_labels:
+            try:
+                repo.create_label(label_name, label_color)
+                print(f"  ✓ Created label: {label_name}")
+            except Exception as e:
+                # Label might already exist or we don't have permission
+                print(f"  ⚠ Could not create label '{label_name}': {e}", file=sys.stderr)
+
+
 def create_github_issue(repo: Any, review_data: Dict[str, Any]) -> Optional[int]:
     """Create a GitHub Issue from review data."""
     try:
+        # Ensure labels exist
+        ensure_labels_exist(repo)
+        
         title = f"[Review] {review_data['method'].replace('-', ' ').title()}"
         body = format_issue_body(review_data)
 
@@ -129,6 +153,8 @@ def create_github_issue(repo: Any, review_data: Dict[str, Any]) -> Optional[int]
 
     except Exception as e:
         print(f"  ✗ Error creating issue: {e}", file=sys.stderr)
+        import traceback
+        traceback.print_exc()
         return None
 
 
@@ -172,8 +198,14 @@ def main() -> None:
         sys.exit(1)
 
     # Initialize GitHub client
-    g = Github(github_token)
-    repo = g.get_repo(f"{REPO_OWNER}/{REPO_NAME}")
+    try:
+        g = Github(github_token)
+        repo = g.get_repo(f"{REPO_OWNER}/{REPO_NAME}")
+    except Exception as e:
+        print(f"Error: Failed to connect to GitHub repository: {e}", file=sys.stderr)
+        import traceback
+        traceback.print_exc()
+        sys.exit(2)
 
     # Ensure directories exist
     os.makedirs(REVIEWS_DIR, exist_ok=True)