Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in xml generation for ExtrudedPolygon in Phase2 upgrade file #2

Open
tpmccauley opened this issue Aug 18, 2023 · 0 comments
Open

Comments

@tpmccauley
Copy link
Member

When running for Phase2 upgrades the ExtrudedPolygon elements are generated incorrectly.

There seem to be a missing closing > for ExtrudedPolygon e.g.:

<ExtrudedPolygon name="hgcalwafer:HGCalEEEpoxyT0Finedm0" <XYPoint x="64.495810000000005857*mm" y="58.857967419033720091*mm"/>
 <XYPoint x="-18.724589999999999179*mm" y="-85.283993607171296958*mm"/>
 <XYPoint x="0.000000000000000000*mm" y="-96.094640684136678033*mm"/>
 <XYPoint x="83.220399999999997931*mm" y="-48.047320342068339016*mm"/>
 <XYPoint x="83.220399999999997931*mm" y="48.047320342068339016*mm"/>
 <ZXYSection z="-0.032500000000000001*mm" x="0.000000000000000000*mm" y="0.000000000000000000*mm scale=1.000000000000000000*mm"/>
 <ZXYSection z="0.032500000000000001*mm" x="0.000000000000000000*mm" y="0.000000000000000000*mm scale=1.000000000000000000*mm"/>
</ExtrudedPolygon>

This creates a parse error.

It can easily be fixed by-hand:

<ExtrudedPolygon name="hgcalwafer:HGCalEEEpoxyT0Finedm0"> 
<XYPoint x="64.495810000000005857*mm" y="58.857967419033720091*mm"/>
 <XYPoint x="-18.724589999999999179*mm" y="-85.283993607171296958*mm"/>
 <XYPoint x="0.000000000000000000*mm" y="-96.094640684136678033*mm"/>
 <XYPoint x="83.220399999999997931*mm" y="-48.047320342068339016*mm"/>
 <XYPoint x="83.220399999999997931*mm" y="48.047320342068339016*mm"/>
 <ZXYSection z="-0.032500000000000001*mm" x="0.000000000000000000*mm" y="0.000000000000000000*mm scale=1.000000000000000000*mm"/>
 <ZXYSection z="0.032500000000000001*mm" x="0.000000000000000000*mm" y="0.000000000000000000*mm scale=1.000000000000000000*mm"/>
</ExtrudedPolygon>

but this should be fixed in the xml generation.

Note that ExtrudedPolygon doesn't appear in previous xml files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant