Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use response code to verify if request is success or not #98

Open
Navya-Teja-Otturu opened this issue Oct 14, 2024 · 3 comments
Open

Use response code to verify if request is success or not #98

Navya-Teja-Otturu opened this issue Oct 14, 2024 · 3 comments

Comments

@Navya-Teja-Otturu
Copy link

In my case the action is failing the GitHub workflow job even when the notification ends up in MS TEAMS. After looking at the code I realise that an error is thrown when there is not text response. I did the same POST request the action is doing via the Postman and found that I get a 202 response without any text(attached the screenshot of the response).

Screenshot 2024-10-14 at 10 39 43

Hence, I would suggest to also check the response code before throwing an error.

@Trimud
Copy link

Trimud commented Oct 21, 2024

I am facing the same issue

image

@isihu
Copy link

isihu commented Nov 6, 2024

I have the same error and created a fork fixing this problem. Feel free to test it. Simply replace skitionek/notify-microsoft-teams@master with isihu/notify-microsoft-teams@master. I have also created a Pull Request here.

If it fixes your problem, please leave feedback. Maybe we can merge this upstream.

@dejohansson
Copy link

I've encountered the same problem and would love to keep using this project. @Skitionek are there any plans to merge #99?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants