Add support for expanded custom model data.

[Evanbeer]

Skript/Server Version

[Skript] Skript's aliases can be found here: https://github.com/SkriptLang/skript-aliases
[Skript] Skript's documentation can be found here: https://docs.skriptlang.org/
[Skript] Skript's tutorials can be found here: https://docs.skriptlang.org/tutorials
[Skript] Server Version: 1.21.4-222-9b1798d (MC: 1.21.4)
[Skript] Skript Version: 2.10.2 (skriptlang-github)
[Skript] Installed Skript Addons: 
[Skript]  - SkBee v3.10.2 (https://github.com/ShaneBeee/SkBee)
[Skript]  - DiSky v4.22.1
[Skript] Installed dependencies: 
[Skript]  - Vault v1.7.3-b131
[Skript]  - WorldGuard v7.0.13+82fdc65

Bug Description

Custom model data got changed in 1.21.4. I can still add custom model data to items using the existing expression, but the textures assigned to that item will not appear.

Expected Behavior

It should behave like it used to, you can add a custom model data to an item and it will use the correct texture assigned with that custom model data.

Steps to Reproduce

Run a server and client on 1.21.4, create a texturepack which assigns a texture to an item when it has a specific custom model data. You can use this new 1.21.4 command to give yourself the working item with the correct texture:
/minecraft:give player map[minecraft:custom_model_data={strings:['1']}]

Then make a skript with something like:
Give 1 map with custom model data 1 to player

And then the texture wont appear even through the item has the custom model data.
I believe this is caused by the game expecting a list and not a single integer.

Errors or Screenshots

The one made with skript:

The one made with commands:

Other

I need custom model data to use my texturepack, i would really appreciate if this gets patched back to its normal behavior as soon as possible.

Agreement

• I have read the guidelines above and affirm I am following them with this report.

[ShaneBeee]

While you wait for Skript to add/update this new stuff, I just wanted to let you know SkBee has:

• custom model data section
• item model expression

[TheMug06]

give me 1 diamond sword with custom model data 2 (Using a pack which has that CMD defined) works just fine for me, custom model/textures render perfectly. It could depend on the way the pack is made. For now you can use SkBee's expression/section for model stuff (ShaneBee has sent above :D).

[sovdeeth]

Yes, your example command adds a string custom model data. The backcompatability for custom model data adds a single float number to the custom model data, so you'd want map[minecraft:custom_model_data={floats:[1.0f]}].

[Evanbeer]

I'll use skbee's function for the time being thank you Shane, i disagree with the issue being put at low priority, since it is a pretty important issue.
And TheMug06, the issue as stated in the post only comes at the latest minecraft version (1.21.4+). Everything bellow that works perfectly as you said.

[Evanbeer]

Okay after messing arround a bit more with my recoursepack, this issue only occurs when you use the "Select" model type. I believe if you use the "Range_Dispatch" model it should work with how skript handles custom model data. I haven't got to testing that out yet.

[TheMug06]

i disagree with the issue being put at low priority, since it is a pretty important issue.

I've put this issue at low priority, since there are current easy workarounds in place (SkBee) <3), and the issue is only for certain model types

And TheMug06, the issue as stated in the post only comes at the latest minecraft version (1.21.4+). Everything bellow that works perfectly as you said.

I've tested it on 1.21.4, it works there, whether it works depends on the model type indeed, Range_Dispatch works with Skript's current implementation.

[Evanbeer]

I havent got to messing arround with Range_Dispatch, and i couldnt find much documentation about it either
I managed to figure out the select model type after a while, which i currently use.

{
  "model": {
    "type": "select",
    "property": "custom_model_data",
    "fallback": {
      "type": "model",
      "model": "item/map"
    }
    "cases": [
      {
        "when": "1",
        "model": {
          "type": "model",
          "model": "guis/invisibleitem"
        }
      }
    ]
  }
}

And i can get it in game with skript with skbee <3:

	set {_map} to a map
	apply custom model data to {_map}:
		strings: "1"

But how would i go about using the Range_Dispatch model type? And will i just be able to go back to the old way of using

give a map with custom model data 1 to player

I dont really get why minecraft had to change this all of a sudden either, but well yeah thats just minecraft.

[TheMug06]

But how would i go about using the Range_Dispatch model type? And will i just be able to go back to the old way of using ...

Here's a small example of what it would look like;

{
    "model": {
        "type": "range_dispatch",
        "property": "custom_model_data",
        "fallback": {
            "type": "model",
            "model": "item/diamond_sword"
        },
        "entries": [
            {
                "threshold": 1,
                "model": {
                    "type": "model",
                    "model": "item/custom/katana"
                }
            },
            {
                "threshold": 2,
                "model": {
                    "type": "model",
                    "model": "item/custom/shortsword"
                }
            }
        ]
    }
}

With that, you are able to use the existing Skript syntax, but it may limit you (I don't know what the difference between range_dispatch and select is exactly) in some other capacity (?)

[Evanbeer]

I attempted your method, but i cant seem to get the textures to apply at all using that method.

{
  "model": {
    "type": "range_dispatch",
    "property": "custom_model_data",
    "fallback": {
      "type": "model",
      "model": "item/map"
    },
    "entries": [
      {
        "treshold": "1",
        "model": {
          "type": "model",
          "model": "guis/invisibleitem"
        }
      },
      {
        "treshold": "2",
        "model": {
          "type": "model",
          "model": "guis/close"
        }
      },
      {
        "treshold": "3",
        "model": {
          "type": "model",
          "model": "guis/empty"
        }
      },
      {
        "treshold": "4",
        "model": {
          "type": "model",
          "model": "guis/left"
        }
      },
      {
        "treshold": "5",
        "model": {
          "type": "model",
          "model": "guis/right"
        }
      },
      {
        "treshold": "6",
        "model": {
          "type": "model",
          "model": "guis/rclose"
        }
      },
      {
        "treshold": "7",
        "model": {
          "type": "model",
          "model": "guis/rright"
        }
      },
      {
        "treshold": "8",
        "model": {
          "type": "model",
          "model": "guis/rleft"
        }
      },
      {
        "treshold": "9",
        "model": {
          "type": "model",
          "model": "guis/ropen"
        }
      },
      {
        "treshold": "10",
        "model": {
          "type": "model",
          "model": "guis/lock"
        }
      },
      {
        "treshold": "11",
        "model": {
          "type": "model",
          "model": "appicon/market"
        }
      },
      {
        "treshold": "12",
        "model": {
          "type": "model",
          "model": "appicon/blackmarket"
        }
      },
      {
        "treshold": "13",
        "model": {
          "type": "model",
          "model": "appicon/maps"
        }
      },
      {
        "treshold": "14",
        "model": {
          "type": "model",
          "model": "appicon/dealer"
        }
      }
    ]
  }
}

[sovdeeth]

I attempted your method, but i cant seem to get the textures to apply at all using that method.

{
  "model": {
    "type": "range_dispatch",
    "property": "custom_model_data",
    "fallback": {
      "type": "model",
      "model": "item/map"
    },
    "entries": [
      {
        "treshold": "1",
        "model": {
          "type": "model",
          "model": "guis/invisibleitem"
        }
      },

You have misspelled threshold and you are using strings, not numbers. "14" vs 14

[Evanbeer]

I see, thanks