Skip to content

[Suggestion] Acknowledging UCGM in both Code and Technical Report (as referenced in Saining Xie et al.) #36

@sp12138

Description

@sp12138

Hello @SkyworkAI-Team,

Thanks for the great work on UniPic!

While going through the code, I noticed that the implementation of the Finite Difference technique in train_cm_dmd.py shares the same logic and specific variable naming as the UCGM repository.

UniPic: train_cm_dmd.py (L79-L88)

UCGM: unigen.py (L278-L291)

Since this technique is widely recognized as originating from UCGM, other recent works (e.g., Saining Xie et al. in arXiv:2601.09881) have explicitly cited it when using the same method.

To align with these community standards, I have two kind suggestions:

  • Add a code comment: It would be helpful to mark the source in the code (e.g., # Adapted from UCGM: https://github.com/LINs-lab/UCGM) so future developers know where this technique comes from.

  • Update References: Consider adding UCGM to the reference list in the README or Technical Report to acknowledge their contribution.

Hope this is helpful for refining the project!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions