Skip to content

Commit f0e5bae

Browse files
committed
Remove as much warnings as possible
Project goes rom 200+ warnings to 7 due to tools and third parties, 0 warning on project sources. - remove unused parameters warnings by commenting the parameter name - remove reorder warning by matching init order with declaration order - remove make "jobserver unavailable" warning by using $(MAKE) i.e. make in .pro file - fixed actual issues (e.g. missing return statement) - also uses XPCF MACROs for attributes so that we can disable them at once and remove GCC warnings on ignored atributes.
1 parent dcc6aaf commit f0e5bae

File tree

129 files changed

+211
-209
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

129 files changed

+211
-209
lines changed

SolARFramework.pro

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,11 @@ DEFINES += "_BCOM_SHARED=__declspec(dllexport)"
4242

4343
include (SolARFramework.pri)
4444

45+
DEFINES += XPCF_DISABLE_ATTRIBUTES
46+
4547
unix {
4648
# Avoids adding install steps manually. To be commented to have a better control over them.
47-
QMAKE_POST_LINK += "make install"
49+
QMAKE_POST_LINK += "$(MAKE) install"
4850
}
4951

5052
linux {

interfaces/api/display/I2DOverlay.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ namespace display {
3636
* This class provides drawing methods to overlay 2D debug informations on top of an image.
3737
*/
3838

39-
class [[xpcf::clientUUID("f7d538cd-1d6f-4daa-8701-3e31357c213e")]] [[xpcf::serverUUID("ad47d50c-83d6-4b63-af31-8cf3642addd0")]] I2DOverlay :
39+
class XPCF_CLIENTUUID("f7d538cd-1d6f-4daa-8701-3e31357c213e") XPCF_SERVERUUID("ad47d50c-83d6-4b63-af31-8cf3642addd0") I2DOverlay :
4040
virtual public org::bcom::xpcf::IComponentIntrospect {
4141
public:
4242
/// @brief I2DOverlay default constructor

interfaces/api/display/I3DOverlay.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ namespace display {
3434
*
3535
* This class provides drawing method to overlay 3D debug informations on top of an image.
3636
*/
37-
class [[xpcf::clientUUID("ce48f688-bb48-4d61-800c-e504c0d060a8")]] [[xpcf::serverUUID("cb391967-f407-4a67-b092-26d44de001ce")]] I3DOverlay :
37+
class XPCF_CLIENTUUID("ce48f688-bb48-4d61-800c-e504c0d060a8") XPCF_SERVERUUID("cb391967-f407-4a67-b092-26d44de001ce") I3DOverlay :
3838
virtual public org::bcom::xpcf::IComponentIntrospect {
3939
public:
4040
/// @brief I3DOverlay default constructor

interfaces/api/display/I3DPointsViewer.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ namespace display {
3333
*
3434
* This class provides a viewer to display points cloud in a window.
3535
*/
36-
class [[xpcf::clientUUID("423cd9a6-f93a-4e1b-88f0-0762c1db5db3")]] [[xpcf::serverUUID("15e7a40b-9269-40a1-b95d-7139cff7ee4c")]] I3DPointsViewer :
36+
class XPCF_CLIENTUUID("423cd9a6-f93a-4e1b-88f0-0762c1db5db3") XPCF_SERVERUUID("15e7a40b-9269-40a1-b95d-7139cff7ee4c") I3DPointsViewer :
3737
virtual public org::bcom::xpcf::IComponentIntrospect {
3838
public:
3939
/// @brief I3DPointsViewer default constructor

interfaces/api/display/IImageViewer.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ namespace display {
3232
* This class provides a viewer to display an image in a window.
3333
*/
3434

35-
class [[xpcf::clientUUID("a580d26e-331d-42d4-8bfe-f19913ba97fb")]] [[xpcf::serverUUID("b99d8c4e-10ef-4d7a-ba7c-dfa114cf1620")]] IImageViewer :
35+
class XPCF_CLIENTUUID("a580d26e-331d-42d4-8bfe-f19913ba97fb") XPCF_SERVERUUID("b99d8c4e-10ef-4d7a-ba7c-dfa114cf1620") IImageViewer :
3636
virtual public org::bcom::xpcf::IComponentIntrospect {
3737
public:
3838
virtual ~IImageViewer() = default;

interfaces/api/display/IMaskOverlay.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ namespace display {
3232
* <TT>UUID: 35a2454a-cb09-44ac-b2ce-0b0732175f94</TT>
3333
*/
3434

35-
class [[xpcf::clientUUID("10d2d826-714e-4eb9-91d4-9c577585ddfe")]] [[xpcf::serverUUID("86974141-74a8-40a2-8150-c20eda855ed4")]] IMaskOverlay :
35+
class XPCF_CLIENTUUID("10d2d826-714e-4eb9-91d4-9c577585ddfe") XPCF_SERVERUUID("86974141-74a8-40a2-8150-c20eda855ed4") IMaskOverlay :
3636
virtual public org::bcom::xpcf::IComponentIntrospect {
3737
public:
3838
/// @brief IMaskOverlay default constructor

interfaces/api/display/IMatchesOverlay.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ namespace display {
3535
*
3636
* This class provides drawing method to overlay matches between two images.
3737
*/
38-
class [[xpcf::clientUUID("a35aa6c7-ce39-4158-866d-5b0210267c12")]] [[xpcf::serverUUID("ef9096d0-c4ec-430d-8424-993b9010e3e3")]] IMatchesOverlay :
38+
class XPCF_CLIENTUUID("a35aa6c7-ce39-4158-866d-5b0210267c12") XPCF_SERVERUUID("ef9096d0-c4ec-430d-8424-993b9010e3e3") IMatchesOverlay :
3939
virtual public org::bcom::xpcf::IComponentIntrospect {
4040
public:
4141
/// @brief IMatchesOverlay default constructor

interfaces/api/features/I2DTrackablesDetector.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ namespace features {
3232
* @brief <B>Detect a set of given 2D trackables in an image.</B>
3333
* <TT>UUID: 607d0b0d-766d-4ff2-9b72-45c555f9726f</TT>
3434
*/
35-
class [[xpcf::clientUUID("b62759a5-069a-40b0-846e-71f6adc9cb5e")]] [[xpcf::serverUUID("b73bdd5a-aecb-4e63-b40f-cd05fa7b8490")]] I2DTrackablesDetector :
35+
class XPCF_CLIENTUUID("b62759a5-069a-40b0-846e-71f6adc9cb5e") XPCF_SERVERUUID("b73bdd5a-aecb-4e63-b40f-cd05fa7b8490") I2DTrackablesDetector :
3636
virtual public org::bcom::xpcf::IComponentIntrospect {
3737
public:
3838
///@brief I2DTrackablesDetector default constructor.

interfaces/api/features/IContoursExtractor.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ namespace features {
3434
*/
3535

3636

37-
class [[xpcf::clientUUID("892788ad-8366-4d79-aec8-92aa4ed34665")]] [[xpcf::serverUUID("a2e6ed26-7795-407b-b7e6-e04140c8ab80")]] IContoursExtractor :
37+
class XPCF_CLIENTUUID("892788ad-8366-4d79-aec8-92aa4ed34665") XPCF_SERVERUUID("a2e6ed26-7795-407b-b7e6-e04140c8ab80") IContoursExtractor :
3838
virtual public org::bcom::xpcf::IComponentIntrospect {
3939
public:
4040
/// @brief IContoursExtractor default constructor

interfaces/api/features/IContoursFilter.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ namespace features {
3434
* This class provides a filtering method to prune a set of contours.
3535
*/
3636

37-
class [[xpcf::clientUUID("a8cad1a4-be07-43df-90f3-4bf7d7481528")]] [[xpcf::serverUUID("571317b1-4fe5-44cc-bf86-4c4c079150c3")]] IContoursFilter :
37+
class XPCF_CLIENTUUID("a8cad1a4-be07-43df-90f3-4bf7d7481528") XPCF_SERVERUUID("571317b1-4fe5-44cc-bf86-4c4c079150c3") IContoursFilter :
3838
virtual public org::bcom::xpcf::IComponentIntrospect {
3939
public:
4040
/// @brief IContoursFilter default constructor

0 commit comments

Comments
 (0)